From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1B633FF1 for ; Sat, 3 Jan 2026 09:24:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767432268; cv=none; b=KFXgplcyNOdsxfVJBlMWH44KJ1aL6KNeJppIbxd0uBSl1vsZuK1iTbTFQ6UyFqzqSKhhAjvZv/iTH+fFhSi752wrDNx/l4Adsg7bIeolimrATZvR0TiuostfbnPs1bYBN0+oBJsvSZlpJJCAhBYXRuTmSLwavakTN78YWRp5WYE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767432268; c=relaxed/simple; bh=dxBTfAqbU+ssYiCyBcmLofVhgWHDWq+BxIX6sti7n9M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=h+1UUcVELTRfWsbMkSwJZrjCDqMYC8oS1Gl2yN8DLnkmgdQNT27JU/nDLhqg3xO4f9aOBCwPSeDAiicPmvWIFixqrLzTNG/jcUuxh3rKLcy5QTcNJe97IEaQZ+67qUpZqxYxJ+AJC4l6/M1epDZD1GNDIOnl/LqK5XiIWY/PDRY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d8HzXp6S; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d8HzXp6S" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2a102494058so2368885ad.0 for ; Sat, 03 Jan 2026 01:24:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767432266; x=1768037066; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3rBvkbWafymKYM9EOiGX/O5p8v9z+L13Xl9gXWhIxg8=; b=d8HzXp6Sv1tVxsd1seIRycsQLIRjCExOuanRIULd9UpxHDlTv1LWQIXkuFCHdDm58S DuO22/cAcDnfU06SBxiKuBlYTI/DI6KHn0GzK8fEvf8O4Fg4mH3wzA0oHgFdcYHBEu0G +xwioL8ICw4yD+tPKt38Bur/iwT8y4F5Jj3rdMs+ITY3fd3B1OGls1pvCbZva2MlcXmy GQYLXnrxAph/bMKt4+u0LhLbzYeQJ83dLIBuTpwHagS52rZUzcT+pWP6kXp9ROtaeU24 2dS3V3a830wOvO6kYUvH/ClglzzwM15DZfMQzHpc6a7hICzXpkUo/7fl9vd+YJbqLmlG ZrFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767432266; x=1768037066; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3rBvkbWafymKYM9EOiGX/O5p8v9z+L13Xl9gXWhIxg8=; b=Gpq6xWjk41uQsyNIE0eoNCm+hMTK9z19Fh/4ovPqYyNnli1Nzem6kZUnRbHJthq5Xp edBjxI8emLOtNKxu8M4gnPrqXTktMuikBx57UX282ErQ1PdWuTSrNg6ys5+5bIURNxaI dvec5XbwakfmVTqRvsEaKflKuNaQP7DHKFpgPX9hEKZ0bplnE2IA/O72aHym95N0O9pM JzlEjs8kCL2ZZbhujPUN8t2vql0U3LDywUYO7NtfhbQoQiRfus0DCb6EjnlghaWLTUpu TFg7KwzQ384TgUzBQtxYi5IvuU6LZjl97WMArSNc5/2wDF8iyXoKR4edTVoKuYnnaOa9 dG7w== X-Gm-Message-State: AOJu0YwwH1obEkE3pZaRywJct2d0AeU6S6rZFp4QgSBOrfCTr3sQjgBW AJzvjF+R/Fk3HDhzG+6K0Jog/ayTmQw5um0PQEOUchPytnISAhm62qAL X-Gm-Gg: AY/fxX7rNhDdff5tqMZE6ObybmzuBE9zkSJW84uGVx15yjDhrupAtTi5jQWfvoCQbLm O57hP+CDFZooP+6l1p5Q4Ii+xiolC3eqjV82CWBOQeQ67TvIRsykVpAF7/6kgzPucxPbjyR9bTQ JiMs8sT84Opw0Mm5ML7w4QQwRd2RzNJB/BVZGThJS0Exdyx3GaFwkDbmTVKF7YsstVeu53yNsBZ um9shA1o3X6e6Nl1PtfA/jWnklbSbup28EEEJ3QSq9Hdz9VVrKC9CIlNN9oWiN0sSTusbmu+KcN ydYVl3rMgWqZGH6MD+5gqJgwjJDYwViZQYXF9HXFGf+EeVAgZgMFMO/t/phRzKG/rPE9W0+sbwr jF4F9h6o89DavDHlIXx2g4AfPfo/LZ+Hef7ehlUg06XFAec0lLQlhQlv6AjTGoLhB412mGbEIDA dKIXRrWphhjHk= X-Google-Smtp-Source: AGHT+IF5WnbVRDZXotUf8TYSEatYXXMtOCulL97ured8qdtvof9WPxhocfj6Wfwn8gpky0XJdeJhYw== X-Received: by 2002:a17:903:1b07:b0:294:8c99:f318 with SMTP id d9443c01a7336-2a3c0956190mr21049255ad.3.1767432266011; Sat, 03 Jan 2026 01:24:26 -0800 (PST) Received: from archie.me ([210.87.74.117]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3c8286esm400700485ad.33.2026.01.03.01.24.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Jan 2026 01:24:24 -0800 (PST) Received: by archie.me (Postfix, from userid 1000) id 088484092C2B; Sat, 03 Jan 2026 16:24:22 +0700 (WIB) Date: Sat, 3 Jan 2026 16:24:22 +0700 From: Bagas Sanjaya To: Alex Tran , Andy Whitcroft , Joe Perches , Dwaipayan Ray , Lukas Bulwahn Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley Subject: Re: [PATCH] checkpatch: Fix false positive check for dt-binding docs and include Message-ID: References: <20251224-checkscript_dt_bindings_fp-v1-1-0e18877ced62@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6ebmoGS4bKF0vTAw" Content-Disposition: inline In-Reply-To: <20251224-checkscript_dt_bindings_fp-v1-1-0e18877ced62@gmail.com> --6ebmoGS4bKF0vTAw Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable [CC'ing devicetree people] On Wed, Dec 24, 2025 at 05:41:17PM -0800, Alex Tran wrote: > The check for when to display a DT_SPLIT_BINDING_PATCH warning > is performed on all files that are not MAINTAINERS files. > This causes issues, specifically when checking against a > patch that only touches docs/dt-bindings or a patch that > only touches include/dt-bindings. The warning is still > displayed when it should not be, giving false positives. >=20 > The check for when to issue a DT_SPLIT_BINDING_PATCH warning > is currently too pervasive and should only be performed when > a change under docs/dt-bindings is detected or include/dt-bindings. > If the current changed file is under include/dt-bindings or > docs/dt-bindings then it is compared to the last file detected > under include/dt-bindings or docs/dt-bindings. If there is a > difference then a warning is issued. Can you elaborate on example of where this issue occurs? I'm still confused... >=20 > Signed-off-by: Alex Tran > --- > scripts/checkpatch.pl | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index c0250244cf7a3cb5e289b04fa4a9f644692dc278..fe3499bc9adda158c88231b48= b3b0100f3af0ee1 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2668,7 +2668,7 @@ sub process { > my $authorsignoff =3D 0; > my $author_sob =3D ''; > my $is_patch =3D 0; > - my $is_binding_patch =3D -1; > + my $is_doc_binding_patch =3D -1; > my $in_header_lines =3D $file ? 0 : 1; > my $in_commit_log =3D 0; #Scanning lines before patch > my $has_patch_separator =3D 0; #Found a --- line > @@ -2924,13 +2924,13 @@ sub process { > } > $checklicenseline =3D 1; > =20 > - if ($realfile !~ /^MAINTAINERS/) { > - my $last_binding_patch =3D $is_binding_patch; > + if ($realfile =3D~ m@^(?:Documentation/devicetree/|include/dt-binding= s/)@) { > + my $last_binding_patch_is_doc =3D $is_doc_binding_patch; > =20 > - $is_binding_patch =3D () =3D $realfile =3D~ m@^(?:Documentation/devi= cetree/|include/dt-bindings/)@; > + $is_doc_binding_patch =3D () =3D $realfile =3D~ m@^(?:Documentation/= devicetree/)@; > =20 > - if (($last_binding_patch !=3D -1) && > - ($last_binding_patch ^ $is_binding_patch)) { > + if (($last_binding_patch_is_doc !=3D -1) && > + ($last_binding_patch_is_doc ^ $is_doc_binding_patch)) { > WARN("DT_SPLIT_BINDING_PATCH", > "DT binding docs and includes should be a separate patch. See:= Documentation/devicetree/bindings/submitting-patches.rst\n"); > } >=20 I can't say for the actuall diff, though. Thanks. --=20 An old man doll... just what I always wanted! - Clara --6ebmoGS4bKF0vTAw Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCaVjgRgAKCRD2uYlJVVFO ox7hAQDfn980jqte9BkPwixk9XoUzaNjYpqT/e4wyg9tRHk4dAEA851Dr+KzTRkO UdXS3N2Jf5QfORvhS7Qy30knYVgmlQ4= =nA77 -----END PGP SIGNATURE----- --6ebmoGS4bKF0vTAw--