From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04F221A9FAB for ; Sat, 3 Jan 2026 21:16:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767474975; cv=none; b=RPg9bBOo38r6g4BEK5OhaKogRB7OZxUpzrSezqnT+9i7atlnDHzt/j5xhEBE+0jvWxZreI7TCXpuUW35tPO5MP2kP0780IbgjVS8BswkpIx09B9SOLSrql+huHKYAZb+yzxAW7nbzAyOFh7eYtr+ALqbaCZzqJp0xvcSq4FVrZ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767474975; c=relaxed/simple; bh=uiOLYSm61ERq2gPGbffcOs1yp9L6ssLDhSpjJurNdxU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=osWRO+EnWcUYsHbfug0L7T5g4fEpYZSBgR0G+zOEq3gglipYQFSoGBHdiRHY8Z9rG7nJNrwtJsQpl6fvZEZ+ssuGazijg+FSZs2GIapjuChJUw7/i7CQ0v6VUmWVgj2gq7tWmNWCdxT4n0WqiBN6v8KldZ5TRxKs8jpLQD2pVRM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=markoturk.info; spf=pass smtp.mailfrom=markoturk.info; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=markoturk.info Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=markoturk.info Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-64baaa754c6so14518923a12.3 for ; Sat, 03 Jan 2026 13:16:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767474971; x=1768079771; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d7unVhQC3T8DNmPkvBEAcaa6tSYQmAuHw+iiC51rCJE=; b=KYWUBrNjM+ELkpcgEIbQf4AVtrLcNYj3fidECBO8G0u27ovPZ6wIEXrlwIcVvrO8SD TYLw64CJlkEDkaVfPVHewff6vFq1e/MQrGR6CIbFvh97yzUO3LeXFaZx48BT7kcZqnv8 eWbQ72AlweyvW6an45O1d4wVBJF0ATETFOIIHqX8IRRR76WW7vJjEcwSA6CdM08XTJY7 WID7pra+SzDhPJLvmbpAbLqRwGlXTLq5xMMtNWY9wBvs5sWbW9BNysfHz2wi3yUe9QuF OOvMCArsPsDo+/H3RW+7LSk+xMIOuDszL3Csto/k1t6+iWf6T6kz0jurRnlEQpdNVDVU 6M6Q== X-Forwarded-Encrypted: i=1; AJvYcCVRkwZvcf66ila5kk/Mu/PG7nGbq9i1t+dPwrsAbMJ5HdqzXIiOzuc637imCMIER/Zd5CMZOvinA/MF/6M=@vger.kernel.org X-Gm-Message-State: AOJu0YxTjS/Wm/i/d9aV3IgDarKUB16x/QpyUJKoRfS7EGV26gVHow2K YjeZpRt/pw9EKMvGziDU/8u9/wJpS1wDcXnmPU3SgRWoj7oWxziHrHUb1d2Nx/iPu8w= X-Gm-Gg: AY/fxX6eNypoOm9g7A6QI4Rf298KGkSZvXXqdGsMY1XcBlrdEOUJDA0wgYT4U9ASKJB oFLQNImaewpXXwVyLaSd2mjd2mZaD26N3uLl6ecc84CXoviPVVsAdTYQx0NEliVrD9oSeQvpEl8 /c8JFa/qSJw6jcA+y8xd9C7TgQuVxa42VOVhkMDj3FmgudzkIm/Eda/p3RrgoCvD+BwZOQaKQJq PJA1mpUh/GO9E9+YNa6MpqOQY8BA5Fkh4LDWGYY6yyVrt+dDigjttmXnar/wNNa5JPZmxbuOxhK 6fUb5J6Sk5T0N+qCSEEXyNLPw36Maqg4l/MbXqAPUlQI3pJD3DkHxz+c3FM1Kw9YThVJ73VffMC uhlUbQYBvQWUMcJhYqpjQWhvVTuqg0RbrQ4JaOyPaUlQdXIQVqMcZhyT/wHh6mwy/7ecFzvJ3Jm 5UfhjVEWIzeOw= X-Google-Smtp-Source: AGHT+IFuGObiLaYcEpCLsdnPWy/fW1azgSOUQs/3/+r6mlDFstD9ErqMY1MnRi+0ZMkkAUAoABOzjg== X-Received: by 2002:a17:906:f598:b0:b79:cf10:a17c with SMTP id a640c23a62f3a-b8036f2d2e9mr4343539166b.10.1767474970707; Sat, 03 Jan 2026 13:16:10 -0800 (PST) Received: from vps.markoturk.info ([109.60.4.132]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037a60569sm5170024166b.4.2026.01.03.13.16.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Jan 2026 13:16:10 -0800 (PST) Date: Sat, 3 Jan 2026 22:16:08 +0100 From: Marko Turk To: Dirk Behme Cc: Danilo Krummrich , dirk.behme@de.bosch.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org Subject: Re: [PATCH 2/2] rust: pci: fix typo in Bar struct's comment Message-ID: References: <20260103143119.96095-1-mt@markoturk.info> <20260103143119.96095-2-mt@markoturk.info> <84cc5699-f9ab-42b3-a1ea-15bf9bd80d19@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <84cc5699-f9ab-42b3-a1ea-15bf9bd80d19@gmail.com> On Sat, Jan 03, 2026 at 04:38:36PM +0100, Dirk Behme wrote: > On 03.01.26 16:24, Danilo Krummrich wrote: > > On Sat Jan 3, 2026 at 3:31 PM CET, Marko Turk wrote: > >> inststance -> instance > > > > It's trivial in this case, but we usually write at least something along the > > lines of "Fix a typo in the doc-comment of the Bar structure: 'inststance -> > > instance'." > > > > Please also add a corresponding Fixes: tag. > > While looking at this some days ago as well I came up with > > Fixes: 3c2e31d717ac ("rust: pci: move I/O infrastructure to separate > file") > > But that just moves the pre-existing typo from rust/kernel/pci.rs to > rust/kernel/pci/io.rs. So I'm unsure if that move-only commit should > be mentioned in Fixes:? Or if we should go back more to search for the > commit introducing this typo? The typo was introduced in the original commit where pci::Bar was added: Fixes: bf9651f84b4e ("rust: pci: implement I/O mappable `pci::Bar`") Should I use that for the Fixes: tag? > > Best regards > > Dirk > > Btw: While we are at this file, do we want to add an 'is' in line 57 > as well? > > // `pdev` valid by the invariants of `Device`. => ... is valid ... > Should I do that in the same commit? Marko > > >> Signed-off-by: Marko Turk > >> --- > >> rust/kernel/pci/io.rs | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/rust/kernel/pci/io.rs b/rust/kernel/pci/io.rs > >> index 0d55c3139b6f..fba746c4dc5d 100644 > >> --- a/rust/kernel/pci/io.rs > >> +++ b/rust/kernel/pci/io.rs > >> @@ -20,7 +20,7 @@ > >> /// > >> /// # Invariants > >> /// > >> -/// `Bar` always holds an `IoRaw` inststance that holds a valid pointer to the start of the I/O > >> +/// `Bar` always holds an `IoRaw` instance that holds a valid pointer to the start of the I/O > >> /// memory mapped PCI BAR and its size. > >> pub struct Bar { > >> pdev: ARef, > >> -- > >> 2.51.0 > > > > >