From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C70343635F for ; Tue, 20 Jan 2026 13:59:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768917578; cv=none; b=r7q0OgUnJlaNj8srGcMT2qeGMTba/2/yW+kWD/ZSU/WnJU4CLOGDpf2xpdvoYP6Vgmd2fTVbeqRDEzEwdtfNZUS0mRTM59UuxiUMI9Lll7T5byhDVY+w+USHJSiTzOTsvI36f2nSCd5yTGYTU87O2r+9r9AkvWAQdZxpjtI1mA0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768917578; c=relaxed/simple; bh=kMOXrt1aNrTcuiwTjrx+c/MbKRiuWZpNMYgeNISc9uo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JFkt9dL/KCeFV6+M/6bZpS1NUr+QYorIQzR7rHUdcNSa9krL8XdbIisoL+kTone8y2VI4cfJm0wSVKRk4mzp+jzYzFebsR2YKrdq5dNDbu4rWhsPGc3Nk56ANN9w7yMqmZc3DRqv4vkB+ke4nBOreaXdKrpZJguOaJFhl89vQOo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HAEO8JSI; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HAEO8JSI" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-432755545fcso3102193f8f.1 for ; Tue, 20 Jan 2026 05:59:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768917573; x=1769522373; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=noODPEebgKaeGyXbSdyM6vmBeIf9OQCmhewSNkdpqzE=; b=HAEO8JSIj7+3RKHlr2Q7RYLCEtuaafIclhWue/wei4g7+AoKFOwOEVqZIKj7MU3YTu yR5nIWBbj5jsICmxuzcBM5THlzJhjwUyvAm1i+Q+DWYyQg2Zd5sgwNwmiR6JsuATYPVU tCkeuNtBDb5quL1pv+pNCjwhcL33E2+aM4xYhENFH2r9qw8wnezdwv3syCwckBR6JKLQ v+rroWh8WRor9ALNmGQ+VIkdsOyut4SHkLduer0v/skzNB5oxtrKr7T4tuNbiaQinkBn qO6uUMMPTDyq6ITh2FJhDdd0puAKJ6F9gbdMKYMmK75joLCVnsRDihrvhOi1gDVG+6s/ sVQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768917573; x=1769522373; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=noODPEebgKaeGyXbSdyM6vmBeIf9OQCmhewSNkdpqzE=; b=gl+mpu2skkrbriaRLP11fJL6jnGxqrAzObGjx0Evxn1KcZGYTFCKgiuDlz80Yr4pEE 9TOYKv3OWyFK/g7OJiquqgss1+8oBlfsP/EYU6JbMdsH6+G6jsQa8hab5u6PwlILG3g/ Yepx8P3fZjHjg9FS3XF4lechVRQiZs18rFD2sHm4e5Ys8XL8i57FJs+813E/3qOkG3p8 vqs7DIx99BuG8D4zyyQ9LwpAD7Y5Hcqg4H4OgSFaiJNzp1+28Vqr/j+J2fX3Vt17pqR9 dFU2HI/U7kmFGow1jm4Fi6UCaKeV91+R3yPOgMr39gfRgu9IM//Ge1FxLSOxRl/c7KuJ Y89A== X-Forwarded-Encrypted: i=1; AJvYcCWOCj+t51NoXjTp2GBukxqLhJSs5xrcepIwteNHtarAVyJ8+QMqgJqe/DNWpUg1bVcAaGoMePImQGJMVP0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy97t0ZZS6Vt6QvzMqgBONClcTQshfOccrl9NXxz+y+zUoEzvat 2FMYCIuTdRuv6therRuZJWXulLXcC+4MlU0RA+n+032UHFL184UNrFM2bhU9nMKJd5g= X-Gm-Gg: AZuq6aIxeRw8omfbwzGtSmTnyA9UUaO7VPy52v4EI6ioDGohbpXwZ7tRPMomE7uFMBO B98rZjcmM2rbdh0no0YFA71eCe8mE81HnZv1Gv5/SgKybe9y2k/hEvmf5i5qBwb53KxxHKkNybO CYeOjPXRaIeZsNCnumxTbcpPkzjA9tlS/S4wihscXdXi53COauTqjrSrVpExhC7RBpBwfKGex1y /JUqESpwfJqT7LinV0mHiiB/vv+57ms1RKVnDLqNAZ3rqtJH4da2ohZgVFpinM6lkvzsoXTbnhe B11sCpwE+z9xltX64BwBF20fs6K+ttqZ3H3qEqlA9X1tjXwlwhl4DmfIkDbqWwD//vgovMshlTl nOKAV2WQHu0CvO0n/ZiNQPs6KPffec6U/8rBnGco1zx44t/WbovSnYEEFX6+5kjar+o1N4xzyR5 ycm6t5sIoImrBVdVh5 X-Received: by 2002:a05:6000:4021:b0:432:851d:3676 with SMTP id ffacd0b85a97d-43569bd29demr18655393f8f.57.1768917573353; Tue, 20 Jan 2026 05:59:33 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4356996dadbsm29470787f8f.21.2026.01.20.05.59.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 05:59:32 -0800 (PST) Date: Tue, 20 Jan 2026 16:59:29 +0300 From: Dan Carpenter To: Minu Jin Cc: gregkh@linuxfoundation.org, andriy.shevchenko@linux.intel.com, abrahamadekunle50@gmail.com, milospuric856@gmail.com, zxcv2569763104@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: rtl8723bs: fix unchecked return value of skb_copy_bits Message-ID: References: <20260120132241.2119454-1-s9430939@naver.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260120132241.2119454-1-s9430939@naver.com> On Tue, Jan 20, 2026 at 10:22:41PM +0900, Minu Jin wrote: > diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c > index 21690857fd62..135bc5432be6 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c > +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c > @@ -603,11 +603,13 @@ static void set_qos(struct pkt_file *ppktfile, struct pkt_attrib *pattrib) > s32 UserPriority = 0; > > _rtw_open_pktfile(ppktfile->pkt, ppktfile); > - _rtw_pktfile_read(ppktfile, (unsigned char *)ðerhdr, ETH_HLEN); > + if (_rtw_pktfile_read(ppktfile, (unsigned char *)ðerhdr, ETH_HLEN) < 0) > + return; Eventually we'll want to return an error code here too. Make it easy on our future selves and do it this way: ret = _rtw_pktfile_read(ppktfile, (unsigned char *)ðerhdr, ETH_HLEN); if (ret < 0) return; > > /* get UserPriority from IP hdr */ > if (pattrib->ether_type == 0x0800) { > - _rtw_pktfile_read(ppktfile, (u8 *)&ip_hdr, sizeof(ip_hdr)); > + if (_rtw_pktfile_read(ppktfile, (u8 *)&ip_hdr, sizeof(ip_hdr)) < 0) > + return; > UserPriority = ip_hdr.tos >> 5; > } > pattrib->priority = UserPriority; > @@ -627,8 +629,12 @@ static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct p > struct qos_priv *pqospriv = &pmlmepriv->qospriv; > signed int res = _SUCCESS; > > + signed int ret; Don't put a blank line in the middle of the declaration block. Just do "int ret;". Everyone knows "int" is signed. Don't follow the local style when the local style is wrong. Also only use s32 when it's part of a networking or hardware spec. Just use int. Do people imagine that we'll change int to be unsigned? Same comments everywhere. > + > _rtw_open_pktfile(pkt, &pktfile); > - _rtw_pktfile_read(&pktfile, (u8 *)ðerhdr, ETH_HLEN); > + ret = _rtw_pktfile_read(&pktfile, (u8 *)ðerhdr, ETH_HLEN); > + if (ret < 0) > + return ret; > > pattrib->ether_type = ntohs(etherhdr.h_proto); > [ snip ] > extern void rtw_os_pkt_complete(struct adapter *padapter, struct sk_buff *pkt); > diff --git a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c > index 944b9c724b32..5b9b959e23ca 100644 > --- a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c > +++ b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c > @@ -21,15 +21,19 @@ void _rtw_open_pktfile(struct sk_buff *pktptr, struct pkt_file *pfile) > pfile->cur_buffer = pfile->buf_start; > } > > -uint _rtw_pktfile_read(struct pkt_file *pfile, u8 *rmem, uint rlen) > +int _rtw_pktfile_read(struct pkt_file *pfile, u8 *rmem, uint rlen) > { > - uint len = 0; > + int ret; > + int len = 0; No need to change the type of len any more. regards, dan carpenter