From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E160843E49F for ; Tue, 20 Jan 2026 14:28:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768919320; cv=none; b=cRJ+Se96HUqAJgQyLAQF7YSp/3UWtnj8MOuQfZ6CELVBGY3ttm/VKcWCSjlI0xfMpJxyfcCWglNV5nFRPVCCW/w9xVbN2JZSubnWW/k5jgnXvTtCMBoGceM1xw8/v7mD4kUKjh1w29TSpN02UyZk4zlIrAbVE8OrcA+8MOrB8K4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768919320; c=relaxed/simple; bh=eXrO/+Lv9kcvXNS0yQHUCRs4IxpxjZmLMXpmTR3PiCc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AWZOIRqV2AkoVgNq/rueQ3+fXtOfwXGutG4KdzveHWIY8z9W8+o0gNSSpWLuZagLgjLtlhx2QfrvQGDITyFmCi/VXGgI7PBgF91gmYAi9Epn8S+uOD1slhfyNUKeYHXxtNO132N1j/oFPzVqJ328WkTiZAAPNo05DyoNXbln994= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rcMrg4Cs; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rcMrg4Cs" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-42fbbc3df8fso2999095f8f.2 for ; Tue, 20 Jan 2026 06:28:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768919317; x=1769524117; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=r69MkI6qi4cfDqEweV3mhgjODj8YEt6I3Ihd8bK8bz0=; b=rcMrg4CsSAvMqcGcZEj5kH/JSykCZ0rqJGrW/XFsqFOBbU5ao9VgfbmD8tX7W2cdwO xA76PnJN34Jm98QMe6aQ7O8jFe6eh5OyIpEVSE1AhPbUkmq50eg16d8w0lqVCjfiIhJC O+xwSEJ3JcBZIThYHUZvsliVqGkca0WkydehKW9uOBr4u3/DQUxvVu0NZqhcm7lnPiPm M8dJOjw3aregO5OpxmpCNYSzg5NlhoTxHW2ShD/aNnIKLfVGJiRLcfBkqX54ZPZsjFOg 11zbfE5G9wpe7JBEPod7R+Vg3k377V0by7aRPEfBfd9jsbP5HQd8xwIiODNxCqKzsMBj zBqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768919317; x=1769524117; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r69MkI6qi4cfDqEweV3mhgjODj8YEt6I3Ihd8bK8bz0=; b=acrgR+bN4x1SZ2OULFDBsXaeS3UEqvVurI5ol4Hu0f2WMMjQZVcYcxPZRoYzbrIvUF G8LbEPUfDQj55RWDJl5kWJkitMbMxmEdyPG+iIMvCZ9jWdu85159avO7Ety7EaoTOTvh nTEdRumIkUjiHBW7cB2nfCWul+3fqHl0VJLOTUIg8UdPxU9OyyrkhHZBumt5bLBq+IB1 mXI0yj1RJDfWwZXKV32ogtNhJIVrBqdq++JGAOtn0VjcYr2jdUGlEv67bjoQEXbER0gO fMkjGHXm75nQjTKXNYxx1uCInqxLSKXXUXUUMnAj4Eqs9fqK18ryhslTlLUOIWUK3KVZ Le+g== X-Forwarded-Encrypted: i=1; AJvYcCXSBqJnToOPw00CKXRLwl6uSVxeliDh35LVg7slTcDw3Ay0LcpAUuQ5WM6FkBfA6vKCF2maAfs8eGdIQt0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8T0jc2m8X71sTsxs2xrg/YShY3R6JrO3N0YLzdaK9FaAPa7Sv GT3B5ewtMt3rLZgpvnZxbtwR5QIKO8ztlr7tpRqMg+8n0I1OTcjzJPVpbG9tsuRDLdM= X-Gm-Gg: AZuq6aJloc9bNcZ1ESAOkpZXW36sNyNMzYVBVWG9XZYhP1N9PDx5RbHmqBrj+5A6dUo xg5Ohkxqy9yXH93aPoZ3we7zw836BVpJhWGRCMxhBBC3kEF9/JWPOtbjsRFiarttJHvuHIGVHxp bZ9FmDkNBMFzp6PODrGaVwCYujcl7KrWE84cqV+0o1HUFRBHoR89lEZZapeCdJJY6Qd2v7j1G60 Uxuxr1vEXsPvZTVUz44kDB8BAgrHeyqYDwUT5J5j4EqYc8xAMItQWeYw3cOCqXgNj85l0mP7EMh 1GL+I2I7tlLgwMC/gAwc+C8Yx0Z7QX/BWgordr3o8cbH+GEPUsZ/5rvZIYSOulnyZ6W0XPC4U0l /sdoiZCg6we5mtEar01+TiJTqWRo0b7oEhe+7u+YkcgxZ5ZyeRvKzZhKnZpvh3NytLhYO5xteMm ttYjlTmtDDyTXZgHHx X-Received: by 2002:a05:6000:2284:b0:433:380e:cd84 with SMTP id ffacd0b85a97d-4358ff44142mr3201035f8f.14.1768919316896; Tue, 20 Jan 2026 06:28:36 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4356997eb2asm29968072f8f.37.2026.01.20.06.28.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 06:28:36 -0800 (PST) Date: Tue, 20 Jan 2026 17:28:33 +0300 From: Dan Carpenter To: Andy Shevchenko Cc: Minu Jin , gregkh@linuxfoundation.org, abrahamadekunle50@gmail.com, milospuric856@gmail.com, zxcv2569763104@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: rtl8723bs: fix unchecked return value of skb_copy_bits Message-ID: References: <20260120132241.2119454-1-s9430939@naver.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jan 20, 2026 at 04:03:37PM +0200, Andy Shevchenko wrote: > On Tue, Jan 20, 2026 at 04:59:29PM +0300, Dan Carpenter wrote: > > On Tue, Jan 20, 2026 at 10:22:41PM +0900, Minu Jin wrote: > > ... > > > > + signed int ret; > > > > Don't put a blank line in the middle of the declaration block. Just do > > "int ret;". Everyone knows "int" is signed. Don't follow the local > > style when the local style is wrong. Also only use s32 when it's part > > of a networking or hardware spec. Just use int. Do people imagine that > > we'll change int to be unsigned? > > Not in a far past we changed char to be unsigned :-) > > *Yes I know that it's a bit different case. Heh. char was always unsigned on s390 and the s390 devs were really militant about avoiding declaring variables as "unsigned char" so they'd write all their arch/s390/ code to look like: if (char_variable == 255) { I guess they were annoyed at the rest of the world who declared their variables as "char" when it should have been "signed char". They stuck to their guns and defeated the rest of us in the end. It's some kind of life lesson or potentially a message of hope? :P regards, dan carpenter