From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 665EA2FFF98 for ; Sun, 18 Jan 2026 19:24:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768764271; cv=none; b=ipYzqVbasy85iC7tPBj3U/uwpWxuksllVSGoZKez6kWfuHDVBNQHoByubSHtt3LASyHHMhyfPmGopayQzT5YEUyTZt/nMeYOiSXHJyoQreDe+25WXpiWeeelsrS7U2OpirGQYCQlkx3epi2/i/m5OJo+DX9iV+Biv3j59KGSFks= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768764271; c=relaxed/simple; bh=NWrUWrvfvd2ogjHDu6/2DfPqsK5vwvdB01FnIvfl6+M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oqa4Nu8IMLTqmHgKi8sm+zW6J6SrR0LsGOu00lK0gPtTuLTn2BMr8H6RWW6MqMezKfADNastfpB+hLq8dMR8XGEdC7JEoEyj33xlvIkTlI6GCtBTTvcoIIqFJ0r/rCWFFvZo7nEEya4qUlxgI4oHBqv/eN9cX0kILaJuUKQnhP4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ZMa4TIQu; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZMa4TIQu" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-47ee0291921so23265945e9.3 for ; Sun, 18 Jan 2026 11:24:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768764267; x=1769369067; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Ra6SLH/t+rEiT8DP+rFlCv2teRjrvmsLJoORLmMg1xs=; b=ZMa4TIQuJIGqyAxzxdeXHqNXsggt7MKTCZka018lMznNSxA/8nBKccjGHlP4UwMwGE DGEur9vkOKjjfoP04Un6p+dj5c1NGlkjvbrGH6fkyV6tURxfO9ME8y2o50gdMqodCMKl NuVoI8LGq5lPZxZB9rhjnEIncDn7qC+1EaUC2Ds/TWfjSTN5Fk6aFVgCdIxKD7BSwaQU k+SECmHLJji3CrcJKMmw0wG5JmnrO195PxVP4TKbku0VTfjIO0Dk6MawyLt6fw002S3J FgcuGgH5Pc3ci9th9dAmknRQOpM2gaR5slixbg3BQOJvStAAoL5DjELltI8O7sZjiLBF MDRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768764267; x=1769369067; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ra6SLH/t+rEiT8DP+rFlCv2teRjrvmsLJoORLmMg1xs=; b=itgb/ITkEaERRi7u3EgI50+dEQJjkQCfEKum3WaKLJIyllyt5hnMBd3b4VRDLxBWfu w2b/j0udHoBu7aR6xrZw2qrloASUk1wY//a1Epqk+JqkH5Z2c8ISyXkeGLjdMywGy09S aziJTXxMOFOh28NlPZlFJUWD3ovEpqqUo5bokJFM0Iiibd8WUZEKrZNtvVjDvMpVNbRB i0tcsazb0RClw53+opj+9qxKUWzEWxpTJvQaqOXlIhbcL65vtk2UHn1mGaDDYA/snYHQ MwBKamBrfAE7uBbP9isO5yavdc63YBdisdgzu8hjteVtHGsWxbfr573MPsSAcy3pmw/A pVmA== X-Forwarded-Encrypted: i=1; AJvYcCW1jtXS/7ho5a8Z5by9gN26LFHcLDtN7FjCEwjhz7HrF0HhLeGkDRSvlE/vhOdVg5u/4wpUAViSXbkDObU=@vger.kernel.org X-Gm-Message-State: AOJu0YwfLgI+rQqz3G9Q5UgG1S+V4hvgT9uuoTIJv7AAjFON1RzNrFq9 Sp/CNzzdjS4RnmqU47JkSipSnLWxz0ZIJH3ny/P412EGmTR9swWcSO6BQ4nBSY1O2KriaS67/0D pn+G3 X-Gm-Gg: AY/fxX4np7H0ov6TsEI9OJdWQGYbcPbY0evg2M9GFJcq+W3pca4nqPBmaZhm7juWum5 0L55eFJmpfpFwFcjGGSMo5gjQDyJ4Iv8I8sqoXHxBF7Bx13GmGhR4RYjU1ISDDJhzAeZu/muSZy SOkRu7C7OJveQ7Qh1wqPbqfgSE+KAfTfTiJvS834ybmX6BaG8rIFx/R1HTLiPUvx6Ic6dSGNgQ1 Y0JrjCq1N3kYP43vtFmK4WToWmcNNwjNpekmN4JkL4fhcd6Vvo3U3y1rlcXXdNXy+C4qf294BfX VYg+zOot9vEKKDcy3TmiLJ3/2LCgAik5zG5ADy8yK+F0AybiVVWptVp+CvRA627WCLi82qV83Ii 2UvPw873UimgIXN7Vw7miSPXums1Sn/8rHlV6cCUEHBGctb9kKE7EDF2esJLYYajm98EeRK9YTK E93bKrEdCbF6kBaona X-Received: by 2002:a05:600c:6206:b0:477:8b77:155f with SMTP id 5b1f17b1804b1-4801eab5255mr121890255e9.8.1768764267173; Sun, 18 Jan 2026 11:24:27 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4356996cefdsm18021683f8f.24.2026.01.18.11.24.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 11:24:26 -0800 (PST) Date: Sun, 18 Jan 2026 22:24:24 +0300 From: Dan Carpenter To: shinsj4653@gmail.com Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, nadzya.info@gmail.com Subject: Re: [PATCH] staging: vme_user: fix missing blank line after declarations Message-ID: References: <20260118161954.80672-1-shinsj4653@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260118161954.80672-1-shinsj4653@gmail.com> On Sun, Jan 18, 2026 at 11:19:54AM -0500, shinsj4653@gmail.com wrote: > From: shinsj4653 > > This patch fixes a coding style issue reported by checkpatch.pl: > "WARNING: Missing a blank line after declarations" > > A blank line is added to separate the variable declaration from > the code logic, improving readability. > > Signed-off-by: shinsj4653 Use a real name, please. > --- > drivers/staging/vme_user/vme_fake.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c > index 731fbba17dfd..55c00e1d162d 100644 > --- a/drivers/staging/vme_user/vme_fake.c > +++ b/drivers/staging/vme_user/vme_fake.c > @@ -67,6 +67,7 @@ struct fake_driver { > unsigned long long lm_base; > u32 lm_aspace; > u32 lm_cycle; > + This is a bug in checkpatch.pl. Try to fix checkpatch instead or otherwise just ignore it when checkpatch is wrong. The rules is that when there is a declaration block at the start of a function then there is a blank line between the declarations and the code. Here, we're not inside a function so something went wrong. regards, dan carpenter