From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f52.google.com (mail-dl1-f52.google.com [74.125.82.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2AA07A13A for ; Mon, 19 Jan 2026 02:49:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768790975; cv=none; b=FN7iGmpbtsQ/gsqTD/d5Y5P++/dz1z3vUywropdKFN3BOuG5sFZ4DVzvLte0QsIudQ+1wqGb2+gN0DS3meLMOCkT5gKxj7KekYHZM2m4AkGxWXBfq/CnraWLbKzK8YriYIli0hxYSK8/TxphHulB0Rxzwwi7GVLv6D3/BsgIKAE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768790975; c=relaxed/simple; bh=7ieh8bpu/47zcDqVpa34kh7zmCuxOI0aSkL/DkYVjeo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bhdXCED8FY3Q+8Zq4BJKc7yi3qc5l6ivnJQgh6EaO7qk258kaCk8qv/w4p1mCvPa9O1fLrLuSX5vh9tArlVTo7Xpjrjl+ENKxeGWjS7fRUIpnyisxHkrf7l5rZGFTwXKU5LMx+oowuK6bD2+6KAi25MdaPSRzePM3wcnvtc7wqY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mz+RmSml; arc=none smtp.client-ip=74.125.82.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mz+RmSml" Received: by mail-dl1-f52.google.com with SMTP id a92af1059eb24-12332910300so4637895c88.0 for ; Sun, 18 Jan 2026 18:49:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768790973; x=1769395773; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:from:to:cc:subject:date :message-id:reply-to; bh=fakORZHhU3LeknzGhGkh3JKvyYcqGqj2ajx5hHN4E8Q=; b=mz+RmSmlUqSAc/X9b50Uz8XpmSV3KHKyy4UiVVwM/4ROFW45kA8BQ3BJ7brSlmkRck tf41+it/G9B7satU4BVvL7s4rq/XSVCZXS3mRqtDPWAjhwN17WT85T+msaMVfrW28daB aPYw8+LLriF8c5vBxwODuY1QTO60tr5TmeDrS5bZGEjYcfeoTW24Whebci9KfFR+y1B6 XbjWZV/ZCHxAu/qSWAaLHEdqovAzrxH+XPcynKiNgP/G9pmewmdxNx73t9ckbB/Hy13e nG3zj1j2oAV1gU8+ZxfDcxZMiT7SMOqGaW9UHgCWrLHDzBr+oljK825K7CaQqwQe4GZ8 E04A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768790973; x=1769395773; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fakORZHhU3LeknzGhGkh3JKvyYcqGqj2ajx5hHN4E8Q=; b=iaEJpFJanWPbt9O+MYSPsp636bIqx4ZvtaYFOZGONAY5qcSGlz6P+BgA33lls4qN8G DuXb85gxnu2fTaaTYLJQMJQXL9JXul7T5SqOuXQaKGNpwLZJflKc3tEpuI0x8NNyNFHA gT0BwxqgrgaaBzGIN4YAJ4OXAVXCAm7YixhK6rOAOQ1/+8LG79fN1aTeLNjh8pBVlFSa H+4j2Efsc6jEUny8G4iaXndBD1BdHUgbICf8sTU8oGy3gzRtM+euZtzY6BBMf7JwE52E AJpQh1UErzedtk89XqdaSXL8PuoaJV8Ie5C7CA4dX3uLzzt/IdChNAgjJCqswqV3rkRb F2EA== X-Forwarded-Encrypted: i=1; AJvYcCUDfvg6Z0tiQ67f9I84f07qhFmjBPJ1ANx6n+89uJejq2angBtZUB0dUgHYpAA+YTvMp2pdrGR8ZHpBwU8=@vger.kernel.org X-Gm-Message-State: AOJu0YzH5a4AQpmBZ4Qg+7AWb/bQX38wXFcPanHP9Bi2HG/I4H7edf87 fpduU/iFMDpEHPz47W423mCM5Vbrzgd/SkrQf1dWGHg+/cP36i9ZVUAO X-Gm-Gg: AY/fxX60Q39AsGNL4M7nEmMkTU2ZcopA/kQyoimNUZIzPwdwQhlCp6EOd44h6xQmspP 9XU/5zWM7XiGbTGfeAJFwLW7hYvoyDW1R/mGfnBopI8EgfhvR/pK9tsl0hsp0LuGpuWujEau0MS 1nYGPTwnXEd7kXpqbtjP7616BvrMuCHvXs0SJq/sCP7gqLWXhyB8QXlefcf7SxN25kIwbILgJkA JU4kTQAnwik+9S3LYEA9nwoHHGSyaytgRgistLo2KM5JbtAvvg944s01eMQ7TLzEQTUeNEblrko jB58mMok4ATJjGPbOHl0XYJKYT5PqyWoKsIMjEj7R7nsT1Nzvbm5AQo4diYnioknp6YD15+oodh yae2G3kaWzd6qt4rhA+ITQKMHZlsduJpej+4jgw1wB/yZprLccugJpjT0T4U084s3zuecEiJx60 +Sdur9ce9rsIkSY9ZW2M+MMYx9XmrZxYDzMdxccWv3tOQB/2sIDgDuJATdivoEO6ZHh+DPxU1vY 9fq8rkHql3KtHw= X-Received: by 2002:a05:620a:45ab:b0:8c3:87eb:f with SMTP id af79cd13be357-8c6a676dd5amr1306466485a.53.1768784635960; Sun, 18 Jan 2026 17:03:55 -0800 (PST) Received: from fauth-a1-smtp.messagingengine.com (fauth-a1-smtp.messagingengine.com. [103.168.172.200]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c6a72985a8sm693681085a.54.2026.01.18.17.03.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 17:03:55 -0800 (PST) Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfauth.phl.internal (Postfix) with ESMTP id D45BCF40071; Sun, 18 Jan 2026 20:03:54 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Sun, 18 Jan 2026 20:03:54 -0500 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddufeeivddtucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepuehoqhhunhcu hfgvnhhguceosghoqhhunhdrfhgvnhhgsehgmhgrihhlrdgtohhmqeenucggtffrrghtth gvrhhnpeehudfgudffffetuedtvdehueevledvhfelleeivedtgeeuhfegueevieduffei vdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegsoh hquhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdeiledvgeehtdeigedq udejjeekheehhedvqdgsohhquhhnrdhfvghngheppehgmhgrihhlrdgtohhmsehfihigmh gvrdhnrghmvgdpnhgspghrtghpthhtohepvdejpdhmohguvgepshhmthhpohhuthdprhgt phhtthhopeguihhrkhdrsggvhhhmvgesghhmrghilhdrtghomhdprhgtphhtthhopehruh hsthdqfhhorhdqlhhinhhugiesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthho pehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtth hopehrtghusehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtohepohhjvggurges khgvrhhnvghlrdhorhhgpdhrtghpthhtohepghgrrhihsehgrghrhihguhhordhnvghtpd hrtghpthhtohepsghjohhrnhefpghghhesphhrohhtohhnmhgrihhlrdgtohhmpdhrtghp thhtoheplhhoshhsihhnsehkvghrnhgvlhdrohhrghdprhgtphhtthhopegrrdhhihhnug gsohhrgheskhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 18 Jan 2026 20:03:54 -0500 (EST) Date: Mon, 19 Jan 2026 09:03:52 +0800 From: Boqun Feng To: Dirk Behme Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, rcu@vger.kernel.org, Miguel Ojeda , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Will Deacon , Peter Zijlstra , Mark Rutland , "Paul E. McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Uladzislau Rezki , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , FUJITA Tomonori Subject: Re: [PATCH 5/5] rust: sync: rcu: Add RCU protected pointer Message-ID: References: <20260117122243.24404-1-boqun.feng@gmail.com> <20260117122243.24404-6-boqun.feng@gmail.com> <56d1cc0e-df60-4e2b-bfa9-b29ec48a76b6@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56d1cc0e-df60-4e2b-bfa9-b29ec48a76b6@gmail.com> On Sun, Jan 18, 2026 at 09:28:35AM +0100, Dirk Behme wrote: [...] > > + /// ``` > > + pub fn dereference<'rcu>(&self, _rcu_guard: &'rcu Guard) -> Option> { > > + // Ordering: Address dependency pairs with the `store(Release)` in copy_update(). > > + let ptr = self.as_atomic().load(Relaxed); > > + > > + if !ptr.is_null() { > > + // SAFETY: > > > Would it be an option to take an early return here and with this drop > one indentation level of the larger `SAFETY` comment? > > if ptr.is_null() { > return None; > } > > // SAFETY: > ... > Some(unsafe { P::borrow(ptr) }) > > Same for `Drop for Rcu

` below. > > Make sense. > > + // - Since `ptr` is not null, so it has to be a return value of `P::into_foreign()`. > > + // - The returned `Borrowed<'rcu>` cannot outlive the RCU Guar, this guarantees the > > Guar -> Guard > Fixed! Thank you! Regards, Boqun