From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC234350280 for ; Mon, 19 Jan 2026 08:56:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768812962; cv=none; b=MIBt5RgRmJL0/5LN7QhkDTayk6K3pm7/ELH4jlJf2EoyGZ8jm/HyQA1BhiyHepG900vFFCmRsmkg2d4oKdXABEx9i/foW4uMrNU898myesUEx1GsO6qaMd3YG8VNA2YHpW0aIDBr0giJ906vqkusg6o5DIluSwLWJruezTJknAI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768812962; c=relaxed/simple; bh=yuzk4HCkmCLSzrI3p4aqbiLdRuxIs3CtoWGhU33hNLo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=n6sNhi0NiMh+zg789ShRawyR9K6EHpsNEg8zKhiKOsJiaGCntkuwvoAYr9/glYDIlrJcFBjAz3J9JjVo0R0MjXiWVAQALSeHKWFRZc86AS46PpP5o6E/l3U5V5Sc+HzTCw6qFduMCpcYqsoftJqJP9RqpoHwOIIxecyX+sGzRi0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=jREKgKp9; arc=none smtp.client-ip=209.85.221.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jREKgKp9" Received: by mail-wr1-f66.google.com with SMTP id ffacd0b85a97d-42fb0fc5aa9so2168648f8f.1 for ; Mon, 19 Jan 2026 00:56:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768812959; x=1769417759; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Ltjz/smMzvjpsohpXR7hQ21/EDxVXQBbnheqC1Ei6f0=; b=jREKgKp9y4zTiFW8cccqbZNoPIVQvJhR25Pszp4fDzBSkaMiB21jnwH7P9FiTGyWNm bZ46rld7gHxo/V2TZoHi7UEY6PnLLNY1WcjF+UIQco6zCr2XiD9kzyUfidq26isC6C5k SL9yP4KtbHkUSqsl4Yxu/W9CzoAWE7IbyoV6GZN4F6S6TJ0WOkYBUYBNvyqE1WyjIH7f orIrq7B5apQjM4eNVW232WP6uQZkF09H64VSwSf2J9GRFYCHDKCltXPVy4Nt337YfIt/ JurLeGEszWUkjuNhkEoP5Knol62Ok8XAmDnaZ/p7MC2YzIFB1v8GbGQ9T6qkwaQTl0NI bQmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768812959; x=1769417759; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ltjz/smMzvjpsohpXR7hQ21/EDxVXQBbnheqC1Ei6f0=; b=C1/6pOZ2T1WIFp1nqUkFQrzdh12p+r+ImvCorp+3aISkpAkF2S3lN4CfNIP+vgw8VR H8uWmgP29i8gV5miifdSdiKAvp8eHG7zmmN6r2j85fuYNrtlWgoNlgENHHpc+xm4IYWi z6Pd0FW/C34evtvbGUe5aI995o/xkc2RwFJPBo+6hPhg1YxtkagTfNQkJapzJ4LR0Lgk H1STOrCUIZcsLBcX9aTLYlixHzLViaZyP6ItkQU945YCIHvofrFfb6+RMwGri/ZsJJea 3FHXJq+eSJHBnhh8MFIRrJjWhET4k/U79oJkm2MoZED3aPac0FJFiS3nt4xs39jDp8Pt 014g== X-Forwarded-Encrypted: i=1; AJvYcCWSrrChxb84kY1UYOSY5u+XQFDgW8Gl6rxOvP6xmRAJ9WsqOGumX8CV+pTKXqrkDam4aVFOGfHGNTrmF4Y=@vger.kernel.org X-Gm-Message-State: AOJu0YzyvdOPNzxhzbuWxk3AtMOOxa21HvA7BINywirw3Io1UUB1M9sT i5FDwSBAjAh3VhS0DRPqg9IlIFQHEiokDNbbrTw5VsKXy4xpnM3eYswLTp8T8Sb9qNE= X-Gm-Gg: AZuq6aIEAzlvTzUxvMxAzGVJUeA3fAiEUbaI51rjgqkM4F9N0wWlivPgYqWO73QaWYZ p/a6OJi/DPxxPgnG3weHEri4NmwF+MPTvnf+M93lh2elW9MZHMBxE1KEAX/qzT8TcO5OPhl0Qid UQM7y3LhElqk1E4wm0B4o27MkfLN6iPB3VqdaLjYuv3RPqfA9REQ4hSpW0MjoQfg4DA58GO08hz K9S4080pIRhBcBhNk0ch2ZhBEhBza1SjdnXlblnVOKISlwy1oyIrbbOElIywmiS45MwmIm9Og8b 3VsyeepzP8D6BlGO76jgAcUMuWiOGYs9qmU/9z9qNUJamA/xWqxyeufgXGoYycnoKK69eOCqzQt zHreS+bZlNfwy7dRxdXqkeyIcigvURuvZSSf8QhfVSiX9I3fO/CxZOC4uSLyG//S1CUC1PuEjV6 4zS6Qwh1+D2VctiS8o X-Received: by 2002:a05:6000:2505:b0:42f:f627:3aa7 with SMTP id ffacd0b85a97d-4356a0298d8mr13122462f8f.16.1768812959229; Mon, 19 Jan 2026 00:55:59 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4356996e2d8sm21807525f8f.28.2026.01.19.00.55.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 00:55:58 -0800 (PST) Date: Mon, 19 Jan 2026 11:55:55 +0300 From: Dan Carpenter To: Antony Antony Cc: oe-kbuild@lists.linux.dev, Antony Antony , Steffen Klassert , Herbert Xu , netdev@vger.kernel.org, lkp@intel.com, oe-kbuild-all@lists.linux.dev, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chiachang Wang , Yan Yan , devel@linux-ipsec.org, Simon Horman , Paul Moore , Stephen Smalley , Ondrej Mosnacek , linux-kernel@vger.kernel.org, selinux@vger.kernel.org Subject: Re: [devel-ipsec] Re: [PATCH ipsec-next v2 4/4] xfrm: add XFRM_MSG_MIGRATE_STATE for single SA migration Message-ID: References: <951cb30ac3866c6075bc7359d0997dbffc3ce6da.1768679141.git.antony.antony@secunet.com> <202601190605.ZVkgcUYl-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jan 19, 2026 at 09:21:51AM +0100, Antony Antony wrote: > Hi Dan, > > On Mon, Jan 19, 2026 at 08:27:25AM +0300, Dan Carpenter via Devel wrote: > > Hi Antony, > > > > kernel test robot noticed the following build warnings: > > > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > url: https://github.com/intel-lab-lkp/linux/commits/Antony-Antony/xfrm-remove-redundant-assignments/20260118-041031 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next.git master > > patch link: https://lore.kernel.org/r/951cb30ac3866c6075bc7359d0997dbffc3ce6da.1768679141.git.antony.antony%40secunet.com > > patch subject: [PATCH ipsec-next v2 4/4] xfrm: add XFRM_MSG_MIGRATE_STATE for single SA migration > > config: hexagon-randconfig-r072-20260118 (https://download.01.org/0day-ci/archive/20260119/202601190605.ZVkgcUYl-lkp@intel.com/config) > > compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9b8addffa70cee5b2acc5454712d9cf78ce45710) > > smatch version: v0.5.0-8985-g2614ff1a > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Reported-by: Dan Carpenter > > | Closes: https://lore.kernel.org/r/202601190605.ZVkgcUYl-lkp@intel.com/ > > > > New smatch warnings: > > net/xfrm/xfrm_user.c:3299 xfrm_do_migrate_state() warn: missing error code? 'err' > > Looking at this more closely, xfrm_user_state_lookup() always sets *errp > when it returns NULL. > > > Old smatch warnings: > > net/xfrm/xfrm_user.c:1024 xfrm_add_sa() warn: missing error code? 'err' > > net/xfrm/xfrm_user.c:2248 xfrm_add_policy() warn: missing error code? 'err' > > net/xfrm/xfrm_user.c:3018 xfrm_add_acquire() warn: missing error code 'err' > > Also, as the "Old smatch warnings" show, this same pattern exists elsewhere > in the file, most of the calls to xfrm_user_state_lookup(). > > I'm inclined to leave it as is rather than change a pattern that's > consistent throughout the file. Does smatch follow the code doing > cross-function analysis? In this case, look into xfrm_user_state_lookup() > and further down to see that *errp is set when NULL is returned? > Ah, right. Sorry about that. Yes, of course, it shouldn't be changed. The zero day bot can't do cross function analysis because it doesn't scale for the number of trees the bot tests... regards, dan carpenter