From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28BCA326D69 for ; Mon, 19 Jan 2026 13:49:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768830563; cv=none; b=TwOoSZT6IxgpXbWOi2e2XJ67Ta0jGh8Z31isq8WKQFnKz8I172pjN+/v/FuAiNDLBtQ5Uoz78ApWl6zNT5DbPcIGYHiUplhv/EM1/3f6BvGJzpv0oMmfgvoJPr4jl5nvMDbKgawiQLntRnpo2QpGviVseMOT6aeDeMfOMbW8TMw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768830563; c=relaxed/simple; bh=e8x+r72iVxmFJFeIe9nCf/XHEhh/xvpypotOn9S0G7I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hyg5UM1qcyYLJ33AXFHV3Lmj8VtfWvZYcTmcO7ZDy8x8QMUFGHArDz3v1beS7RyDJuWuDzSUNuUxfw5n/3fhk9PiNrIcJDGACKPz3EbKXH/kcGyDdfciWOuhe7kMOjx0d/yxqYpLVSAnxz+O/D0ul1zpNLpNHGs2w4st4rxHhxg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fTz1Wh8o; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=iWPKUDHv; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fTz1Wh8o"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="iWPKUDHv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768830561; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kg+o0vitmcIZRtV2GLTlr7yAGh50ZqYP0YEtulwiR9o=; b=fTz1Wh8o6oyx1qzsIdwE1cH35NdIJ3xbcZDLj8ElePHUVRG/vtb9pngQsLrdIbBqvNECPC l7HsMsPAdtvub5E/514heKgbBc6OHuedXg5BvCHKfScXLMpX4Z/GK6DKt4AlTnFhf/sjFd SwqS9vwztJQvnOsz3tVDokO7bW+2SUA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-645-4RSmjlY3P_eBIittLmqsfw-1; Mon, 19 Jan 2026 08:49:18 -0500 X-MC-Unique: 4RSmjlY3P_eBIittLmqsfw-1 X-Mimecast-MFC-AGG-ID: 4RSmjlY3P_eBIittLmqsfw_1768830557 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-47d3c9b8c56so54382145e9.0 for ; Mon, 19 Jan 2026 05:49:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768830557; x=1769435357; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=kg+o0vitmcIZRtV2GLTlr7yAGh50ZqYP0YEtulwiR9o=; b=iWPKUDHvmuFGl0bSLBpo7Tbky4L6TCBFg4fPnMOhMwdSuY+g2namyrVaXYGHN6ASqi a1N/FjXr7ERfWA5Ddmgz+9fjyOQmeF0Jn3UDGQU7gifAMAqWd4zDto3lfrqaOGoe9Sgi jLDhajtoe1I1a5QDLFqWEhkCI5hg9ii0p4JPbpS7vZLXsF9rRPM2GP/Fsyv2drDz58XP EOA/0n02/jDfY+GkVq3HNBQACd+s6vfbQm2KoRg+hI4+FgnVFCTb6nwxttOvGKpwU3Uj NITx39PV0r+t3GXzv4TTuHT+YwLeihIxQ3S4mRUa4BPRILPPcZnuAqENbLJj7UzqeS1g hfqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768830557; x=1769435357; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kg+o0vitmcIZRtV2GLTlr7yAGh50ZqYP0YEtulwiR9o=; b=pZIYGmTYlj/ouXhV6qRVmwbRKDeAw38dUfnLMTuQMmx57tORwK7RXNP4U5kAy5Suuk Av/YrC77Vv8FMXgmzchgz/o+bqLyndNmXdOiOcYM92hJhCWLPuYSlk9+QPQiigOeRZ/Q zCdLlfcMB3r5oAFJrBRiOMS96DthxP1US080x4JuatmAqDR5EElcf7AKiisABQbUK8df ASQ9TieSVEG77PBVsbDgbejFlkQmtCP3UeT1LoLeV3JWw7zZlKGbvZlkpihVjEV5gYzh YY+JJF7GVodZaopKSnnPv/skaf6M+QNGhzlvRRLOlOeLPT0RWYqNiQ5zYO6YRVyalc1Q 9Buw== X-Forwarded-Encrypted: i=1; AJvYcCXR0/PKBddyvT2hwvAPptrJMtc0k8I8vMgh3S2ZTcefdZEK4NdMQkwRJQqVPK1Z/qet6/VLJq0I40sg4P0=@vger.kernel.org X-Gm-Message-State: AOJu0YwEya91cpcBcuXGBNwdAp0BQcSAw5CJZ1zhOPhQQ/p+3hUfiI8d oYEEUvVhfHe9am9iXzkUXNxPd8bL4P3Vp3spdlteESZvBWUjyH6UMA6KqOyTMTDvKWwm74J5XKh fFPYGXdZESDD1mMNAyPhQ1iHCDJvqzJcvVrRyyVe/6VJJ2vBQmWB997ghuARh1d3qKg== X-Gm-Gg: AY/fxX4rIiQDtZtOU5YPMKUlMffGSmiCGgdliRFJ+gLj9r/ug4ENETc/HfVPgdjTT6/ ighBTtTuEZpkiruCs7afHj5WjB0ijRKkzw+k3iVT9TTeyp8E19wH2fRh3uEDtZ9mFb8vHi30tBS LI3K9gGjomsSEaAtAER2Zj+eRHo0VGFQHhd1XkEDfP+OU7Rj4CqlrUFUOX35pUn2cm6FwwTDOnB fyJpYO+TZjdZo81gqvynMxO7ZAxCSRc8oL7e5oU+xIWWe8Bf3eoXiH/9j8I6Tiw66NdLW2JsENL iUQ/CZZ0qMFqlBDbUc5cHlMO8B+0yuJI3Oj9INkWQ1iZOeRslIqh7KAYF/b/Wzp7PW/1a06fRQJ Kz2mkABDBJJPSQZICqWuVXoFut6++Ya35GS8LkOeF X-Received: by 2002:a05:600c:3495:b0:477:639d:bca2 with SMTP id 5b1f17b1804b1-4801eaadbd9mr124010915e9.4.1768830556775; Mon, 19 Jan 2026 05:49:16 -0800 (PST) X-Received: by 2002:a05:600c:3495:b0:477:639d:bca2 with SMTP id 5b1f17b1804b1-4801eaadbd9mr124010615e9.4.1768830556400; Mon, 19 Jan 2026 05:49:16 -0800 (PST) Received: from jlelli-thinkpadt14gen4.remote.csb ([151.29.129.40]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435696fbea8sm23357679f8f.0.2026.01.19.05.49.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 05:49:15 -0800 (PST) Date: Mon, 19 Jan 2026 14:49:14 +0100 From: Juri Lelli To: Yuri Andriaccio Cc: Ingo Molnar , Peter Zijlstra , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , linux-kernel@vger.kernel.org, Luca Abeni , Yuri Andriaccio Subject: Re: [RFC PATCH v4 10/28] sched/rt: Add {alloc/free}_rt_sched_group Message-ID: References: <20251201124205.11169-1-yurand2000@gmail.com> <20251201124205.11169-11-yurand2000@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251201124205.11169-11-yurand2000@gmail.com> Hello, On 01/12/25 13:41, Yuri Andriaccio wrote: > From: luca abeni > > - Add allocation and deallocation code for rt-cgroups. > - Declare dl_server specific functions (only skeleton, but no > implementation yet), needed by the deadline servers to be called when > trying to schedule. > > Co-developed-by: Alessio Balsini > Signed-off-by: Alessio Balsini > Co-developed-by: Andrea Parri > Signed-off-by: Andrea Parri > Co-developed-by: Yuri Andriaccio > Signed-off-by: Yuri Andriaccio > Signed-off-by: luca abeni > --- ... > +static inline void __dl_se_free(struct sched_dl_entity **dl_se) > +{ > + int i; > + > + for_each_possible_cpu(i) { > + kfree(dl_se[i]); > + } > + > + kfree(dl_se); > } > > +DEFINE_FREE(dl_se_free, struct sched_dl_entity **, if (_T) __dl_se_free(_T)) > + > int alloc_rt_sched_group(struct task_group *tg, struct task_group *parent) > { > + /* Instantiate automatic cleanup in event of kalloc fail */ > + struct rt_rq **tg_rt_rq __free(rt_rq_free) = NULL; > + struct sched_dl_entity *dl_se, **tg_dl_se __free(dl_se_free) = NULL; > + struct rq *s_rq; > + int i; > + > if (!rt_group_sched_enabled()) > return 1; > > + /* Allocate all necessary resources beforehand */ > + tg_rt_rq = kcalloc(nr_cpu_ids, sizeof(struct rt_rq *), GFP_KERNEL); > + if (!tg_rt_rq) > + return 0; > + > + tg_dl_se = kcalloc(nr_cpu_ids, > + sizeof(struct sched_dl_entity *), GFP_KERNEL); > + if (!tg_dl_se) > + return 0; > + > + for_each_possible_cpu(i) { > + s_rq = kzalloc_node(sizeof(struct rq), > + GFP_KERNEL, cpu_to_node(i)); > + if (!s_rq) > + return 0; > + > + dl_se = kzalloc_node(sizeof(struct sched_dl_entity), > + GFP_KERNEL, cpu_to_node(i)); > + if (!dl_se) { > + kfree(s_rq); > + return 0; > + } Would it be possible and make sense to use the __free() approach in the above two cases as well? Thanks, Juri