From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E4792192F9 for ; Mon, 19 Jan 2026 14:00:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768831258; cv=none; b=T5RVz8JYlWmdZ9wk8IbCJc9z/O46Wxaiq2B2nfxdAO7Myp3z5ta6XVxKbyRU67JrQb3iCH9wRyl9lCjyJFgu/YpZ8LdjZb5e5KYGZ8qMlibz1aKCNwxIhlWtznYJI/wuhBPluxITeDA+TpoNsiCQooWZxu/qZD+jQlj94hhQOls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768831258; c=relaxed/simple; bh=kVglwLuT6X3Nzm1IvVM21SXIBZB/XXgWlWawvNAnTdE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MINqzvyXRUtmtfbyBfL/JwafdUU25zLS9x9YlcFul6tWZtnVFp//ww8aP1t5tW7QQK9aexoYSrkwu1573XKWYPbS+yB+DtQ6OQzrOBQ0LK8WtRQBwkRJUwBgaoI7If2IztBjbzdB8Nf6xl11BBEyANZGa+G9MXKEgSA8vn2iyXU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IENppwFT; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=RrvhnHGT; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IENppwFT"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="RrvhnHGT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768831255; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=li9BnTK0YgfJ9F0DEIz+kKmYU06Y/HjQQtOi6fTe3IU=; b=IENppwFTTzmj31MNJqnkvqd5qtllOIW6sb0BrUJf98v/F6obaDGLT8VzXkbjNIz1FkrnDn ti/+zCWwyR7G8w4+sG5gX+5f6faj7IKWFYpBZUrD5fnrj/8Fsy7AVwmU7c7YWJKUloYqxF sIfPXsr5o4LNikHRX+YTnY/HgmbsLeI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-218-lQbW6dv3NhyqyzpjhQFJAQ-1; Mon, 19 Jan 2026 09:00:53 -0500 X-MC-Unique: lQbW6dv3NhyqyzpjhQFJAQ-1 X-Mimecast-MFC-AGG-ID: lQbW6dv3NhyqyzpjhQFJAQ_1768831252 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-430f5dcd4cdso2415076f8f.2 for ; Mon, 19 Jan 2026 06:00:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768831252; x=1769436052; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=li9BnTK0YgfJ9F0DEIz+kKmYU06Y/HjQQtOi6fTe3IU=; b=RrvhnHGTn1flndQrueQcd6f2PiOD1IbrfQIwbrL+AECzIy2Q99METnnF94CBiQtlom vdA2GVFunPvo2MLuJVEbegh3C7DQ2e+hhRpZl+WDrw4Z8ZVBcboxyHii6j4tqYZfncel 9ycWS7gR9YAxnd0I1zVXIZWMKDJJFVBxXrZJAClnzj9P/7EZml+H57TT/r91CXZKI7sU aQVsOq07r66cO8H8vzNLnOPD1m9hmBxFyjx1fKgshUauJhL28m4HQhIoIURdGgx/LNwp 13wkZcReBTl1/XhI2lWkjU0NH7aMPD4z+ejXAiOD+cqqMuln4GSlVwvCfR5oMPFCdj+1 8rag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768831252; x=1769436052; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=li9BnTK0YgfJ9F0DEIz+kKmYU06Y/HjQQtOi6fTe3IU=; b=sGHUSWjmSd2MmuH9ChIgxmnoYeoYsLSRVJUq4x1GxUAxOqF80b8p/Kz5gzPDbkTpwm I0f4wmavGORHpKY+hFKd8Kyrce4UJXe11ypvdinJpgJztqBjhkdAg6IIP59+bLiGpq7f cnH7V2CfpliWKnxugJTtcY15eHzFWy6Sk85CKGiT58A8inO4ta6LSYMvmRvZfx725lfz O5GvjXRuPLV18ufkAXr1EKpM3Wi9KOBBxffwy5BkQBeQdCgSmyq7pz9LtaKj+Y/O+UI/ 0yE+hiGC0byDH33/7jPDkKDX2dJlfAu+W2hKbkvSZXvHD5ywh7OIsGkRYUjuLv3tEVay BzvQ== X-Forwarded-Encrypted: i=1; AJvYcCV3fhBsyop8EC0H2gKupKfXtpKAguQ37/6CcCzqJ0mQo8GDBTkc4Vrf5wKp4hfGaPHf/DCShloZK0EgPvA=@vger.kernel.org X-Gm-Message-State: AOJu0Yypxf3aD56BqyMURuJmr99eb5w6PGAPT4g8L43LqgTk5VMXc2Lx I+rcmN7QT5mGySKGATkWBFe58PInCIeAxJbkOOw6Z+3cnuy977q4xA4FSYUONhrmKWO/dZtkkaq 97nJjbcNmSx479xFQmhTUPZl+F7v9vxvPw3sryHV4VAlP4jMyxJ62/wTKI9q5JSgAdg== X-Gm-Gg: AY/fxX7Zu65DAeV5HiXpAtVyyG6qpjbz9/KoLMm6jdbnqdoNEceRzrUUnQ0vN8Ab/57 VrTRHdPMQpnoMEEQEqQahavZvj3sjSYf4u4owhqvM3CbCLYwPTNDQknjLz5H+Nelthaw+0Jat6e PUFFG6r1SvzsAXoa5qMTyBy1FFPFx37fWMGjYOV9TPulTu8Bzz3mZB/UJtgl51Jv6bXqjRTuNnX PSs45Xw5dl78smRFl4Rv/o8kwfr2Ke0/p/S4U+4h/0Ar1iLQ5VH6CoV6Dsyn9O0zCx/94Nj7PBu L8zkWMEJq2H5NcPmNgJJ/O8ozhKcDOvqvmzuRZOPjc4Vu92EYcwSpEMT1c/PJ4/cmXe7qrU0qJE dRaX6dMrJ1k0kvBrrGvhGlFV5sPGWaxKOqBeU8PLU X-Received: by 2002:a05:600c:138c:b0:47e:e949:37e8 with SMTP id 5b1f17b1804b1-48039d19076mr21021325e9.30.1768831251856; Mon, 19 Jan 2026 06:00:51 -0800 (PST) X-Received: by 2002:a05:600c:138c:b0:47e:e949:37e8 with SMTP id 5b1f17b1804b1-48039d19076mr21020805e9.30.1768831251302; Mon, 19 Jan 2026 06:00:51 -0800 (PST) Received: from jlelli-thinkpadt14gen4.remote.csb ([151.29.129.40]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47f428ac749sm256557345e9.5.2026.01.19.06.00.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 06:00:50 -0800 (PST) Date: Mon, 19 Jan 2026 15:00:48 +0100 From: Juri Lelli To: Yuri Andriaccio Cc: Ingo Molnar , Peter Zijlstra , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , linux-kernel@vger.kernel.org, Luca Abeni , Yuri Andriaccio Subject: Re: [RFC PATCH v4 11/28] sched/deadline: Account rt-cgroups bandwidth in deadline tasks schedulability tests. Message-ID: References: <20251201124205.11169-1-yurand2000@gmail.com> <20251201124205.11169-12-yurand2000@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251201124205.11169-12-yurand2000@gmail.com> Hello, On 01/12/25 13:41, Yuri Andriaccio wrote: > From: luca abeni > > Account the rt-cgroups hierarchy's reserved bandwidth in the > schedulability test of deadline entities. This mechanism allows to > completely reserve portion of the rt-bandwidth to rt-cgroups even if > they do not use all of it. > > Account for the rt-cgroups' reserved bandwidth also when changing the > total dedicated bandwidth for real time tasks. > > Co-developed-by: Alessio Balsini > Signed-off-by: Alessio Balsini > Co-developed-by: Andrea Parri > Signed-off-by: Andrea Parri > Co-developed-by: Yuri Andriaccio > Signed-off-by: Yuri Andriaccio > Signed-off-by: luca abeni > --- > kernel/sched/deadline.c | 21 ++++++++++++++++++--- > 1 file changed, 18 insertions(+), 3 deletions(-) > > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > index 4f43883a65..089fd2c9b7 100644 > --- a/kernel/sched/deadline.c > +++ b/kernel/sched/deadline.c > @@ -213,8 +213,15 @@ void __dl_add(struct dl_bw *dl_b, u64 tsk_bw, int cpus) > static inline bool > __dl_overflow(struct dl_bw *dl_b, unsigned long cap, u64 old_bw, u64 new_bw) > { > + u64 dl_groups_root = 0; > + > +#ifdef CONFIG_RT_GROUP_SCHED > + dl_groups_root = to_ratio(root_task_group.dl_bandwidth.dl_period, > + root_task_group.dl_bandwidth.dl_runtime); > +#endif > return dl_b->bw != -1 && > - cap_scale(dl_b->bw, cap) < dl_b->total_bw - old_bw + new_bw; > + cap_scale(dl_b->bw, cap) < dl_b->total_bw - old_bw + new_bw > + + cap_scale(dl_groups_root, cap); > } > > static inline > @@ -3147,10 +3154,16 @@ int sched_dl_global_validate(void) > u64 period = global_rt_period(); > u64 new_bw = to_ratio(period, runtime); > u64 cookie = ++dl_cookie; > + u64 dl_groups_root = 0; > struct dl_bw *dl_b; > - int cpu, cpus, ret = 0; > + int cpu, cap, cpus, ret = 0; > unsigned long flags; > > +#ifdef CONFIG_RT_GROUP_SCHED > + dl_groups_root = to_ratio(root_task_group.dl_bandwidth.dl_period, > + root_task_group.dl_bandwidth.dl_runtime); > +#endif Can we move these ifdefs in some header and use helper functions instead? Thanks, Juri