Re: [PATCH v2 4/9] arm64: dts: imx8mm: add wakeup-source for usb phy

[Frank Li <Frank.li@nxp.com>]

On Sun, Jan 18, 2026 at 06:29:46PM +0100, Marco Felsch wrote:
> On 26-01-18, Marco Felsch wrote:
> > On 26-01-17, Frank Li wrote:
> > > From: Li Jun <jun.li@nxp.com>
> > >
> > > USB phy can be wakeup source to support wakeup system from USB.
> >
> > Was USB wakeup tested? That beeing said, marking the device as
> > wakeup-src is fine.
> >
> > > Signed-off-by: Li Jun <jun.li@nxp.com>
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> >
> > Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
>
> Just noticed that this targets the base soc.dtsi. IMHO this is board
> desicion to make and therefore belongs to the real board.dts(i) or dtso.
>
> Therefore please drop my r-b.

wakeup-source is captiblity of hardware. The user need use echo 1 > wakeup
to enable it. it is SOC's feature.

Frank

>
> Regards,
>   Marco
>
>
> --
> #gernperDu
> #CallMeByMyFirstName
>
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |