From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66226B67E for ; Tue, 20 Jan 2026 08:24:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768897472; cv=none; b=b2I4Vwl7IkE2Nkt98+37GIIhYVLCE3BmM4nK634BTF/tdojjDbddH+DBTCgnLcWus0i+MeFkR1W85s+We9f2XIx8v8erVA07QRfdvaxqU37TjWl5fP8MWw6zH2U0ICGy6lQtPv5jQn5/TWe/MhBtR771bVdAdcVuxvA6qO0FaUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768897472; c=relaxed/simple; bh=SHLkAP25ZNUEHqFFfopsGAuSGCPVl7RgID2A5jeb7qg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tdqyHq45YGD8HRCoWp92TdzQ0XYomxLAIeZdEtpRn8otYyP+STvdhpj72Uc/Bngu5J8MCe82i10rQIRv+MwwPwdvDgr9SW4ju8aAynzeeBCihOcZje1kkyBLsgOU2CyO0PBGugkcJ2xyDOwBVSh7SNMtzMRrpx7NJ7VRnfWqhnk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=PDQFS52w; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="PDQFS52w" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1768897471; x=1800433471; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=SHLkAP25ZNUEHqFFfopsGAuSGCPVl7RgID2A5jeb7qg=; b=PDQFS52wwk4LJzthrhic1MO+miWZbCiORh8CG6ccfftFinXzBbr2p1bl jMy2mvcMAK4+KY7L2tE46yJ+LhVixkxllk2nVHpAYC9l4xcPX9lcNeIhR VBzhDkze/hJERH2QuzVshygfcQ8S6QFw/ZMcK0hwYtuSMOq599H2SHp7Q GBQYMvUiDvyYV2w2paDaTyO3XnTt7cybQf+XZZ11ppvyQrl/2ddrC0Wmr JNOcTNCwUQJNHjyUOBr/5V3UulIwflWjwmxb7810J1dWElH1g0ld5VC60 3tvSg0AbtTsMQvYqPCxTf/ZU1nkVe4OXyvG4d1ZwCdjXqg8UReocbEtJ6 A==; X-CSE-ConnectionGUID: w+3f5yA5RcyFd2zZlC+CjQ== X-CSE-MsgGUID: AwJ0fsoPTdivAomE0y7p/g== X-IronPort-AV: E=McAfee;i="6800,10657,11676"; a="80732692" X-IronPort-AV: E=Sophos;i="6.21,240,1763452800"; d="scan'208";a="80732692" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2026 00:24:29 -0800 X-CSE-ConnectionGUID: PwvL8aF+TwiXNYJjlQTrhg== X-CSE-MsgGUID: bYVnmfgXQwG8beUQwlVjgA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,240,1763452800"; d="scan'208";a="205966688" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa006.fm.intel.com with ESMTP; 20 Jan 2026 00:24:26 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 4770A98; Tue, 20 Jan 2026 09:24:25 +0100 (CET) Date: Tue, 20 Jan 2026 09:24:25 +0100 From: Andy Shevchenko To: Dave Hansen Cc: linux-kernel@vger.kernel.org, sohil.mehta@intel.com, Borislav Petkov , "H. Peter Anvin" , Ingo Molnar , Jon Kohler , Pawan Gupta , "Peter Zijlstra (Intel)" , Thomas Gleixner , Tony Luck , x86@kernel.org Subject: Re: [PATCH 1/6] x86/cpu: Break Vendor/Family/Model macros into separate header Message-ID: References: <20260119195047.86E3C696@davehans-spike.ostc.intel.com> <20260119195049.43DDFD4E@davehans-spike.ostc.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260119195049.43DDFD4E@davehans-spike.ostc.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Jan 19, 2026 at 11:50:49AM -0800, Dave Hansen wrote: > The intel-family.h header uses Vendor/Family/Model macros but it does not > #include the header where they are defined. If that header is included, > the build blows up in #include hell. > > Luckily, these macros are completely independent and do not themselves > have any dependencies on other code. > > Break the VFM_*() macros out into their own header. > > Signed-off-by: Dave Hansen Still don't understand why people putting Cc list before the cutter. This noise in the commit message and when retrospectively one reads on the small screen (I do on the phone from time to time) it makes it at bare miniumum inconvenient). > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: "H. Peter Anvin" > Cc: Tony Luck > Cc: Pawan Gupta > Cc: "Peter Zijlstra (Intel)" > Cc: x86@kernel.org > Cc: Jon Kohler > --- ... > +#define VFM_MODEL_MASK GENMASK(VFM_FAMILY_BIT - 1, VFM_MODEL_BIT) > +#define VFM_FAMILY_MASK GENMASK(VFM_VENDOR_BIT - 1, VFM_FAMILY_BIT) > +#define VFM_VENDOR_MASK GENMASK(VFM_RSVD_BIT - 1, VFM_VENDOR_BIT) There are tabs after #define, is it on purpose? (yes, I know this is simple move, but if not deliberate, we can tweak the tabs/spaces while at it) ... > +#define VFM_MAKE(_vendor, _family, _model) ( \ Ditto. > + ((_model) << VFM_MODEL_BIT) | \ > + ((_family) << VFM_FAMILY_BIT) | \ > + ((_vendor) << VFM_VENDOR_BIT) \ > +) -- With Best Regards, Andy Shevchenko