From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FDD3345CC7 for ; Tue, 20 Jan 2026 09:37:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768901862; cv=none; b=JMqZcEmKk9k6RVBdExCCD1osgvrGpyHw4sgl5wDazEjvyYxKcwikZC/Yn3J8lOjufAfIK+k6pizpw6BQaI3VEUmc6MpL0gQm5qS62ff5/vnutvzvW26PlIUdLwOFuliAK3+sTzYqOFjWaKGdhsrB8qOqZvVOyqFZH+QqYATlvNY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768901862; c=relaxed/simple; bh=gJ8LRdePpGdfZIJ/xvuV9faBPChp54PHBmUoMXirzAw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=l2ynJQaU4zvwbHSiuWZeA+bKQAgo4Neuo2A0GtC0P8OuCROte7pW2he34FrASW/CoFbyVhXe7pqYsGeR6AQQE8W1AhA+fbgJj5HQh7qOh2eXJQCcQNrukKrqZywIUAfBjlxon+GOH10+yWiHhA3ykXkHr8MyBEUPAmpJqRNOIdc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=K8+JF6mM; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=clDBS6kH; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="K8+JF6mM"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="clDBS6kH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768901859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1riUelQkHubbog4Pig/nehvQm9nmVpndQsv6Cs1UVao=; b=K8+JF6mMHL76bZxS+ci6CY7KEnR5jdjxJGutZ+fuCfQlF0fbr47SzwJjAOKJRQ0ugF1xb0 2Y71nRwmVtTchM1c6Un9PoE5UDZrtlTG8co6aH7HiMY+vimmGji2SprwxZjyjaG8yEzvWS uC2gzmgydR7cJT0JMc9UHzoDT7IdtXQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-341-x8C0TscqPHmPVizTLbTyrA-1; Tue, 20 Jan 2026 04:37:37 -0500 X-MC-Unique: x8C0TscqPHmPVizTLbTyrA-1 X-Mimecast-MFC-AGG-ID: x8C0TscqPHmPVizTLbTyrA_1768901856 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-431026b6252so5225656f8f.1 for ; Tue, 20 Jan 2026 01:37:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768901856; x=1769506656; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1riUelQkHubbog4Pig/nehvQm9nmVpndQsv6Cs1UVao=; b=clDBS6kHuU02e+svmRR7saf/d/7sXPtTCBrZqdainfUer3Ca8mC7vbq2mu+aFLdw3Q I8aR/8hdlZSmln8sl3WNdIz6E+GzjWZGfvs9g7rMcQj1tic2Lr9Y+iJ9JE/ydbWCuKp5 gbADY0103aGNyrfR/uFtF7+cZsOAaT0Q4eUlF3cIawQK/LLEZVlDzsdJMwO5niDelrC/ iBthyFfxBDJdzuBix0iny0V/TJ0PUXFbcQrRrVd6BC4ZaN9b0lw9iOlovBcjTklRd0pp 93gLowV0g6E+Oiz9wnlUStpTnPpaVnj7b5r1xJWDeDWXtdwk7hkGkVwDtRJo5oapXJHG 4HhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768901856; x=1769506656; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1riUelQkHubbog4Pig/nehvQm9nmVpndQsv6Cs1UVao=; b=YaGVenZ6FGC6p78PAQpldaK0WoA2ToBBhhnJrE2gt58/SkuudMUclP79rmiu7BMw3R 3rmm2a0W4/dwA4m0tBwRrh8ks75CBRF4bhxSjXMg7+HorglSvgRtHk16sobGhorRDzEy 7c5Lq90sdRuZ8D2FLy94RcRU9DWkkvpuA0gMz3fMzqN5BEnkVJg+SMTui/ySbDWKuDEn JQuxGi9DSajdpHVfFp0btr9oh8w1pKGCIwu6EVwRYyC4Cr4oV/3mrPNuZFh4IesDPUjs j4+URUmeu1BI70kj867ev+RBORn7AyaTeV1CK86zBq9FsX/Ho0cJ48KATN+SfU6LRzXH AC5A== X-Forwarded-Encrypted: i=1; AJvYcCVi58izWIFUEWtL8ZHbPTfDZvtLAzIZ0QGp2HE/Sz+MyMHZGLPoDfwWPsIwUC6hIR0MaKO8NpW25dcB1qI=@vger.kernel.org X-Gm-Message-State: AOJu0YzLdveKLj1gksMQ7R/5ZzHgn+q/u45thvvLVhtMN/x24oNBzmHe GWPPIaEcyPxznuyOv9HyG9VkEjpC19NfCANbNFeo4uiGRhNYK32lOZfpsT4mUdRSXuopJ3AdMNT 3O0NFE3AWJMp+mj9C+7uyV4zyjdpV5P3whI4tdixh46DYo4BpYJnVJ2Ee86BT9tQWxw== X-Gm-Gg: AZuq6aIx7r4IGsn4a8YRvUY9KHbIJlc93QSNz6mduRNgiqW2ev9ueMokiB48W8OsJc7 ZPoGMbAVaCp5ugoyK4Dd2s2/Un1atGycxNQHaPJvakwcZmDyMcIZJIOgV/E4Jv/rsg38cKnIZVT 1PfcKOrRVrrVsIdJndsIRjutzTvp1XqnnvCGb9Zd94A1S+T8B/YoU1y0lFCwukQMuyNWTny8Qfk eDjXGZibpKfzHdhnVMwF80iRbwBPv9fWPV8fr7UZb0kbq8haLzhRqyu0Yg88OlXfmIKHCQsKtqK 5OE81qJbif0X+eP9/HrPIOjmTGsFSLDic4qxhZQz/dtBk3dnZjKn3fQV2HYpstResO92jgWndtm XOwL4oJMB8TpX/3yAM/+bbhQOk1zhZO7kN02GVJOkxmQtS29JAArdLJTOqEw= X-Received: by 2002:a05:6000:2f83:b0:432:5b81:480 with SMTP id ffacd0b85a97d-4356a03d2demr19167517f8f.24.1768901855991; Tue, 20 Jan 2026 01:37:35 -0800 (PST) X-Received: by 2002:a05:6000:2f83:b0:432:5b81:480 with SMTP id ffacd0b85a97d-4356a03d2demr19167470f8f.24.1768901855514; Tue, 20 Jan 2026 01:37:35 -0800 (PST) Received: from sgarzare-redhat (host-82-53-134-58.retail.telecomitalia.it. [82.53.134.58]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4356996cefdsm27663754f8f.24.2026.01.20.01.37.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 01:37:34 -0800 (PST) Date: Tue, 20 Jan 2026 10:37:12 +0100 From: Stefano Garzarella To: Jakub Kicinski Cc: netdev@vger.kernel.org, virtualization@lists.linux.dev, "Michael S. Tsirkin" , Eugenio =?utf-8?B?UMOpcmV6?= , Stefan Hajnoczi , Paolo Abeni , kvm@vger.kernel.org, Eric Dumazet , linux-kernel@vger.kernel.org, Jason Wang , Claudio Imbrenda , Simon Horman , "David S. Miller" , Arseniy Krasnov , Asias He , Xuan Zhuo Subject: Re: [PATCH RESEND net v5 0/4] vsock/virtio: fix TX credit handling Message-ID: References: <20260116201517.273302-1-sgarzare@redhat.com> <20260119101734.01cbe934@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260119101734.01cbe934@kernel.org> On Mon, Jan 19, 2026 at 10:17:34AM -0800, Jakub Kicinski wrote: >On Fri, 16 Jan 2026 21:15:13 +0100 Stefano Garzarella wrote: >> Resend with the right cc (sorry, a mistake on my env) > >Please don't resend within 24h unless asked to: >https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#tl-dr Sorry for that, I'll avoid in the future. > >> The original series was posted by Melbin K Mathew till >> v4: https://lore.kernel.org/netdev/20251217181206.3681159-1-mlbnkm1@gmail.com/ >> >> Since it's a real issue and the original author seems busy, I'm sending >> the v5 fixing my comments but keeping the authorship (and restoring mine >> on patch 2 as reported on v4). > >Does not apply to net: > >Switched to a new branch 'vsock-virtio-fix-tx-credit-handling' >Applying: vsock/virtio: fix potential underflow in virtio_transport_get_credit() >Applying: vsock/test: fix seqpacket message bounds test >Applying: vsock/virtio: cap TX credit to local buffer size >Applying: vsock/test: add stream TX credit bounds test >error: patch failed: tools/testing/vsock/vsock_test.c:2414 >error: tools/testing/vsock/vsock_test.c: patch does not apply >Patch failed at 0004 vsock/test: add stream TX credit bounds test >hint: Use 'git am --show-current-patch=diff' to see the failed patch >hint: When you have resolved this problem, run "git am --continue". >hint: If you prefer to skip this patch, run "git am --skip" instead. >hint: To restore the original branch and stop patching, run "git am --abort". >hint: Disable this message with "git config set advice.mergeConflict false" > >Did you generate against net-next or there's some mid-air collision? >(if the former please share the resolution for the resulting conflict;)) Ooops, a new test landed in net, this should be the resolution: diff --cc tools/testing/vsock/vsock_test.c index 668fbe9eb3cc,6933f986ef2a..000000000000 --- a/tools/testing/vsock/vsock_test.c +++ b/tools/testing/vsock/vsock_test.c @@@ -2414,11 -2510,11 +2510,16 @@@ static struct test_case test_cases[] = .run_client = test_stream_accepted_setsockopt_client, .run_server = test_stream_accepted_setsockopt_server, }, + { + .name = "SOCK_STREAM virtio MSG_ZEROCOPY coalescence corruption", + .run_client = test_stream_msgzcopy_mangle_client, + .run_server = test_stream_msgzcopy_mangle_server, + }, + { + .name = "SOCK_STREAM TX credit bounds", + .run_client = test_stream_tx_credit_bounds_client, + .run_server = test_stream_tx_credit_bounds_server, + }, {}, }; If you prefer I can send a v6. In the mean time I pushed the branch here: https://github.com/stefano-garzarella/linux/tree/vsock_virtio_fix_tx_credit Thanks, Stefano