From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f180.google.com (mail-dy1-f180.google.com [74.125.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E76D030E0F6 for ; Tue, 20 Jan 2026 11:40:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768909203; cv=none; b=TkoyamIO0Cvs30moLiWPfVJ/rXJmulm6DzCs8f07zjNck5rakD+w1bnrHNalakU/Ke4hUgPbIX0d/pOSqTRIS7Lsj88pJL0KCCg+LeDq/5gpwb+j4qdXF+vr0LzDx+GPYKGaWZfi8PYNW3puhZ+d1Q0Q6oDLeIQY0stonbhR2lc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768909203; c=relaxed/simple; bh=jrQhr8hRcob+nmP7FXhfmRMEqhWFIhwmQ2N3yM90I3U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YiMD489zW2H0q5l5zKccg+yXcxGjT67FfsEM8bPzabUCWBy7lUGrSPUYzg5DffnnzCo2KLEOMkRDr8QXM8wJcqlQfPTx2vRCSEx5SToQJjQL8OxSs0MixzjlGz8sVi6lZ63WXE4GOCxo1lijFd6XyOSr6/lmnMi7iT8otmjzAy4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VneoogXh; arc=none smtp.client-ip=74.125.82.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VneoogXh" Received: by mail-dy1-f180.google.com with SMTP id 5a478bee46e88-2b6f5a9cecaso1356112eec.0 for ; Tue, 20 Jan 2026 03:40:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768909201; x=1769514001; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QeACF3mv4Ishn0NV7RQhnzhSMHx1UMVLhYGwPqoV7AE=; b=VneoogXhouU1bgDmoCFpGVIO0NQ12Tu1rmi6aayCtGwxDdscrGNYffXXIiaWX7M8cx hyo9Bvn8vBwg5d8PiMjm1wCFlCyBdGQx+BILG0SMBFVaaDtojpo5/fnZ9Gu3JJs0DMu2 uzwCjm+BGX1W7gYJJTKH386Z63vVMwDJE3nyP+bchcH0TpcMTrs9GAYyrneuA4MidQTE 5fr+gxPTCCMBJzwXW8MX16Rzn2+F6ttFg84FeutdUKyAREoUpPcMGRM0OeemWPju7oMN pO+ICJe9pWKPTAdKvzI152THat+6X1fn0E9ktvSeLQgPT1prEcJlJost3F1qEMvenSqG K0Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768909201; x=1769514001; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QeACF3mv4Ishn0NV7RQhnzhSMHx1UMVLhYGwPqoV7AE=; b=Q6h9pQkmjYVusmx5lGA98g3GxljScEuXycRUV5nfxkVPhITeJCXxFaMBmoc3TyoiiZ 1KlD05fh/8IwSSpUr1vH54h9iHgXF8rDJA6MA7lmKRLjfHtXV5T5UgR10mX/AtfGH1uI 4WRx1RAF67LEn8BUu0ppOJ12V7L/lASRbxtBw1e2fEKEJBdLssKeEEvQF1iSh11lPRnp d8xamsCvTiG1DYmPQ+vSxOdGDuWm0jH4l1FALQnhGzlSCm2py8M4Hq53Cc3wrBMzhcax RYxUw8TiEr06GjWMCzcTEwmQX3+p8Byjbl6S5e/KQPitAkmaVEFfte4qEXIIt7uqbNcT 3QYA== X-Forwarded-Encrypted: i=1; AJvYcCW0dCWdn72R+I6euwxA7xPlbeflCJZ6JN6V75NMsjjtowx73l7vykgFXaK0i9EhaM0wGNLjbFobk6/v6JM=@vger.kernel.org X-Gm-Message-State: AOJu0YwzJlouxMiT5hmw07GJFeWypnxvaU2td6I+nGtKUYjyB27OXBRr fQCUgQ4b0va8ndooMSYySD62HMw6MgRh4Lngs74LZ5wY9n86COubFYkE X-Gm-Gg: AZuq6aL01GnykkXbi9c0sjQPVWLZHydc34Df0GVsZHHhxzJxKZMVGWkZvF0mUdXwesm gvavR0Pjuikvo6tpC/CyewaP7OM5M+Xkg/EgHAHOnxg2atqNu0U3v4TmrQbno5CljTbbNsm6utt cBUzVgi7nFQ1psqagXz9SH9WquKSH7uKE9dMe5zwCujkEr83k/ud3J/EFcOMD0m6TU6iiUvQk+g sIKeA6BlsOcczW5sHnKObH43lThvy3qN0jiY/YT0rQTbfDSJHFzy6UzPYZg++Vcw5yTDfYaE/2y q5bEmuR2nujdSgK3IMHJJzPrtHgn3kRXM4FP7yU811DFBh2d3Rxil3TWQjhTv6n45QIzz9MbZuy toxPW7LtRAL+X6r5y+G4N/MLkEH10+/DIRFQG+hImQQNGl2DbjBirYo/3kT8uVuykdJDT5ZdjcX UgmP9TfQ7FYw== X-Received: by 2002:a05:7300:2315:b0:2ae:5967:db5d with SMTP id 5a478bee46e88-2b6fd746cacmr1048269eec.13.1768909200775; Tue, 20 Jan 2026 03:40:00 -0800 (PST) Received: from localhost ([2001:19f0:ac00:4eb8:5400:5ff:fe30:7df3]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b6beeb4b9csm17558900eec.30.2026.01.20.03.39.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 03:40:00 -0800 (PST) Date: Tue, 20 Jan 2026 19:39:49 +0800 From: Inochi Amaoto To: Yao Zi , Inochi Amaoto , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , "Russell King (Oracle)" , Yanteng Si , Yao Zi , Vladimir Oltean , Lad Prabhakar , Choong Yong Liang , Maxime Chevallier , Chen-Yu Tsai , Shangjuan Wei , Boon Khai Ng , Quentin Schulz , Giuseppe Cavallaro , Jose Abreu Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Longbin Li Subject: Re: [PATCH net-next 1/3] dt-bindings: net: Add support for Spacemit K3 dwmac Message-ID: References: <20260120043609.910302-1-inochiama@gmail.com> <20260120043609.910302-2-inochiama@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jan 20, 2026 at 10:55:43AM +0000, Yao Zi wrote: > On Tue, Jan 20, 2026 at 12:36:06PM +0800, Inochi Amaoto wrote: > > The GMAC IP on Spacemit K3 is almost a standard Synopsys DesignWare > > MAC (version 5.40a) with some extra clock. > > > > Add necessary compatible string for this device. > > > > Signed-off-by: Inochi Amaoto > > --- > > .../devicetree/bindings/net/snps,dwmac.yaml | 3 + > > .../bindings/net/spacemit,k3-dwmac.yaml | 107 ++++++++++++++++++ > > 2 files changed, 110 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/spacemit,k3-dwmac.yaml > > ... > > > diff --git a/Documentation/devicetree/bindings/net/spacemit,k3-dwmac.yaml b/Documentation/devicetree/bindings/net/spacemit,k3-dwmac.yaml > > new file mode 100644 > > index 000000000000..58dd98f79e8a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/spacemit,k3-dwmac.yaml > > ... > > > + clocks: > > + minItems: 3 > > + items: > > + - description: GMAC main clock > > + - description: PTP clock > > + - description: TX clock > > + - description: PHY clock > > Why does the MAC require "phy" clock? Shouldn't this be handled in PHY > driver instead, or I get its meaning wrong? > IIRC, the "phy" clock is used to pass the phy from the mac core, I will double check if it is possible to connect to the phy directly. > Also, I don't see "phy" clock is acquired anywhere in the driver. Is it > really necessary for the MAC? > This is a mistake, I remove this by accident, if it is necessary, I will add this in the next version. Regards, Inochi