From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97610315D49 for ; Fri, 9 Jan 2026 02:34:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767926046; cv=none; b=LnfC/6SwXlOpGVVdrZXOag58aU4z7YWkNJOMmTusZ4hVAHDiFu3vVIWc3nFgUIZhd2aWuipRWRIiCKsGM414YGYyDG8v+cIvpZbySe3+p3/ZN7hHIYJMR15xDVd2nXenSt/1dJr1jqGUdI78hnrzbQtoV8pj0ZwAKKGjjUnyq/Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767926046; c=relaxed/simple; bh=IBX+xv69uFP/pcSBHjI9RUUY0+z8+gLHuXhIxtKTIOw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HB6zbjsRyWBhf6uHePUYvzPPDnGUp37NU63fm6Ht1ioKiFxDxHFlH40bxzVhG0NBXU0dHY19ghcqe/nyywEOz5KLTyXRoTYKOm7EmrG7pmLbdH+yXoU5wS8HQX4CJOwBsFkIl0sQkEq6jnOEqVM/AZ5eyfMtMYfgQyrPHz8qb3Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PSX89Ts+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=K5Bl2Ih/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PSX89Ts+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="K5Bl2Ih/" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 608HkhRx3167579 for ; Fri, 9 Jan 2026 02:34:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=pjAzBejL8JL4/IEU54yimhls JPnHrnNM1tihLzjWhOg=; b=PSX89Ts+xSMLquA4sVNQHb8D4md0+wCHyXv2hmxZ 2nspvD1wkB846keLafxbhfJY6PfiqpmYW0n870KkOfUcHTLb4PzFlewXZoAqzRu5 qdypCCcB69i830lVCMDpj++9waQGL0Hhl6tEfFxfIyszEah9VR/S0a6uYaSweDVx 23sv/pT+xSMktGiZ5ZGHT3iyS7hz1b0XhTzFcLvHY/7I+6YJRJvKfhRAOvbS4ce+ C1FOlTjN3OqqehOVpyverbwTzYSVbCXCcleCZsQyFtIFN4MFzn2+kjDsgW0RAVAp O36rIICbXTgp/4uZLcMq49YFdC/oJVfZYxcgVhrYaWq86A== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bj89237x3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 09 Jan 2026 02:34:04 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8b24383b680so1422062185a.0 for ; Thu, 08 Jan 2026 18:34:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767926044; x=1768530844; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pjAzBejL8JL4/IEU54yimhlsJPnHrnNM1tihLzjWhOg=; b=K5Bl2Ih/OM2jikE0THRMmaeAysCgR6MtjVjx1WXANO1n6oWSwRGHu6TZTTtfnApqyb gsxubgWkOELMKYLwrrovtjxyCERKFujXXGuxEWGNkeTpBv0oumPxpfbnUsAb9vN4ZsUK BID6LiMMnEewMvijtysRzkKjP5FSA+XwuntdTFlQNG+A1bYV1AWEU9Mu+A+h9muY8HlT u9ner7zqIuQw+YXixMho1Xmd8oUoIM9mPrT9EnqQBdOdpi6zqS2igOCsq+7tZ/p5PZ8T fyTHLjeQ3ZO7hYr9/xQvLP6O4JBuEQ7wZ/Qn+L6kduBAR6wY62F0pn0GmdFyP2zrmL9z MAnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767926044; x=1768530844; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pjAzBejL8JL4/IEU54yimhlsJPnHrnNM1tihLzjWhOg=; b=q+I5oduvJNv7V5bYDdn4V4R6BihEG9Q9z1gXomUzp1ccwOA1IXUbvCovnp5/BWR4BI 484yHtW4o91GKbwrX0dz2mZ5kbMoDtY8QE1/w+JSFj1vPFXczqvxAirIZ8EThNHnZaTx 6Eox0YOvQV5HK6N7rKLhYiSLhRB0ppXuxVeQb9V2bA7wnbzOXUOnfx1Z7tgXjVBLA5i5 6+Zjm/PnGGLkXggyJAQMRsFWJlYkA+h4ASmuwo5SeTHW1sy/IIelRV/kiDzkj71Cw3SV J7Vjs6qo3286MH/64lNY0JZYsRsrA5K9Vnkbo0RO7i9xRqb8kT2AqvjReZYlc4BvOpE7 j+tg== X-Forwarded-Encrypted: i=1; AJvYcCWrjCth8lN3FrNKI9jPm8LUyOlg8LppyoW7BXqADBxmMwBKnMa1pKz87GjCmSgWEAArEBA5JlZwtpj+rZ4=@vger.kernel.org X-Gm-Message-State: AOJu0YwAeHoAUzG9GjKLKANbheSVIcTxxea3+TF8bEfeBx4MkgOwpLO6 M3IYbCIzEpZZzzO7Y8kZL2huyhjF6GMmNeMeZdyRo+FkVUvVXS2pjzvKniPoWzwFaLe7GhqQnmB BjgumfwAL8H+FVXT1fuy1P45W5+ySoJYzYR4L6vH3uTVstezfy8oARbXEIRoAuN22rFs= X-Gm-Gg: AY/fxX4zTcSHvcyKkzT9ZUBH+mIfxCsJ/PvOM9khmO+u12j751wALdbC8KBMx/mfRm4 kR9dWNdKhmSjshsWCnEXUeteasvJSAVKyiedA3DAMWAfNlRi8qGzEO568Gkl3UxNlL5FoXILGEc A1vBLinL5ZCChsMXAN0UvQ4kInXC7keYgQjhwNd3iwBJB+eeO3HnPzUFq4NGBlejuNzsOH+832v ePSl86wKSseH9qKk7C3NwNR53/wIjtzRJW3PuOn87rsdAejdhyQGvhlAoTSvbmtEJ2KkUAgaLVh Klecnbtnm3Jqi2+mNxnoskkDmaPPkQ6by2VxUXxTysflp58PYrW0rjnhPMk05jCZZL4dgI4X6ve XERau9zczkB+g+mWXTo4fH3mFA9nGASK0R8NHhZzr4x9EzsWl7tgLIGW8JfbgFFgXj074FlQ= X-Received: by 2002:a05:620a:690d:b0:861:119b:3052 with SMTP id af79cd13be357-8c3893f5aeamr1222803185a.51.1767926043856; Thu, 08 Jan 2026 18:34:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IENTUJZuyzQYyKEXuwN8Frzm1IG/sJYpeF6AXGlDy2+lmsKBcuMwUivs/WYg5LuI8xNKsyVkg== X-Received: by 2002:a05:620a:690d:b0:861:119b:3052 with SMTP id af79cd13be357-8c3893f5aeamr1222800785a.51.1767926043408; Thu, 08 Jan 2026 18:34:03 -0800 (PST) Received: from yuanjiey.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c37f54427esm753223785a.48.2026.01.08.18.33.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 18:34:02 -0800 (PST) Date: Fri, 9 Jan 2026 10:33:52 +0800 From: yuanjiey To: Dmitry Baryshkov Cc: robin.clark@oss.qualcomm.com, lumag@kernel.org, jesszhan0024@gmail.com, sean@poorly.run, marijn.suijten@somainline.org, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org, konrad.dybcio@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, tingwei.zhang@oss.qualcomm.com, aiqun.yu@oss.qualcomm.com, yongxing.mou@oss.qualcomm.com Subject: Re: [PATCH v5 10/12] drm/msm/dpu: Add Kaanapali SSPP sub-block support Message-ID: References: <20260108085659.790-1-yuanjie.yang@oss.qualcomm.com> <20260108085659.790-11-yuanjie.yang@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Authority-Analysis: v=2.4 cv=M45A6iws c=1 sm=1 tr=0 ts=6960691c cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=kj9zAlcOel0A:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=Ry2Wfz2E4BY8SyJT9oIA:9 a=CjuIK1q_8ugA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: d-gkMOchis_5duqV789d7FSQ-jup5fGy X-Proofpoint-GUID: d-gkMOchis_5duqV789d7FSQ-jup5fGy X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA5MDAxNSBTYWx0ZWRfX5lzQkvu4rumo dKYCLdK4Fw8k2s/wVLvNzRgkd4qApo5uhtg14VPsb4UhxujrICQ8XPaMl1YpvKHC5qW65++dFZm MbFJRQGql1oHerUoIOla8s2IWYGrgBnxwJ7yRFqc8p4Yk96QoqmlSMiQZMibs5rdwIl6iqeQYks oyx4xHln9N/DrxTOOsCIblZrS8dEAvfAJogjaBdJ4N8m0Do+bvOUi6jwGc3CEWSthlyUT3wajDV 0MqO+kGsTxSMG0qogEywizbkKbEVDdn7I1mdX5pB/NuXxgUPPuyExpG3GRq4ApgjL+1QpYrKAMz qlFRBJRNY+F/5kZI4Ti+DLHtv4Z5IMKsHMVQP80Zd9HA61w3CmHZ21JAGLxuhmGdGiVO/BR/DyE kDDChW3xOr5nlgp/7qZjOpIiALrfHU59xls0yYvIs9dZxPLvM0pd0hFjUvATN9bK+dPh3tAVR3a YI+0j2/wrGBYti7tMyQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-09_01,2026-01-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 suspectscore=0 clxscore=1015 spamscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601090015 On Thu, Jan 08, 2026 at 03:46:18PM +0200, Dmitry Baryshkov wrote: > On Thu, Jan 08, 2026 at 04:56:57PM +0800, yuanjie yang wrote: > > From: Yuanjie Yang > > > > Add support for Kaanapali platform SSPP sub-blocks, which > > introduce structural changes including register additions, > > removals, and relocations. Add the new common and rectangle > > blocks, and update register definitions and handling to > > ensure compatibility with DPU v13.0. > > > > Co-developed-by: Yongxing Mou > > Signed-off-by: Yongxing Mou > > Signed-off-by: Yuanjie Yang > > --- > > drivers/gpu/drm/msm/Makefile | 1 + > > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 14 + > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 14 +- > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 4 + > > .../gpu/drm/msm/disp/dpu1/dpu_hw_sspp_v13.c | 321 ++++++++++++++++++ > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.c | 18 + > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h | 3 + > > 7 files changed, 371 insertions(+), 4 deletions(-) > > create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp_v13.c > > > > > + > > +void dpu_hw_sspp_init_v13(struct dpu_hw_sspp *c, > > + unsigned long features, const struct dpu_mdss_version *mdss_rev) > > +{ > > + c->ops.setup_format = dpu_hw_sspp_setup_format_v13; > > + c->ops.setup_rects = dpu_hw_sspp_setup_rects_v13; > > Wrong indentation. will fix in next patch. > > + c->ops.setup_sourceaddress = dpu_hw_sspp_setup_sourceaddress_v13; > > + c->ops.setup_solidfill = dpu_hw_sspp_setup_solidfill_v13; > > + c->ops.setup_pe = dpu_hw_sspp_setup_pe_config_v13; > > + > > > /* QOS_QOS_CTRL */ > > #define QOS_QOS_CTRL_DANGER_SAFE_EN BIT(0) > > #define QOS_QOS_CTRL_DANGER_VBLANK_MASK GENMASK(5, 4) > > @@ -475,6 +482,17 @@ void _dpu_hw_setup_qos_lut(struct dpu_hw_blk_reg_map *c, u32 offset, > > cfg->danger_safe_en ? QOS_QOS_CTRL_DANGER_SAFE_EN : 0); > > } > > > > +void _dpu_hw_setup_qos_lut_v13(struct dpu_hw_blk_reg_map *c, > > + const struct dpu_hw_qos_cfg *cfg) > > Will it be shared with other blocks (DS, WB)? yes, _dpu_hw_setup_qos_lut_v13 will be used in WB, in function dpu_hw_wb_setup_qos_lut_v13. So maybe I should drop '_' rename _dpu_hw_setup_qos_lut_v13 --> dpu_hw_setup_qos_lut_v13 ? Thanks, Yuanjie > > +{ > > + DPU_REG_WRITE(c, SSPP_CMN_DANGER_LUT, cfg->danger_lut); > > + DPU_REG_WRITE(c, SSPP_CMN_SAFE_LUT, cfg->safe_lut); > > + DPU_REG_WRITE(c, SSPP_CMN_CREQ_LUT_0, cfg->creq_lut); > > + DPU_REG_WRITE(c, SSPP_CMN_CREQ_LUT_1, cfg->creq_lut >> 32); > > + DPU_REG_WRITE(c, SSPP_CMN_QOS_CTRL, > > + cfg->danger_safe_en ? QOS_QOS_CTRL_DANGER_SAFE_EN : 0); > > +} > > + > > /* > > * note: Aside from encoders, input_sel should be set to 0x0 by default > > */ > > -- > With best wishes > Dmitry