From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8774299949 for ; Fri, 9 Jan 2026 06:05:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767938714; cv=none; b=XAHHXuL3np2bXTJbI6h9n+konc2O5KYEMVafL5+EcjiEuRFLq+Sk2pp7RZF4Ys0jZZCzJLSBk48omd2ZygdUeSGGNTcEvAVxAEYWubsNhW88AAVmTFCn1k6qko0Ikz82dtplgNmCrEc4Kq/avMJQsKbSaxhuagqp7Yqh+YyE6C8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767938714; c=relaxed/simple; bh=5jmRjEH5N9K+TIrarSzQwamG6eEZwg5nkhCLwf4iIQU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QAsKulusRzIFPhLV+uRv0EGWxHuXt1Rydjgd0IBx+jTE660Kc+b/yRnWqE7RXNtfPxCzwOxTtzFa0kmaiHHWZin30HecUx9kLoDY7iRft3GGxm4pz0Lml6/yHGljNEAcc8FTv6HBjoJwxCyDx2EcnI+f1mORke4c480Qvtn5krY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ZXPnobZw; arc=none smtp.client-ip=209.85.128.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZXPnobZw" Received: by mail-wm1-f66.google.com with SMTP id 5b1f17b1804b1-4779adb38d3so27003235e9.2 for ; Thu, 08 Jan 2026 22:05:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767938710; x=1768543510; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ooM/uKuoWiEKylwC/sKJICq7ujylAuG7XtKbwAgBTOw=; b=ZXPnobZwtzcEe0L64TUMJO+9WZKDJ3EsPRfjpzt02D77Xh6G5OczuLJbnqJhSbJZQ0 qd8iE1nw3KdM1gl4TDtaYlu2DE93HHKJfIlYwrYcAl0aZBIzxF2tuD7MCy44sbQC08fn M2GloVDcEL/7D5ZzxjZKRTtogQQ+nbfhBVfHgf47tePNotnIgFcyVRTmvxdqFv622idi 7OYv9Sbeg6iDLCdxQrAS1MEmC9JDkyE4F9OgKhnLKe7DFRI8fqeBlszE1fPwO+5RwG1V hd4bBAyS5sPN9hd6uyzdSmpfpzBNmx4fdcy3CDLObwpPcB8CHQBUcfMldEHhosIxnmCZ 2AJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767938710; x=1768543510; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ooM/uKuoWiEKylwC/sKJICq7ujylAuG7XtKbwAgBTOw=; b=Jr2O3kd5sWKRmvMt2TXkg6yNrRahknzQ38Pk+sRUCyyAlqjs0dBpBNFErrhaLzLoqM Xq6Kh4RlE0YCM33PdeEJeH1SbzL69GcCN8dq5/8b36pO1+oe1vKmaeaJ4xoOZDbGmZhA aYu+3dXSjk9UJTOwU5weaKMG5j/LOt6+ARXBApQZIxWwTTe5X+2kiWnYVKmBIJjMY2KG RAQwq3Jh2zz9Wn3LJ+CdepleR+Y4pfnYPFrjoCVDVL9j1sbRapRK1cAsn7QLPtiCxm+q BeEhulIzxT+ejutHezB/OxrMjxadeK+33+vAUeQfxvsTa68VU86pe1j9DV8qk8Sy02w8 tk8w== X-Forwarded-Encrypted: i=1; AJvYcCWBEaT1pLR1r0nlwjPAA5eQuBTyRlxDe92lU/XB7tM+sUAiF3w2q4I3JXDXzdawBVCQPrHRhwwdAr1v/lk=@vger.kernel.org X-Gm-Message-State: AOJu0Yygw0saCCvVkHjgmfH2kVcq979Zd1HStLnsBVBf5bcJzsWmak0S euJnNd05hcZAHQIxqqE97FfNBCGs6OLIkMZ0ui+EpxaCyhHzIQWPvAGjRVaULzE0j/A= X-Gm-Gg: AY/fxX62FBl/EKVArRoHyCsxBfPCPUPJI5TJ9Zg8d29Vx/7k2QZqzlX0RwDLKWsANPM 68q/EoPnX+HKJdFiYp2JwKCfKBA9i1GuiiCfj6duZ8QHzIBmuosEa2Jf1yVJQiAV/eagOtI//A7 8qMOiXXYczsTIW8xPkHCagqCHPA1pBffZC0qPiqVcFn/2oSF081sJuDdCdsL4pnEUgbpCqlARQh 9XL9ngCYdioVAwX+iqHhC4xqzsShzLkrTHxQ1t+IKf6NaBlUYN4vJjABMkKHUX66xQAq8hvALM8 K0HZeCq/fqWEdWTQxE75j+PWGrpofadwfgK0+Pa9Jfcr9QX51UduSAPoYSL+5OTPmnYf5JP818S Mr5qKASk9OYnT1jZX2FeMTMmL2ocCjU5xJEK7AyGnKAaZTs9rVnUTFqfgcsDFfX08Zfgju+6It7 1CWXyIXFGNPIWgz3c/ X-Google-Smtp-Source: AGHT+IEw+1D/KV35h1xmcYg8u9aLCmfWv//Elr/Sqt7gE9ixomZwQZirSOOCipRMnwEtDetKsHdjHw== X-Received: by 2002:a05:600c:8b52:b0:477:abea:9028 with SMTP id 5b1f17b1804b1-47d84b1a348mr88128745e9.6.1767938710132; Thu, 08 Jan 2026 22:05:10 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f695956sm195146375e9.6.2026.01.08.22.05.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 22:05:09 -0800 (PST) Date: Fri, 9 Jan 2026 09:05:06 +0300 From: Dan Carpenter To: Dheeraj Kumar Srivastava Cc: joro@8bytes.org, suravee.suthikulpanit@amd.com, will@kernel.org, robin.murphy@arm.com, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Vasant.Hegde@amd.com, Sairaj Kodilkar , kernel test robot , Dan Carpenter Subject: Re: [PATCH] iommu/amd: Use array_index_nospec() for rlookup_table index Message-ID: References: <20260109052040.938-1-dheerajkumar.srivastava@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260109052040.938-1-dheerajkumar.srivastava@amd.com> On Fri, Jan 09, 2026 at 10:50:40AM +0530, Dheeraj Kumar Srivastava wrote: > Use array_index_nospec() to prevent speculative out-of-bounds > access when indexing pci_seg->rlookup_table with a user provided > device id. > > Signed-off-by: Dheeraj Kumar Srivastava > Reviewed-by: Sairaj Kodilkar > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/r/202510281233.q4cBnp3z-lkp@intel.com/ This is interesting because more and more people are using lei to recieve email and now they get unfiltered Smatch warnings from zero day bot. Normally, I just ignore these warnings because they're hard to review and I recently modified Smatch to stop the zero day bot from warning about them. The problem is that I've tried to contact people from Intel to help review some of the warnings but I've never recieved a response. I've heard that Intel has a handful of people that deal with Spectre v1 bugs but I've never seen any evidence of that... I've never tried reaching out to AMD. > --- > drivers/iommu/amd/debugfs.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iommu/amd/debugfs.c b/drivers/iommu/amd/debugfs.c > index 10fa217a7119..4990f6db99ef 100644 > --- a/drivers/iommu/amd/debugfs.c > +++ b/drivers/iommu/amd/debugfs.c > @@ -174,6 +174,7 @@ static ssize_t devid_write(struct file *filp, const char __user *ubuf, > kfree(srcid_ptr); > return -EINVAL; > } > + devid = array_index_nospec(devid, (u32)pci_seg->last_bdf + 1); This is debugfs so it's already root only. The cast to (u32) is unnecessary. regards, dan carpenter > iommu = pci_seg->rlookup_table[devid]; > if (!iommu) { > kfree(srcid_ptr); > -- > 2.25.1