From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BAB52D12ED for ; Fri, 9 Jan 2026 06:14:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767939286; cv=none; b=mCxdMV0A2cshykB7dpjOQVuNHh48/EiOsOT+Jv4dFqJoY9kehPQlweMzDMVSgeFrjB55Ys6ohisnUcIxzG+Mrd40TBsnJL1IvfHTTqbLtWQ3K6n4KCIYMftg7wGB/0dloxC8PVgI1INY+usmPEh1OsEYraPCJIis3V0kFscN36c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767939286; c=relaxed/simple; bh=P89mL8EUdwdPy2mb3P31kjWVpZSt5XhJNKN7W1rkSeo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WVsOrEkw4m24B6ylbJIctiOqcG3c0BLACUy1OBJH7n4JXngx3qcnBr8ah8vVwvVHNdrcmhD5u9axKlQFNcPe8vL9owIDboTvVVtV+KDWdhtA2YmgyV523tczgNEu50l9luo4ncB4BKk+mHLWoIpqKrN4vYKINC38N2owD7Uw8Uo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=RlqSi9JE; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RlqSi9JE" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-432d2c7dd52so938673f8f.2 for ; Thu, 08 Jan 2026 22:14:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767939284; x=1768544084; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/O/Eq2DaBroAxHgsa1v0NiIqCw4CsEf3jankMI7XtDI=; b=RlqSi9JEnoJR83KoiX5ons926eTuK2xmZAkSv9h2mJOTN8RKfY3MEL9UTJw4RLeIdt WTVQJcfyWO9tzQPniq+/KW1UHMwiRMvucfVNTqn1P+TvhVRH80xKJolRhppDEuLtbWsh P8H0cQuQEZmaSlmmsfZWWu95I24WdakS9WO+gwN6IrTnjeUDj5FcGbHV7z2aHoIrS8UG UZYIXzsd3chU6Za4j+984qjwymrfSM18IdTR5CML4GOhQVNE4hkBqjV5W6jM/v8QTLdS IpmWXwx7IR9DJRthCWEL7UcqY3OTES91wbncFQOO1KvFjMmSMFZTAsWsdf8PNd5qNCxD OgDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767939284; x=1768544084; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/O/Eq2DaBroAxHgsa1v0NiIqCw4CsEf3jankMI7XtDI=; b=F1E2GB/EBrupcqdkbQtYPH4aINoQqYnTU/NTwhs9LlfX9BYTUDIipYb2wM5gzhisl0 GdH4F+8TTbq1DrH+DgKPXFV4NfLBnGD1s4ihf4Gh6aK/A6umdtCLtlZj1QlA3ozPG4yP xmmslhJK0ckdUkag2EBMDmOFttnUgJKLsje7znV+8qSP/cqWN4cP98zapQPOEsdSTsnG 2SMeOS2bRLBbxelAzTyTS45ey9AbAbUVtJMG9F+qW6e5WLOQafT4htlMFf0xfIClmxUG xzGn776bHB+H8DFaRFMqmcsTw8Vbwb2PGB/7Qjy3KGbzZ69y6PuSIvWhffFqc44cPZpD 3bLw== X-Forwarded-Encrypted: i=1; AJvYcCWDWF6R9xfhLfm2S6qS8sArQf0brWPmb1TIbw43AGS3GiM26y2UQBVSxuEw2nU/9IIRSrxLui8Wl4L3FbA=@vger.kernel.org X-Gm-Message-State: AOJu0YxftPVb6C/M32M3aSk4RuzLYL4w4opCOMmOju9CsKgc4J+u3w9J iKWMS7/Tx++WWjNKgrcfWW8rfcSvLEhqRTS6/Pe/yo5U0cSdsKhp5VrFpvo5MfbD3aI= X-Gm-Gg: AY/fxX6sjATLBACZlzVHNN+9tyaem1X13GJ23WFyupBhMSIVJ/Y197dni60p+9DY1Cb zfZCa+vOa3/7RDEsMWfrlcXUSkLx1K76q/566k1TwhBMVLEagjJuo1zHiE3cLO+avwbYR0WD42E ZpQYXSscr0LKYotCWBizweWg9Ro7PsJG3mkv195G4DRm03ZujMkevIVHAW9Ugz7XARrkS8TiLV2 hDzyKmx5YivcJWJ8SSmcBzWFi7IPU7+nLsXFQrmhVj7Diz9bs+kxwJXyWN+tbONa8ZQxRJLLOSb KL/uK10EH6T56hyM/NrWxjUyWeoAF8FwskLSb1DBBr4SUitXmHhjhEsohx4vZ1Pab6P6zh/z9DX MMbtZOvpitZoAvQh9G8u0Qn9tbdw23nBnav4S0OG+JF9I6QVLXIQZ07OfvlwI/TPevWKstjOpW3 peahuREg4PDi/krajN X-Google-Smtp-Source: AGHT+IEBbn7jf3NOZrQrn9TgtiAQQTD6UVcOylSPHCZVWqMEvKJLOUdWlv+HLP63NALGjSxFuvQ0+w== X-Received: by 2002:a05:6000:310d:b0:431:7a0:dbc3 with SMTP id ffacd0b85a97d-432c37983eamr10259558f8f.29.1767939283781; Thu, 08 Jan 2026 22:14:43 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432d9610671sm2321918f8f.34.2026.01.08.22.14.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 22:14:43 -0800 (PST) Date: Fri, 9 Jan 2026 09:14:40 +0300 From: Dan Carpenter To: Samasth Norway Ananda Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] staging: rtl8723bs: fix firmware memory leak on error Message-ID: References: <20260108181612.2340796-1-samasth.norway.ananda@oracle.com> <20260108181612.2340796-2-samasth.norway.ananda@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260108181612.2340796-2-samasth.norway.ananda@oracle.com> On Thu, Jan 08, 2026 at 10:16:09AM -0800, Samasth Norway Ananda wrote: > After successfully calling request_firmware(), if the firmware size > check fails or if kmemdup() fails, the code jumps to the exit label > without calling release_firmware(), causing a memory leak. Call > release_firmware() directly in each error path before jumping to cleanup > label. > > Signed-off-by: Samasth Norway Ananda Reviewed-by: Dan Carpenter regards, dan carpenter