From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f177.google.com (mail-vk1-f177.google.com [209.85.221.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6233D1CAB3 for ; Fri, 9 Jan 2026 12:42:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767962566; cv=none; b=V3IatZk86mYc74i4wSiDX54QKIJpWM/M76fJ/2vT/K5WtWksMpUuEevZG0Jup6qHq2bftZFqSM+nzSYP6UPxmFQ4fCZYGpUcVv0DbiPdRRAQ+Y5UHcSd066UcN7nAxz5m8b/EUYjkrKGqKoF3rbG9m5/XId6h7n06aSYlou3ZT0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767962566; c=relaxed/simple; bh=hZSgLFwm7iWTSCEMlGpJ5EydF3r4Fok2bDOlepHZ5R0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DUnwskXkvbcMBtL1CtbDKwMX0xzxuDw/aQefyV32ZovnLOMUQlobh97RtfKIfFdT5F2ul/y1k8NCzwit4JOTCleukhbogsJBd8FVP0VMXb1O5mIs2oxnU/gVkwZD++iK8C+puObsT9GjG7zojxiVUg9ZNZZ10lp13qJRolHfqsI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a76hO02m; arc=none smtp.client-ip=209.85.221.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a76hO02m" Received: by mail-vk1-f177.google.com with SMTP id 71dfb90a1353d-5636274b362so363940e0c.2 for ; Fri, 09 Jan 2026 04:42:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767962564; x=1768567364; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=K3BFu0vu0/p35NSB3GE3KTVvm2WkoyhJD5SPOf/SaeU=; b=a76hO02m2zyU0nn+/0WvJf0A//MgSy24ecK2vgzKwg/rNsXQzflpXEZMsk+Le0Xts+ 4ei0oXO/MFJG2OzzezPNGz/6+omGmJQ2YYhtRhDOPHpL2csC31xZWDHWf9ClJv117tSE XZ/n9btjige4iDkfmSLcQWYNOR2pBEarYILOOyzRAZhFNRpteCOF52Ti4mpPP4c4z3RF uCTqru6EWkTuyr5qLp6vxVk7ucxz/qhwujUp2g+xIm5AnIBSDsTArBZmn3XcW5kuSEZE /kzYpREkr+bCZ5OKKIkmaMfWTmhv2xI7lzeHl7+1FWmyR3NokEaw8NlnNzM0Ritt4hu0 SviQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767962564; x=1768567364; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K3BFu0vu0/p35NSB3GE3KTVvm2WkoyhJD5SPOf/SaeU=; b=TUUHJT7230iP87TWk8hmZOdAEZpg9eIOYUMLVx6pR/uiJLA0vuGAo1hZ+3sper/yj0 XSocWG/CuH4wtgTZJr+2fn57lxdQkEKP6bp+VbhJ5PDJ0P9UL4O8NSsogArvo/7Ouq6h NWFx6e1WX9Tujbl12HipcNmDaYK7CKqb3Ms0rGOIISGpYpusAPRHzjoC3Iaq9UDeRX07 rCGf2J7K3T5hE22doEUh0m1VLoPSAW/W79kaW7TBRLQgPXCIUo7faDeIxZPM/JESFnrF Cq45QVFmj9lSFAA15vjD5CxMl/GkaCibyQMdRk8+z0evEQZ2pRj+aIqjDVDUwX2/dIrk B3qw== X-Forwarded-Encrypted: i=1; AJvYcCWA1jrnWzpGa2cBsBXKCdjC4mWX25dTm3q2dT+CGbwQv9BIHkIce++LFgQ/5/JyZuLYDRZLVSaH73r5+vM=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7VtpKF4u7HHIJVsui7jvRbDkfZuMQx9wX6mWaeElBvnj/3qSz LnUnCxpccPWHcW18VcLG+BhknNBcRpJaKuoYGl2JMJQcDrHylHCjHypr X-Gm-Gg: AY/fxX6GJUGxI3S5gyC0HVf2koHPIhIyylJl7cu8Qw8NKvgJVFSfWRITTYtI05WkTt4 Ae8LToFhXLP5+TsN7u6dj8XPmPQcnx2OkrhSTCS9TUu5Oe+ZKbkWFnD+nw8byNM6LOXCyF81mCH 9lL7+x2OVJCAht14MQL95m4VdTRNeZP5nQlA7mr7GgA8We2KVwjYwssKFf/RrlpaNS+xtRa3Bo1 wuPA5jAp43xwxSn+teztkQMEPTR1ORqUehbTeV1quvPnFiH3dCJgEJZyEuVUiWhuJo93EpSIqS6 r2gjBsEKEH2BEx4oSfWxL5nkEk5AEVli/Ountmfqt9WsWGuhktpNT+R00fwPRZTHUWYmJQ47+L/ oSlukLl55l1W0wHKe+3nLMw404Sa5hGBeNJhS7Sab0qL8CGmTcaHIMv/Gd3XY3RXH5B8+QxuKid 5UqSQvcpuOWE2MsoaaurA= X-Google-Smtp-Source: AGHT+IEFwkm7ZUOXNxPhCYhh26Dl1VpJaAPxMviOBBIXzleuSNVqOAzV6ATr3WWYBcee7gd8DzSzGw== X-Received: by 2002:a05:6102:50ac:b0:5ee:a184:35c8 with SMTP id ada2fe7eead31-5eea1843ad8mr1950120137.30.1767962562741; Fri, 09 Jan 2026 04:42:42 -0800 (PST) Received: from localhost ([2804:30c:2766:a500:b70:8c42:f792:bef6]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-944124c452asm8625479241.13.2026.01.09.04.42.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jan 2026 04:42:41 -0800 (PST) Date: Fri, 9 Jan 2026 09:44:28 -0300 From: Marcelo Schmitt To: Janani Sunil Cc: Lars-Peter Clausen , Michael Hennerich , Alexandru Ardelean , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Corbet , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, jan.sun97@gmail.com Subject: Re: [PATCH v2 1/2] dt-bindings: iio: dac: Add max22007 Message-ID: References: <20260108-max22007-dev-v2-0-2506c738784f@analog.com> <20260108-max22007-dev-v2-1-2506c738784f@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260108-max22007-dev-v2-1-2506c738784f@analog.com> Hi Janani, One extra comment in addition to Krzysztof's. On 01/08, Janani Sunil wrote: > Devicetree bindings for MAX22007 4-channel 12-bit DAC that drives a > voltage or current output on each channel > > Signed-off-by: Janani Sunil > --- ... > + > +patternProperties: > + "^channel@[0-3]$": > + $ref: /schemas/iio/dac/dac.yaml# > + type: object > + description: > + Represents the external channels which are connected to the DAC. > + > + properties: > + reg: > + description: Channel number > + items: > + minimum: 0 > + maximum: 3 > + > + adi,ch-func: > + description: > + Channel output type. Use CH_FUNC_VOLTAGE_OUTPUT for voltage > + output or CH_FUNC_CURRENT_OUTPUT for current output. > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [1, 2] adi,ad74413r.yaml has many possibilities for the channel output type. max22007 is only either voltage or current. Can't we do this with output-range-microamp and output-range-microvolt from dac.yaml? Figure out the channel type from the output-range- property? > + > + required: > + - reg > + - adi,ch-func > + > + unevaluatedProperties: false With best regards, Marcelo