From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B616359F86 for ; Fri, 9 Jan 2026 11:48:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767959311; cv=none; b=XBNtP14cxj1J8pMurloSlzTG3Atv/TJAzj04hNkv0X6z6Q6jFm0zAg1wiSfuvgF7159ht68sKzlZiAYL7tvABOa4c3xxOP7ZenAz7cWPS+J4G7KAO59NjDVGOHIONnZCTBkNC6D5IaALXhJnA0fLpRRU+CApWgNjMLLNLSPiEys= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767959311; c=relaxed/simple; bh=yRyDLcAqiH6pZmNzsm5pfgCigsvRKT+X/T+uMrJY6AU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=G56TfqChwZ9ef04X/g9wydxRyeZIi3Dkr7kdNcpPnfKHBZHvJJDFl4qSbwN0qSMwYfCwK2kIKUtMIXUx04Z0z1S155fu+Y4QHI/EccYzx2Z6Uk2wmF9xtF7J53Ur9NkZbG2l3zJK0FvIUkeX4afoiKTalkqSmtP9EGC8bBGmkvQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ofyuVSZk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ofyuVSZk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E32CEC19421; Fri, 9 Jan 2026 11:48:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767959310; bh=yRyDLcAqiH6pZmNzsm5pfgCigsvRKT+X/T+uMrJY6AU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ofyuVSZk/CcVrcVS321Sfk7f3ACBCKWVY8NzKZEew7QcRiVWnkMmVgWmj23qM9gyh COZwra0uQ1kI+fGH3tkh3djotKc6SahD+jsdVaW+qyDY3HWmmWhM5eEITVpj4t/ijW LImXAco9YjROXp04kZd2SBpaIf40oA88nAAwBvm0GTkEKjeIc2SRIDY/48BISFkaJl R6hbhC3MmYa0RSBwu+nnu3pX/kGgkm/LiDu+LaaRZAWlqtGlQKS/RWyGfCoiqalzQl J5jpy7MGFwbCG0tbVACeWzJ/EMLvQGKSOkpKR9pqcp0oF8PtPvCpj8TSvcomH7f9B0 4n2Tk+ojX7xgQ== Date: Fri, 9 Jan 2026 17:18:24 +0530 From: Sumit Garg To: Aristo Chen Cc: linux-kernel@vger.kernel.org, jens.wiklander@linaro.org, op-tee@lists.trustedfirmware.org, harshal.dev@oss.qualcomm.com, mario.limonciello@amd.com, Rijo-john.Thomas@amd.com, amirreza.zarrabi@oss.qualcomm.com, Aristo Chen Subject: Re: [PATCH v6 1/2] tee: add revision sysfs attribute Message-ID: References: <20260107152607.902735-1-aristo.chen@canonical.com> <20260108064517.13854-1-aristo.chen@canonical.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260108064517.13854-1-aristo.chen@canonical.com> On Thu, Jan 08, 2026 at 02:45:08PM +0800, Aristo Chen wrote: > Add a generic TEE revision sysfs attribute backed by a new > optional get_tee_revision() callback. The revision string is > diagnostic-only and must not be used to infer feature support. > > Signed-off-by: Aristo Chen > --- > Documentation/ABI/testing/sysfs-class-tee | 10 +++++ > drivers/tee/tee_core.c | 51 ++++++++++++++++++++++- > include/linux/tee_core.h | 9 ++++ > 3 files changed, 69 insertions(+), 1 deletion(-) Reviewed-by: Sumit Garg -Sumit > > diff --git a/Documentation/ABI/testing/sysfs-class-tee b/Documentation/ABI/testing/sysfs-class-tee > index c9144d16003e..1a0a3050aaa9 100644 > --- a/Documentation/ABI/testing/sysfs-class-tee > +++ b/Documentation/ABI/testing/sysfs-class-tee > @@ -13,3 +13,13 @@ Description: > space if the variable is absent. The primary purpose > of this variable is to let systemd know whether > tee-supplicant is needed in the early boot with initramfs. > + > +What: /sys/class/tee/tee{,priv}X/revision > +Date: Jan 2026 > +KernelVersion: 6.19 > +Contact: op-tee@lists.trustedfirmware.org > +Description: > + Read-only revision string reported by the TEE driver. This is > + for diagnostics only and must not be used to infer feature > + support. Use TEE_IOC_VERSION for capability and compatibility > + checks. > diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.c > index d65d47cc154e..0a00499811c1 100644 > --- a/drivers/tee/tee_core.c > +++ b/drivers/tee/tee_core.c > @@ -1146,7 +1146,56 @@ static struct attribute *tee_dev_attrs[] = { > NULL > }; > > -ATTRIBUTE_GROUPS(tee_dev); > +static const struct attribute_group tee_dev_group = { > + .attrs = tee_dev_attrs, > +}; > + > +static ssize_t revision_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct tee_device *teedev = container_of(dev, struct tee_device, dev); > + char version[TEE_REVISION_STR_SIZE]; > + int ret; > + > + if (!teedev->desc->ops->get_tee_revision) > + return -ENODEV; > + > + ret = teedev->desc->ops->get_tee_revision(teedev, version, > + sizeof(version)); > + if (ret) > + return ret; > + > + return sysfs_emit(buf, "%s\n", version); > +} > +static DEVICE_ATTR_RO(revision); > + > +static struct attribute *tee_revision_attrs[] = { > + &dev_attr_revision.attr, > + NULL > +}; > + > +static umode_t tee_revision_attr_is_visible(struct kobject *kobj, > + struct attribute *attr, int n) > +{ > + struct device *dev = kobj_to_dev(kobj); > + struct tee_device *teedev = container_of(dev, struct tee_device, dev); > + > + if (teedev->desc->ops->get_tee_revision) > + return attr->mode; > + > + return 0; > +} > + > +static const struct attribute_group tee_revision_group = { > + .attrs = tee_revision_attrs, > + .is_visible = tee_revision_attr_is_visible, > +}; > + > +static const struct attribute_group *tee_dev_groups[] = { > + &tee_dev_group, > + &tee_revision_group, > + NULL > +}; > > static const struct class tee_class = { > .name = "tee", > diff --git a/include/linux/tee_core.h b/include/linux/tee_core.h > index 1f3e5dad6d0d..ee5f0bd41f43 100644 > --- a/include/linux/tee_core.h > +++ b/include/linux/tee_core.h > @@ -76,6 +76,9 @@ struct tee_device { > /** > * struct tee_driver_ops - driver operations vtable > * @get_version: returns version of driver > + * @get_tee_revision: returns revision string (diagnostic only); > + * do not infer feature support from this, use > + * TEE_IOC_VERSION instead > * @open: called for a context when the device file is opened > * @close_context: called when the device file is closed > * @release: called to release the context > @@ -95,9 +98,12 @@ struct tee_device { > * client closes the device file, even if there are existing references to the > * context. The TEE driver can use @close_context to start cleaning up. > */ > + > struct tee_driver_ops { > void (*get_version)(struct tee_device *teedev, > struct tee_ioctl_version_data *vers); > + int (*get_tee_revision)(struct tee_device *teedev, > + char *buf, size_t len); > int (*open)(struct tee_context *ctx); > void (*close_context)(struct tee_context *ctx); > void (*release)(struct tee_context *ctx); > @@ -123,6 +129,9 @@ struct tee_driver_ops { > int (*shm_unregister)(struct tee_context *ctx, struct tee_shm *shm); > }; > > +/* Size for TEE revision string buffer used by get_tee_revision(). */ > +#define TEE_REVISION_STR_SIZE 128 > + > /** > * struct tee_desc - Describes the TEE driver to the subsystem > * @name: name of driver > -- > 2.43.0 >