Hi, On Thu, Jan 08, 2026 at 12:25:12PM +0530, Anand Moon wrote: > Thanks for your review comments. > On Sat, 3 Jan 2026 at 19:35, Sebastian Reichel wrote: > > On Sat, Jan 03, 2026 at 02:01:18PM +0530, Anand Moon wrote: > > > The USB host USB2 and USB3 on the Rock 5B, 5BP, and 5T is powered by the > > > USB_HOST_PWREN_H gpio pin which is used to enable vcc5v0_host host > > > regulator which ensures proper power sequencing and management for onboard > > > Double-USB-HOST. > > > > > > Update the u2phy2_host node to reference the correct phy-supply. > > > > > > Cc: Sebastian Reichel > > > Signed-off-by: Anand Moon > > > --- > > > > u2phy2_host is connected to an onboard USB hub chip, which is > > powered by &vcc5v0_sys as the comment says. > > > > You can see this on page 9 of the v1.45 ROCK 5B schematics (page > > name USB2HUB). The usb hub chip uses VCC5V0_SYS + VCC_3V3_S0 and is > > connected to USB20_HOST0_DP, USB20_HOST0_DM. The related USB > > controller for that in the upstream DT is &usb_host0_ehci, which > > in turn is using &u2phy2_host. Thus at least for the ROCK 5B the > > existing DT is correct. Properly describing the downstream port > > VBUS regulator would require something like the following series: > > > > https://lore.kernel.org/all/20250911-v6-16-topic-usb-onboard-dev-v4-0-1af288125d74@pengutronix.de/ > > > Actually, the Radxa Rock 5 B doesn't have an onboard USB hub chip. Seriously? I provided the exact page for the hub chip in the schematics and it's easily visisble in lsusb too. I don't want to waste my time and expect a certain level of quality and this is certainly way below it... -- Sebastian