From: yuanjiey <yuanjie.yang@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: robin.clark@oss.qualcomm.com, lumag@kernel.org,
jesszhan0024@gmail.com, sean@poorly.run,
marijn.suijten@somainline.org, airlied@gmail.com,
simona@ffwll.ch, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, tzimmermann@suse.de, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
neil.armstrong@linaro.org, konrad.dybcio@oss.qualcomm.com,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, tingwei.zhang@oss.qualcomm.com,
aiqun.yu@oss.qualcomm.com, yongxing.mou@oss.qualcomm.com
Subject: Re: [PATCH v5 10/12] drm/msm/dpu: Add Kaanapali SSPP sub-block support
Date: Mon, 12 Jan 2026 13:51:46 +0800 [thread overview]
Message-ID: <aWSL8gAJllBMnA5S@yuanjiey.ap.qualcomm.com> (raw)
In-Reply-To: <bqwfbvjq7lmuz6ggrtcsq3hvxrvtfznxrt3l4cjr7lwlzvmtfy@6wtnkgefkpck>
On Sun, Jan 11, 2026 at 04:19:49AM +0200, Dmitry Baryshkov wrote:
> On Fri, Jan 09, 2026 at 01:50:49PM +0800, yuanjiey wrote:
> > On Fri, Jan 09, 2026 at 05:25:26AM +0200, Dmitry Baryshkov wrote:
> > > On Fri, Jan 09, 2026 at 10:33:52AM +0800, yuanjiey wrote:
> > > > On Thu, Jan 08, 2026 at 03:46:18PM +0200, Dmitry Baryshkov wrote:
> > > > > On Thu, Jan 08, 2026 at 04:56:57PM +0800, yuanjie yang wrote:
> > > > > > From: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com>
> > > > > >
> > > > > > Add support for Kaanapali platform SSPP sub-blocks, which
> > > > > > introduce structural changes including register additions,
> > > > > > removals, and relocations. Add the new common and rectangle
> > > > > > blocks, and update register definitions and handling to
> > > > > > ensure compatibility with DPU v13.0.
> > > > > >
> > > > > > Co-developed-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
> > > > > > Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
> > > > > > Signed-off-by: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com>
> > > > > > ---
> > > > > > drivers/gpu/drm/msm/Makefile | 1 +
> > > > > > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 14 +
> > > > > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 14 +-
> > > > > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 4 +
> > > > > > .../gpu/drm/msm/disp/dpu1/dpu_hw_sspp_v13.c | 321 ++++++++++++++++++
> > > > > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.c | 18 +
> > > > > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h | 3 +
> > > > > > 7 files changed, 371 insertions(+), 4 deletions(-)
> > > > > > create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp_v13.c
> > >
> > > >
> > > > > > + c->ops.setup_sourceaddress = dpu_hw_sspp_setup_sourceaddress_v13;
> > > > > > + c->ops.setup_solidfill = dpu_hw_sspp_setup_solidfill_v13;
> > > > > > + c->ops.setup_pe = dpu_hw_sspp_setup_pe_config_v13;
> > > > > > +
> > > > >
> > > > > > /* QOS_QOS_CTRL */
> > > > > > #define QOS_QOS_CTRL_DANGER_SAFE_EN BIT(0)
> > > > > > #define QOS_QOS_CTRL_DANGER_VBLANK_MASK GENMASK(5, 4)
> > > > > > @@ -475,6 +482,17 @@ void _dpu_hw_setup_qos_lut(struct dpu_hw_blk_reg_map *c, u32 offset,
> > > > > > cfg->danger_safe_en ? QOS_QOS_CTRL_DANGER_SAFE_EN : 0);
> > > > > > }
> > > > > >
> > > > > > +void _dpu_hw_setup_qos_lut_v13(struct dpu_hw_blk_reg_map *c,
> > > > > > + const struct dpu_hw_qos_cfg *cfg)
> > > > >
> > > > > Will it be shared with other blocks (DS, WB)?
> > > >
> > > > yes, _dpu_hw_setup_qos_lut_v13 will be used in WB, in function dpu_hw_wb_setup_qos_lut_v13.
> > > >
> > > > So maybe I should drop '_' rename _dpu_hw_setup_qos_lut_v13 --> dpu_hw_setup_qos_lut_v13 ?
> > >
> > > Yes, please. As you are going to resend the series, could you please
> > > also remove the function from the header?
> >
> > Sure. But here a little confused.
> >
> > Do you mean I should delete _dpu_hw_setup_qos_lut_v13 in header,
> > Or I should rename _dpu_hw_setup_qos_lut_v13 in header to dpu_hw_setup_qos_lut_v13.
> >
> > _dpu_hw_setup_qos_lut_v13 is used in dpu_hw_sspp_v13.c and dpu_hw_wb.c, so I don't think
> > it can be removed from header.
> >
> > Could you please help me clarify this comment?
>
> Move it to dpu_hw_util.c
Yes, will do move _dpu_hw_setup_qos_lut_v13 definition to dpu_hw_util.c.
Thanks,
Yunajie
> >
> > Thanks,
> > Yuanjie
> >
> > > --
> > > With best wishes
> > > Dmitry
>
> --
> With best wishes
> Dmitry
next prev parent reply other threads:[~2026-01-12 5:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 8:56 [PATCH v5 00/12] drm/msm: Add support for Kaanapali yuanjie yang
2026-01-08 8:56 ` [PATCH v5 01/12] dt-bindings: display/msm: qcom,kaanapali-dpu: Add Kaanapali yuanjie yang
2026-01-08 8:56 ` [PATCH v5 02/12] dt-bindings: display/msm: dsi-phy-7nm: Add Kaanapali DSI PHY yuanjie yang
2026-01-08 8:56 ` [PATCH v5 03/12] dt-bindings: display/msm: dsi-controller-main: Add Kaanapali yuanjie yang
2026-01-08 8:56 ` [PATCH v5 04/12] dt-bindings: display/msm: qcom,kaanapali-mdss: " yuanjie yang
2026-01-08 8:56 ` [PATCH v5 05/12] drm/msm/mdss: Add support for Kaanapali yuanjie yang
2026-01-08 8:56 ` [PATCH v5 06/12] drm/msm/dsi/phy: " yuanjie yang
2026-01-08 8:56 ` [PATCH v5 07/12] drm/msm/dsi: " yuanjie yang
2026-01-08 8:56 ` [PATCH v5 08/12] drm/msm/dpu: Add interrupt registers for DPU 13.0.0 yuanjie yang
2026-01-08 8:56 ` [PATCH v5 09/12] drm/msm/dpu: Refactor SSPP to compatible " yuanjie yang
2026-01-08 13:43 ` Dmitry Baryshkov
2026-01-08 8:56 ` [PATCH v5 10/12] drm/msm/dpu: Add Kaanapali SSPP sub-block support yuanjie yang
2026-01-08 13:46 ` Dmitry Baryshkov
2026-01-09 2:33 ` yuanjiey
2026-01-09 3:25 ` Dmitry Baryshkov
2026-01-09 5:50 ` yuanjiey
2026-01-11 2:19 ` Dmitry Baryshkov
2026-01-12 5:51 ` yuanjiey [this message]
2026-01-08 8:56 ` [PATCH v5 11/12] drm/msm/dpu: Add Kaanapali WB support yuanjie yang
2026-01-08 13:47 ` Dmitry Baryshkov
2026-01-08 8:56 ` [PATCH v5 12/12] drm/msm/dpu: Add support for Kaanapali DPU yuanjie yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWSL8gAJllBMnA5S@yuanjiey.ap.qualcomm.com \
--to=yuanjie.yang@oss.qualcomm.com \
--cc=aiqun.yu@oss.qualcomm.com \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=tingwei.zhang@oss.qualcomm.com \
--cc=tzimmermann@suse.de \
--cc=yongxing.mou@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®