From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6E0727CB35 for ; Mon, 12 Jan 2026 10:21:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768213282; cv=none; b=LINh3u6XF3YBejlcjsC/3MSgc9pnl63MYQ3IVIB/J1E6e+YZ9SPCXFlgmeAz/quNYjKCvHGZSxHEJesLYKtnQPYkPWPONNkApvJeX9XwouW8N6q3RzdfpPGnKALNPFPrWJ2AWX16Qf7xysihQqwNMCRxp19wy9YRDBnU7u+Mnwk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768213282; c=relaxed/simple; bh=sG5RXCYW1fLvtso82Da19pP7SO/ZIuP5Gl32vYsou9U=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Gz/VDR6NElwNmyrh8bX7hvRiMq3Nvk57/phyUSIgjqoXXP3MHEa1nnB73zM7ix/y4zfA2YMzDOjTBx3f/9WFHDgnAhVlJOnXnCxCBdx1iFiyYJ6uNtN+go7PYvy7tCd/JmIoeEkM36BfBFh1vSw0IVLi9vFf8G2h3uqqfR39BCA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YMTaa9f0; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YMTaa9f0" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-59b6c13b68dso4383098e87.0 for ; Mon, 12 Jan 2026 02:21:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768213279; x=1768818079; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=MH16cCGkiKRTIwcYIk3CP93gcE4h3kBjVckxfOORWKY=; b=YMTaa9f0TDuIltrmeYU6IPkYfqmHvCxZjb90QOnP4PpbuJ0shCEF46Za1oZL0LVXdf c19QVmc5/lLkdY910/kebzZSSe0vEKw3DRJf5Ra3pE0KfxZ+UZ2qFdg4nBfxYeX0q02q 2oC9JGyUWACoQ5/v6OUCi8n/onjzP0vTbtswgFqhqcsvlZC3o/PLZzvJYvV4n+ZRhG96 SMYHFla7cHa10mFwgoqCwt45o1yxeDNbeeRO3vf54VTb1QkPCGA/earCEycCrMugzoZz kYWv3upocpQevet1W1iYEmkQbFTefOxaNul6WuulX7x6YPjNbkNv/vcS/6276WFoW05/ +jOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768213279; x=1768818079; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MH16cCGkiKRTIwcYIk3CP93gcE4h3kBjVckxfOORWKY=; b=KogJRmZGufSsIAvQPYymCY80bfPVNv0H4V3Vf3HG1k4y4QN1+vcM+tlT+D8DvWuWyf rlvGyA27JXeN24gOZd1ttGGZrm1gIWO9XfQHpvY9UzoFtwIj5/fbJ7XmiBSFo2FbkzaU dO7l07KhnbsP+hw2LfHBzGuKnurYFHgHVb7zILFyZIw2a5INNcFHNjrRL9AvmvfiN6tM QmyuLh6hr+bBBWUzDm/IZS85bnieDAXDKpDuGKwNSAOohm96hb0owg0JPRY41ybZGqIX iUXS41+3E9q75Ih+HWqOV8zluNKNtlShREiEtDQSy7It7s6mhHTfJPodRqY0HQWFHuAK dsVA== X-Forwarded-Encrypted: i=1; AJvYcCW8l3jK+7zQUkFy9BXeyPddA/NtXYyq6gHmwR4tjzo7DczOojB5YU+JGZS5nOmF7HePjTyLTpafztyLrK4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1UudtJCjbkmklkwkqUjm0zPJc1+XGtO/crSTHycQaclf+YXa2 qozG1cShDqKAvgo/S838/FI9meN9W8RCU1AuU3WyMWF9DJLVWMABVP1+WSsQCA== X-Gm-Gg: AY/fxX5xLDcQOP6fSKHcFBv9OuiavVW1PEbNf3WkqUjtI2yfGWv8EvL+8x8u44g2mwT gAc92mX5n5F7WPYmOMy0bO+ZfhunqmHBOiR8HLeKMo74u2GivvFSRFKr+3Iz1ljFOd5sPTnvf6d WNWh9sRT0bPeprf0gT1zp/ti8pjqYY9jM1fK/+Vee/2mbhDi3Gdi2cY7E3tac6lDSyD7+xUqmLM vP60JhHWKJ/WlGbpoIAXT9vojLeBHevADbvbKNn3YNiEn6EYSuTv+xWKCo0d9ZQiWQxwIK7VIs6 bYAZBa3YnNLCEK76UFqHPJHm4OAorhYUiQC14uEabJF88qx/d5bBnqAd61uzs9/cI3ycDG6/j91 flveK5JcfmTpmkVjnnUf82gkMdGqClq+d13WboeSNgkuKK89C7CO0yXg4+dnXu7GLM2wd53oeR5 zocKSVcm99tOEr8aXWa6rTBbY/BgesM5Ig3zyEopdM4d57lYxA X-Google-Smtp-Source: AGHT+IE0UtcUUd+0NPLty+/GtN4PIwioNMqlewY8nUJ0HWNNcErN36LVPtVC79QsrDnD3tS85Ukohw== X-Received: by 2002:a05:6512:118b:b0:594:2d64:bce9 with SMTP id 2adb3069b0e04-59b6eb0c486mr6660079e87.4.1768213278614; Mon, 12 Jan 2026 02:21:18 -0800 (PST) Received: from pc636 (host-95-203-18-139.mobileonline.telia.com. [95.203.18.139]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59b6e821f52sm4042503e87.29.2026.01.12.02.21.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 02:21:17 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 12 Jan 2026 11:21:15 +0100 To: Deepanshu Kartikey Cc: akpm@linux-foundation.org, urezki@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, syzbot+d8d4c31d40f868eaea30@syzkaller.appspotmail.com Subject: Re: [PATCH] mm/vmalloc: prevent RCU stalls in kasan_release_vmalloc_node Message-ID: References: <20260112084723.622910-1-kartikey406@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260112084723.622910-1-kartikey406@gmail.com> On Mon, Jan 12, 2026 at 02:17:23PM +0530, Deepanshu Kartikey wrote: > When CONFIG_PAGE_OWNER is enabled, freeing KASAN shadow pages during > vmalloc cleanup triggers expensive stack unwinding that acquires RCU > read locks. Processing a large purge_list without rescheduling can > cause the task to hold CPU for extended periods (10+ seconds), leading > to RCU stalls and potential OOM conditions. > > The issue manifests in purge_vmap_node() -> kasan_release_vmalloc_node() > where iterating through hundreds or thousands of vmap_area entries and > freeing their associated shadow pages causes: > > rcu: INFO: rcu_preempt detected stalls on CPUs/tasks: > rcu: Tasks blocked on level-0 rcu_node (CPUs 0-1): P6229/1:b..l > ... > task:kworker/0:17 state:R running task stack:28840 pid:6229 > ... > kasan_release_vmalloc_node+0x1ba/0xad0 mm/vmalloc.c:2299 > purge_vmap_node+0x1ba/0xad0 mm/vmalloc.c:2299 > > Each call to kasan_release_vmalloc() can free many pages, and with > page_owner tracking, each free triggers save_stack() which performs > stack unwinding under RCU read lock. Without yielding, this creates > an unbounded RCU critical section. > > Add periodic cond_resched() calls within the loop to allow: > - RCU grace periods to complete > - Other tasks to run > - Scheduler to preempt when needed > > The fix uses need_resched() for immediate response under load, with > a batch count of 32 as a guaranteed upper bound to prevent worst-case > stalls even under light load. > > Reported-by: syzbot+d8d4c31d40f868eaea30@syzkaller.appspotmail.com > Closes: https://syzkaller.appspot.com/bug?extid=d8d4c31d40f868eaea30 > Signed-off-by: Deepanshu Kartikey > --- > mm/vmalloc.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 41dd01e8430c..a9161007cf02 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2273,6 +2273,7 @@ kasan_release_vmalloc_node(struct vmap_node *vn) > { > struct vmap_area *va; > unsigned long start, end; > + unsigned int batch_count = 0; > > start = list_first_entry(&vn->purge_list, struct vmap_area, list)->va_start; > end = list_last_entry(&vn->purge_list, struct vmap_area, list)->va_end; > @@ -2282,6 +2283,11 @@ kasan_release_vmalloc_node(struct vmap_node *vn) > kasan_release_vmalloc(va->va_start, va->va_end, > va->va_start, va->va_end, > KASAN_VMALLOC_PAGE_RANGE); > + > + if (need_resched() || (++batch_count >= 32)) { > + cond_resched(); > + batch_count = 0; > + } > } > > kasan_release_vmalloc(start, end, start, end, KASAN_VMALLOC_TLB_FLUSH); > -- > 2.43.0 > Introduce a macro to represent an upper-bound? Thanks! -- Uladzislau Rezki