From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0CB736BCFE for ; Mon, 12 Jan 2026 16:49:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768236559; cv=none; b=U1xzK+yrPhuI6sS8nWIJ0x/c3x/BR0rvXTUtTeC9CK0Y6sNRRV8JQMK82obOHDjAMnKSDBYd8zj6g/qdNNAxfZOgwXkvG6uqk//R7WAX5T56mOE+yMrWvOLoksUKB0/+YjQ3Zx6Y6xs+AZiZWmV2H1q9LzGlvJgVPcDJUqkMxoc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768236559; c=relaxed/simple; bh=rSpDYYDAlrC2qkyCkQQP9wvtpup8H0/216lHMC+q/jI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XYX7v5JG5k5uNQs+HNIBIbULMrdrrqgvcTC5hCG3VV9gW8+zONZC7P886RI82aqRTzdGjhh8eQ6og1uCKQUDaJc+lYblFy90tXQs5lWcSV5yzLW0DY5Xl7xV5HEYDycABd9qS50A77hdvqGVix7758+6AzgHAN4ZVuU4YNtLMvs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Szm5PKEn; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=YgZOeLUd; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Szm5PKEn"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="YgZOeLUd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768236555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7/pAFr0/aoSxJfBcAQjHBP8K9Jsu2l/1rwtc+O6U0sw=; b=Szm5PKEnSgK/1A1x4MgEkrjp5xVj2jLdhw544f7PQ3BgDdmIAVNhsR1H3fVcKcpWOH33jh F0GWap6wnY8ProauA+nW2dINvjJAEWuxNta1nA36t7WDdAJK5YEhJSj7TjG54Ft7AAqS6R mgyxZBRIgYGaMWz3B4EMiVe4LxEDHLs= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-246-VpN58ZCvPfC2vr1AUYC13A-1; Mon, 12 Jan 2026 11:49:13 -0500 X-MC-Unique: VpN58ZCvPfC2vr1AUYC13A-1 X-Mimecast-MFC-AGG-ID: VpN58ZCvPfC2vr1AUYC13A_1768236552 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4779edba8f3so52372585e9.3 for ; Mon, 12 Jan 2026 08:49:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768236551; x=1768841351; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7/pAFr0/aoSxJfBcAQjHBP8K9Jsu2l/1rwtc+O6U0sw=; b=YgZOeLUdV3qfhMEqiDu8okLFTjc37c9d2amQ6hvc5TtmHWm3IiRKtiQK4IrQubkGut NwIlHPOFDekx8lrt6c1oi4Y1bKjlgKifpA/mvUGdWgwzyKVgFXMXspmdMFiJw7m963uy lApWF1okdig11IInab5cMoSAM0YJqi52Tw/cn6sSvdMFxGXkqm5QMNXWLQftVnyjrPgO olvE17ccMfcmuEaDXUY22A4gNp7SlPr0mCM0LyH56SzTJOC1LpH9LscZPKmtM0UXMssT cOK063RbiSTO7CI0HnyCki3HWLZ03EOH/cfmEIqkuUfmeV1s+6lEjHgLWthXUpPVvr8P w4+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768236551; x=1768841351; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7/pAFr0/aoSxJfBcAQjHBP8K9Jsu2l/1rwtc+O6U0sw=; b=WH+hZd4PrsdeXycifLRT6S6nkwMZ0/SNIjhq1DLX3o4H/mccKGQmCdugZsksLbqvQZ yvFvKhxKbewxLxdQTu8olV31xhz1L0ryys99IQjG8ql8dtXUC+KgW5lvxaNJ37CKrgj3 YEHZhtnz5FgE+M7xYHMeUx3Kf6pssGeHBFKX+AC8Wbtun3qcj4T+TCc/LSb7il8HW7Fs REs0LQ81A8LQhikjbElG9uDfiTi351FkP/dDH4h5VnAJ8dyvY++Yd/amwP6bDMB9N1f5 nOxhYdKCjY1rn52uQgZm29vhL+y5OOlgnLjE/o9m9H9yC8T0tTYiVbwWpYfXQD++YnOP k/Ng== X-Forwarded-Encrypted: i=1; AJvYcCVm9dMp8+NtNtlKmYh6zeZb3HmJhLovd/sVkXweBV5laxgw/iwCJVfIJ3pnaEixEON9hvAPfhCrNqK3XsQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyZqWfDuBnFQi3L+6P/8AZgiSKwu6tWPU6lQ9/YTPW58tmGQjAL uGkGu0TE16LCLFe17kqvD6wqHMj/ja6u0fyhseiRPM1iBQeaGSiqVgJV+F6MAZTPc5IO23/LJ1b ya7qNDA8z2MXZGbebFqMBfTwEHE8bjaRRNW9fSLw3XuLCgEOx4wNTpBXtHIT9DueiOg== X-Gm-Gg: AY/fxX72wA7Yob7BWLAEY+kHsQdIASRlF54yyiDaq/Aw5H54Ieq1Fu/iEglj8wfuFJu qF4Ei0zQH8q5O7MDWX8t9XfKNOaSnk0/JA0bjcRwK6WQUqQ625qLq6CeAiUDl9bI7QjTCiJzT5A UK1che2Q8OOkRfN3gsoNXvqM1J5ubOyx+B+2RzNErffsp1p6F5meB78l/4Kj4yz8UUzHWlPY37F Y0TJQ9evnv4RJZ7wwzg+IAaZoqRuiIbXQMZov9SVgayYWF0s37jwcklMfU6IOwk3KoVjDhivwfn fnSoEvtedqUS/ID31D4964Wwqquy6BIOYnbbqnZGwaiV4UG8WqTI5yG4Ww/Q59xDj0Z7L/DFA0S lywNx6dqPBP5xh8SPza/z9o4Ho83BuYt9PqQhZ23ng7duyFoQ3ecpe+pZxdUtiQ== X-Received: by 2002:a05:600c:1991:b0:477:55c9:c3ea with SMTP id 5b1f17b1804b1-47d84b40aa4mr239691905e9.35.1768236550745; Mon, 12 Jan 2026 08:49:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IGbfHpDO7Px43Be+w7n1YsI5iuj6cCFBAlIOAFZDgERsn4SYfumZjikc9aia43Emr8rvTaF4g== X-Received: by 2002:a05:600c:1991:b0:477:55c9:c3ea with SMTP id 5b1f17b1804b1-47d84b40aa4mr239691475e9.35.1768236550199; Mon, 12 Jan 2026 08:49:10 -0800 (PST) Received: from sgarzare-redhat (host-87-12-25-233.business.telecomitalia.it. [87.12.25.233]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d8718b1a6sm133003075e9.13.2026.01.12.08.49.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 08:49:09 -0800 (PST) Date: Mon, 12 Jan 2026 17:48:56 +0100 From: Stefano Garzarella To: Michal Luczaj Cc: "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?utf-8?B?UMOpcmV6?= , Stefan Hajnoczi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Arseniy Krasnov , kvm@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] vsock/test: Add test for a linear and non-linear skb getting coalesced Message-ID: References: <20260108-vsock-recv-coalescence-v1-0-26f97bb9a99b@rbox.co> <20260108-vsock-recv-coalescence-v1-2-26f97bb9a99b@rbox.co> <76ca0c9f-dcda-4a53-ac1f-c5c28d1ecf44@rbox.co> <080d7ae8-e184-4af8-bd72-765bb30b63a5@rbox.co> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <080d7ae8-e184-4af8-bd72-765bb30b63a5@rbox.co> On Mon, Jan 12, 2026 at 04:52:02PM +0100, Michal Luczaj wrote: >On 1/12/26 14:44, Stefano Garzarella wrote: >> On Sun, Jan 11, 2026 at 11:59:54AM +0100, Michal Luczaj wrote: >>>>> diff --git a/tools/testing/vsock/vsock_test.c b/tools/testing/vsock/vsock_test.c >>>>> index bbe3723babdc..21c8616100f1 100644 >>>>> --- a/tools/testing/vsock/vsock_test.c >>>>> +++ b/tools/testing/vsock/vsock_test.c >>>>> @@ -2403,6 +2403,11 @@ static struct test_case test_cases[] = { >>>>> .run_client = test_stream_accepted_setsockopt_client, >>>>> .run_server = test_stream_accepted_setsockopt_server, >>>>> }, >>>>> + { >>>>> + .name = "SOCK_STREAM MSG_ZEROCOPY coalescence corruption", >>>> >>>> This is essentially a regression test for virtio transport, so I'd add >>>> virtio in the test name. >>> >>> Isn't virtio transport unaffected? It's about loopback transport (that >>> shares common code with virtio transport). >> >> Why virtio transport is not affected? > >With the usual caveat that I may be completely missing something, aren't >all virtio-transport's rx skbs linear? See virtio_vsock_alloc_linear_skb() >in virtio_vsock_rx_fill(). > True, but what about drivers/vhost/vsock.c ? IIUC in vhost_vsock_handle_tx_kick() we call vhost_vsock_alloc_skb(), that calls virtio_vsock_alloc_skb() and pass that skb to virtio_transport_recv_pkt(). So, it's also affected right? BTW in general we consider loopback as one of virtio devices since it really shares with them most of the code. That said, now I'm thinking more about Fixes tag. Before commit 6693731487a8 ("vsock/virtio: Allocate nonlinear SKBs for handling large transmit buffers") was that a real issue? Thanks, Stefano