From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 899192836BE for ; Mon, 12 Jan 2026 23:08:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768259313; cv=none; b=bC3tFW18Foi8zsA1OIR8jjpGN2BEmz/JDmfTCSwQ2QHOSt+ouISfzBTKL7C0tbSuGgN8mdEyvW0/AM4pUQ06b/Y4oyZRCwgasmepFPfzhgqu3eFyjGfcx1N3tvb+BGTKrR9ICJx8VWOHegJr9wT+ZpTNaZVn9ZGX6eBnvq6uljs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768259313; c=relaxed/simple; bh=E1uWqE0I0piZ8iWS+np5pHiZdSplMSLCxJDU4lgZ/o8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Z78jGb2vIn2J1fDBPRY91QeCm8bgthoGWGhx6Wa389RPNmh5qTCk6+I4sKRW93SOfMt8jY7MhUx21ISA15jOeJl72SWJqxV3aB7uoiGQjnx0Trg5QcHkO2yQf2WLce4ixM2PbCemNddN429S2MLmcsm636LIXwi63gwCgJx2rjw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=qiyROcwK; arc=none smtp.client-ip=209.85.160.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="qiyROcwK" Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-4eda26a04bfso84242461cf.2 for ; Mon, 12 Jan 2026 15:08:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1768259311; x=1768864111; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=K7pBY3tdoCPsY/Y8lsMhx2ZTdVpn7tnk/qSfrKh2Sf8=; b=qiyROcwK6ibPNvPcOlO3IxZ2nDKp8IYZNKOUILSEnOxis+6xwIZXdTjjj2AMxA33Gr W6w5+JnqRCF567GLtdaEDKLmm5mpIH7lcN0t5D1Nf07TFMPAK1NQckpqUo1ak3LfnSle wjOIZwONHl3dHNxtZd7Xkmgcgs7FS2W7B/ElGpnOzIxFvVoGpGTScuJ90R7thcvv9JSS oE9Ok42FxgSgBWjx/Cu/rDH7BFVwQ2QlCpPOPwOQp+L9pqSuSkjDyxaz8RKohAJd//wk Cj+vZWKWANbsUzgg1PA0NB4/nazUajbZ/NV9ltnpj7qmjce5wj+fmhWQt+XvxcwPhhfe OaQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768259311; x=1768864111; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K7pBY3tdoCPsY/Y8lsMhx2ZTdVpn7tnk/qSfrKh2Sf8=; b=B4TS+/pFA2Y2A9SpgTh6Kszi9RUBL+o2Ip6+/6f0P0Qr22C7D7qbr5E75v3+zaGfK8 61XPm9yHSlo8NfQZCvcmiqKbF5wGPe/Rp0Jx0Zi9JCozwObUyvBaN/SsGdZL/sfZG+3p gRMltEK0EGKHwcxYzDs0uvG6oGvzMS858H/Wb4kfhzlGNd6TpI9S7K8vrrrxlvRg3Voi ud0x4FIRa9lDi44EJI4x4ILPfoOTuCq9ePW4NA15M26Wp7+PIFTyAXEpNsduor5fWCMy tKtWjn65OUAumzJRA6+QbItmetFFAQGfH7K+aj3iIby9tk9tWJs8g4xTHoZ4lq7joFnR z50A== X-Forwarded-Encrypted: i=1; AJvYcCW4dGJXTki/wsTOoqwxZhbWAAGZhlsbt8s+g3gqjIlcyjaRPZUbTedZTg1tXz38H9FoPvSdxZWgQABHEDA=@vger.kernel.org X-Gm-Message-State: AOJu0YzdSzChbnNrcUxzqtxOrz/aXQ83/QhSUJKLLFcfcb36f629aVtO Qy1YA+cAxM8PvXpcpqeF+3QQV1+H1KexdY4NS+rjxsXEVSvIM47mB69KLVntT5rBcio= X-Gm-Gg: AY/fxX7gCcDlROCPEeaY5RxIQdacKajrMozfNiVDELYALF8d/zrHf01uU7xO2RYzfuB tBDel+3AI0SkLUi46r0+Av2rgWAYD49/wh9qGWZhhyUERrTbIuK03plVhsLp8P2gc5hKNM8TGJX Z88s072pfdE6SLOtb53FHdgT9ttp1rOLXre6vu4zIqw3PcW6zx62ME0R5evmqa8ZndJcxAVgT4t nZhTdjgJTMPe98irb7SkJAWM3BdDrWU85+nNmOchVndgk5vp7mBbKK4JzczVrydiTjzMceDsLtn XDy6PKK5TsLk1aFPhV/JRv18bH0yUXL6BJLZnlempPbo+irOJ5froW16rxG1Nhz9Ur53m1NuNfo hng2zHBBx/IPT2mTPEhLv7S3ZXQy0vF3lVnxXBH7qgjVWOuvwo1rL0vDYWCAzzyW8PPNF2iZhMW N+C3dHpIaqNAWGWpbXL2D2KDSy4WLfdBusUVfKt9I/gM2fjMGwvQRdigWGhvqqdVnPpBB48/YxE IaDCE6q X-Google-Smtp-Source: AGHT+IFdGc6Mg2NLuWw8k6tdvzIclIeZLr8fIMB/We8FpiyeJTcC7asLjb3Pr3ApzSo8xGy0+HaRsQ== X-Received: by 2002:ac8:5a93:0:b0:4ee:4656:54f6 with SMTP id d75a77b69052e-4ffb4aee2c0mr263870871cf.84.1768259311529; Mon, 12 Jan 2026 15:08:31 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-96-255-20-138.washdc.ftas.verizon.net. [96.255.20.138]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-890770e2a8fsm144992886d6.16.2026.01.12.15.08.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 15:08:31 -0800 (PST) Date: Mon, 12 Jan 2026 18:07:58 -0500 From: Gregory Price To: "Cheatham, Benjamin" Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, dan.j.williams@intel.com Subject: Re: [PATCH 5/6] cxl: add CXL_REGION_SYSRAM_DEFAULT_* build options Message-ID: References: <20260112163514.2551809-1-gourry@gourry.net> <20260112163514.2551809-6-gourry@gourry.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jan 12, 2026 at 03:11:00PM -0600, Cheatham, Benjamin wrote: > On 1/12/2026 10:35 AM, Gregory Price wrote: > > DEFAULT_OFFLINE: Blocks will be offline after being created. > > DEFAULT_ONLINE: Blocks will be onlined in ZONE_MOVABLE > > DEFAULT_ONLINE_NORMAL: Blocks will be onliend in ZONE_NORMAL. > > > > This prevents users from having to use the MHP auto-online build config, > > which may cause misbehaviors with other devices hotplugging memory. > > Isn't the MHP auto-online build config still used in some flows? A quick note on > when that option will still be used would be nice. It's definitely still in use, and in fact we use it to manage many systems with BIOS configured decoders. That option super-cedes this option, which... is probably problematic, and David might want to chime in on whether improving the hotplug+online pattern to include the intended zone should dictate its removal. ~Gregory > > +static int cxl_sysram_offline_memory(struct range *range) > > +{ > > + int offline_rc = 0; > > + int rc; > > + > > + rc = walk_memory_blocks(range->start, range_len(range), > > + &offline_rc, offline_memory_block_cb); > > + if (!rc) > > + rc = offline_rc; > > + > > + return rc; > > +} > > I think these two helpers can get moved into patch 2/6 when the 'store' attribute was defined. I don't > see anything that requires they're in this patch and it would help reduce churn. > Yeah this'll get reworked with the interface rework. Thanks again, Gregory