From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAD42280A21 for ; Mon, 12 Jan 2026 22:58:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768258737; cv=none; b=V6OkXlU6cxqmI1yw4kRbu8DtHSrLbHrwKdCwtgqHkZcmEixBP7Tix9i03WROi1759JFWJAWqoxFQhqvcDgpX5K0MXd4gGeqqWbbs61JrMTO9siRuiBp0VbHTCfJQVJcOXP3o+GfqbROmFSQAhaA7OHjipKeaEwByQcM6+wQJucY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768258737; c=relaxed/simple; bh=OSvzN76rg+seSFGLS7/iTzPxgoJrSwfFsL1yCV0y0YY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=N6Sgc9y3PVwinPiBSb7RjtjKcME2jK+ayHpS0pc5aZkPoT+0sy0SRk8UEeb3UPPAT2V8oLQs45kg3WH77vRHen+3WIHBcVZiUSMKf19xFrtHbJR1moVKYoi+bNkQPVKZVWBqKbQPCnaKVLSvuNi4pB8OmKM9htSxp4q92uJv1TU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=HI2b8Qcj; arc=none smtp.client-ip=209.85.222.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="HI2b8Qcj" Received: by mail-qk1-f196.google.com with SMTP id af79cd13be357-8c0d16bb24dso657796685a.0 for ; Mon, 12 Jan 2026 14:58:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1768258735; x=1768863535; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=v+jOrSXuNU+8iYUyXwE2u0G+cRndsCz6SzUMkSsouk8=; b=HI2b8QcjvhSa16UtnnC94P5UOQVULBcHYwCatmUG5mSqYzJt93LlpcLCzihucuX5Ao KwaHyxG77f8k4n2lirVRsXAXwpIJcbR73YVabZYzKOE48dCWY9DfTnFcZNB231h6h8cf +/XcDA/vypgr8jBdoMoaZ2Rag8G9yF62YjXLRERPNFqwA8Pq5g/q6Mc3g1g/J3XbGion 0MgOJ4Z4vEv6R8VQGlfDQtAT3BDS1hmlhRkfaSurFq4lX+baoGjgQy5i04FVkTLMRQq8 crptODpJHt8ImdnGa4X1GmGz48ihpoi1G0f3Ctqpp2TPy+oxFq902lME8sI6M/4hk18t 5Jcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768258735; x=1768863535; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v+jOrSXuNU+8iYUyXwE2u0G+cRndsCz6SzUMkSsouk8=; b=wE8On1ER9Lu5GWrRlaybLDQbh1PzVGvyCfnsrugL9mTPz4mcjgxQYIElMV1TxtGBA6 4eycC0Ow9bXTFQkhbc+Ue5AuQIg4h6vihEVbgsG9AeYoYaO0bwhgCOXU9h/TQggimQhV XBrQ9NSN8DOVeHQFdMH1Qv7knHF1I9HCkAuQrcIiSRLuQFG4nbxnJuyiEP2eqoC8bpRM qmx0xBXXeLCEcmMe9j8RxzjHaN1kdwpmWLxQcqEZFgow0iwUuS3IRBP1M237gdPMFKDx V2rMLl96CsCnekk4Q6UcFiH8V6P228Z2nxKHC1T0wtSKTd9CvEfd8wbmxt35S75srLHv IOVA== X-Forwarded-Encrypted: i=1; AJvYcCVPEhagyNCmLj6x1cOx6ipBjv617BMrykJWevEtijBbj19VYw1ODWNDhVUI2qlhjxDyw97Tc10EHLVA/l4=@vger.kernel.org X-Gm-Message-State: AOJu0YwkYSN1aJ0bEneSq/7rNGGalgWmYG8F5FyzaMjNV5RUMqhqkSqD CXEvNse6PWWleycXsCRrzeUnA6odlHTI2EbWe2WZkHms2STLrGZ+zJwAaJz1UVGhac8= X-Gm-Gg: AY/fxX46vPIThZdN9qhvKyDAkU69avRksVBI8QfD3x49//i01K59tQSJBneM3cdNs4N cbskJ+b3aZnjIlrV7g5YbprTIbdyeiP+TfKqoO2nUfuVQ6j+5ncRAQdaa7/Wq3OsLdQgrCXYyLi mIMt8Xu3Jix7lS5sIaHkEFnSzaITSLciSpKS+IlosQDOSMrJ9D0ILCiNrpabs7vKEdcVIH8K3e6 ks6pvaXcITNrfa7xoobZP9ozyOBk+UpwQm55YsxJrArBT+h1yNpIh5Nx5/KqQOoyBKsfP4++UqX iQfIcife3LZPtc5+sEWkH0jbJ9S0xsxyjM54PpziepDxq4s3w3KGSLAXXfmXh41IuqvtMBI7U0H b/1Oqofr/oQ+w19BRfEAKhUs8jMZZ5V6l+oayixoaHXEb/tqA5kKze807GRYPnCumWsJ0D4Ps26 2X0QziNZHxONg1sXJiE0F8nzQ67qGv1VzqjNF5IBgOHOV6qZdSS9z3l0yRrNOy1yzKhoOvpQ== X-Google-Smtp-Source: AGHT+IGPazFaHUXjrDI8vZD8dC9hZWiv8xk7YlvWeX/nonxL8cgY5K7prBq9qebB0rMTcisWnKhSxA== X-Received: by 2002:a05:620a:4143:b0:8b5:8ba0:b312 with SMTP id af79cd13be357-8c3893dca40mr2875894285a.48.1768258734712; Mon, 12 Jan 2026 14:58:54 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-96-255-20-138.washdc.ftas.verizon.net. [96.255.20.138]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c37f4b917dsm1661818585a.17.2026.01.12.14.58.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 14:58:54 -0800 (PST) Date: Mon, 12 Jan 2026 17:58:21 -0500 From: Gregory Price To: "Cheatham, Benjamin" Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, dan.j.williams@intel.com, s.neeraj@samsung.com Subject: Re: [PATCH 3/6] cxl/core/region: move pmem memctrl logic into memctrl/pmem_region Message-ID: References: <20260112163514.2551809-1-gourry@gourry.net> <20260112163514.2551809-4-gourry@gourry.net> <1b9d3e1c-7b8a-4c9d-8788-4f901f985079@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1b9d3e1c-7b8a-4c9d-8788-4f901f985079@amd.com> On Mon, Jan 12, 2026 at 03:10:47PM -0600, Cheatham, Benjamin wrote: > On 1/12/2026 10:35 AM, Gregory Price wrote: > > Move the pmem_region logic from region.c into memctrl/pmem_region.c. > > Restrict the valid controllers for pmem to the pmem controller. > > Simplify the controller selection logic in region probe. > > > > Cc: > > May want to forward this to whoever this Cc tag was meant for :). > > One nit below, otherwise this looks good to me: > Reviewed-by: Ben Cheatham > doh, meant to send this to Neeraj at samsung because they've been poking at pmem stuff. Thank you. ~Gregory Neeraj: Link: https://lore.kernel.org/linux-cxl/20260112163514.2551809-4-gourry@gourry.net/