From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90A0E30E0D1 for ; Tue, 13 Jan 2026 09:51:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768297866; cv=none; b=iH4MUaBvsfWXdjCRUaR5Js4MyTREHBI4Db6tUFQbFTfDOTQGxmFHdk42YnqyGQeTWH/dy/zhccvNZepMLhEjbxgsipe0crmp7Mot9Qwg1LGQqoVmV/qXFguF1hoRO4oNP0ks3FmF8bBMkk4FOCURUnBgnU+MKNbQF0xbb/EoTUs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768297866; c=relaxed/simple; bh=x5nvcIgglz6sAs1J04CjFybdGTsMp6ryXN4/1UbxxrU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hXgO7rJqB+rf6aZjGHYZYfhdRZiEvbuW6O0K5HlKJIaFdMl/3REWIiWRvhiho1pyOJkxCOJ9FGp8MRfpVDGxSQsYQTOOtSMz8CRJwc0I1kCR+5rIFgPTOi4IG6YLqRLc1qHfWzeOz4/u8Zxc4U1xb7EZrQsix7nya4KzfYc48Ug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WfRrOpBU; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=lRa9U8Id; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WfRrOpBU"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="lRa9U8Id" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768297864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SuegcEMbY9lSnq1S6FOCWDio+XguCZJ7DfZn+fhhelk=; b=WfRrOpBUfzCQ5Sfpo82G4webdwW2vtdUiZatvzIEjrc4CtTf1Q+tOhwDS6nJUjtry2ZiBG /26YLimWASnQbcPP4lgSzEZObGOtsvmcDBw2ylhbOfatyT4tj73yYZO0LeP20iD9VRiPIy Pmalo6fR7oc1WweL1NjH83mOtswHKKg= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-619-Lxe6NzNSMzqhE4ykBKRUaA-1; Tue, 13 Jan 2026 04:51:03 -0500 X-MC-Unique: Lxe6NzNSMzqhE4ykBKRUaA-1 X-Mimecast-MFC-AGG-ID: Lxe6NzNSMzqhE4ykBKRUaA_1768297862 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-430ffc4dc83so6091275f8f.3 for ; Tue, 13 Jan 2026 01:51:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768297862; x=1768902662; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=SuegcEMbY9lSnq1S6FOCWDio+XguCZJ7DfZn+fhhelk=; b=lRa9U8IdrIUtXlPnRRwXjNWys1jQtZA49eZ6XwWm8BVvor+LGDwttOh+6i2c5Z6aDd n0bfgMbXgLXk+bRexXSYbPesR5M6DfAvV0T9YwMXgPTmpUDJrJ3DpS1bPGn7diyh9a2X 1iseZPplcgjVejsviVXxbKE4nYuKa7sq1JMgGLQAjBEJ/31p6tq883ezMC+ef07FhNMm BuNzmJ1jYSVtZC37oCX3rOJegLLSPlmdMcD4hJkYRmzsoHBL6VlC+SW1IdAQzpSo//pM EWQpTC2MS1VCffQ2958phKyaR6piY8OEc+RfbxxW9WrOhfxkUbZvctrXXjdRxpmzly6Z j5tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768297862; x=1768902662; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SuegcEMbY9lSnq1S6FOCWDio+XguCZJ7DfZn+fhhelk=; b=oipdxRqh/AzWPYbP+8FmSBuroUz5M3eAJ+Qa90ICFR2GZZC76okP4hU0DtUIA5swYs o1LvQ4yjD2xtJfW0IhLf54gEniHfMBT1c9elf56/GYuFxTfRQ6FitthXQK5KDnqzkc3Z k0eLNIxW8xmt7wNCHciaDCMGgm3yZ+8soaPRQiRqMLnkSW97lccxnRR/hXURo0wYBBaX 5dsdl+0eAUUQxtcecUquuuKJtp5rq4JV5LXDvn2cczGyW5HBNvipo7DLQslG6R0Fdxj+ CFDQSDUNgcxkvRqBXA0u8OuEI14/ig6QVEoGcMyGY1Pz9WpLMevIMx7JpRU4TO9qCwWo 8DPg== X-Forwarded-Encrypted: i=1; AJvYcCVDw4ZcjeoyAMkD0YMtP7H31QqF5Xu+WE0+Nz7WlGn7FVSsG8se5X4O3y6GNVu3Qt8XA0HO0QsLwFncdjQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw25SLkqsi0s833Jwz8gaKmTcfCkx15Oi/wINU41/SUa9ZmS+hz V4X3zj3JYfnb4Kt1+6iMMjLsf7Lce8zuawCiGduPFZHKKY5oNYEejw3E3I88dIW/dt5YQcPh7/2 SfPLY/UFB/9zfp4KIba+QYy7UgpLorY1c7yHQeh7J0Cf3bg60EyGT7w1aoYjaFL1B0A== X-Gm-Gg: AY/fxX6ZOa3y7W/PD7DH+09yEIzRp+koTXlK3WiAiw2JRsGH8NVq2A579ul+UUh1bVj hLoOPzYvRTtvi4Y3NKs8/ee8p2Ji2IJlVRzAxlcKtsvy/RnUBMCC30cRxjM+11yRmJGnGGT5S3/ Hu/6K25MP71z38Qd3vU9NtuQZvq+GxsmC1IwQDvoh4lIvydGO/CL+IjK8bpV58ITOJMhGw9ZLVj yJSHAVPAGniNzt8mCTM97QoSe5QIFoU4n6BzoFt1OIGANtNi3K2eH3+ctk9sz75+M8XlpoZwGS7 jd8F/ykHMQ2Jz5qJKBpfTcymaZh/FUTCxE9uNO49HhBs8VMF8rR6Ren3AFDk6+7wOS6zwV1uD+W pe2ip92nc3x1p2PPIjzQwiNRUuxT2dXUmwsaRNJVX X-Received: by 2002:a05:6000:4284:b0:42f:9f4d:a490 with SMTP id ffacd0b85a97d-432c374f455mr24914461f8f.12.1768297861862; Tue, 13 Jan 2026 01:51:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IH/HocyKVBbeEfIph3j1YdGuKhiU64yLdFoemd7E77OfFNQHWmWOgv6/yjIbt3JmS+jW7Valw== X-Received: by 2002:a05:6000:4284:b0:42f:9f4d:a490 with SMTP id ffacd0b85a97d-432c374f455mr24914432f8f.12.1768297861377; Tue, 13 Jan 2026 01:51:01 -0800 (PST) Received: from jlelli-thinkpadt14gen4.remote.csb ([151.29.129.40]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0e16d2sm44693886f8f.13.2026.01.13.01.51.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 01:51:00 -0800 (PST) Date: Tue, 13 Jan 2026 10:50:59 +0100 From: Juri Lelli To: Gabriele Monaco Cc: Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org, williams@redhat.com Subject: Re: [PATCH] sched/deadline: Fix server stopping with runnable tasks Message-ID: References: <20260113085159.114226-3-gmonaco@redhat.com> <20260113093706.GT830755@noisy.programming.kicks-ass.net> <9366bb54fa7529e79608b56a394d375789d28aa5.camel@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9366bb54fa7529e79608b56a394d375789d28aa5.camel@redhat.com> On 13/01/26 10:42, Gabriele Monaco wrote: > On Tue, 2026-01-13 at 10:37 +0100, Peter Zijlstra wrote: > > >  static void update_curr_dl_se(struct rq *rq, struct sched_dl_entity *dl_se, > > > s64 delta_exec) > > >  { > > > - bool idle = rq->curr == rq->idle; > > > + bool idle = rq->curr == rq->idle && !rq->nr_running && !rq- > > > >ttwu_pending; > > > > This is idle_cpu(), perhaps we can lift that thing into sched.h or so. > > > > Yeah, that's what I meant by quick and dirty.. I have idle_cpu() on the model > side (and have them matching simplifies a lot of things). > > I just wasn't sure if we wanted a function call in there. But we can probably do > something nicer without it too. Thanks for the patch (looks sensible to me too) and nice catch from the model!