From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAD1025DB1A for ; Tue, 13 Jan 2026 10:06:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768298811; cv=none; b=C8zxqgGoVrfoQqkPdr2Sc5aEsTaOCR5MnZhN3P0hnaFB8z+umlrXlQNwNoUtuvwWMgEguQzkAw1F1vlhzt8c7KPPVmV8+x73/IbRQBkt4+DBe6sBD5bPpEk6w8VtxD7WAsGkZCgIe+h9iYcynHh7isWa3PH7r4SyFIvIBNOo7TU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768298811; c=relaxed/simple; bh=uHaCt70arjhBzr371P7SY/ffODMWV2aLD/P+p/XwMbI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jEbZ+BCvAkoUZznWHHvLO6vB6Owe/S3hmD89wYnqGLLKVwaQEaanYan9NBqdXOocau+TyHU2oupbaXdGXVRd388vAmatAcwbuerfT3n2YIDx3G7cxHAr5iP3Z6DUk3gBQTt9PRwVSw2gAnkCUDoRXgzzG9rThNDnasEgnoKjaEU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=illZs1iE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="illZs1iE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 670E9C116C6; Tue, 13 Jan 2026 10:06:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768298811; bh=uHaCt70arjhBzr371P7SY/ffODMWV2aLD/P+p/XwMbI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=illZs1iENOAIyx/+dVsvT6M91TcaR27POX7cTRDmJJkx0LNodDVBtzZYJiFy6iZG9 yCll1KMkMr1GhA3ShKl1oLyVLJs3/3da/LSYrFdARCNRNBS9HeTjOrakiPpEqQuNBY XXUdc9rxFEsw5+rcON9Q+tosB29VEYHkpJC7W2O0ChrYkWWp6LjycDkIoarU4SzRFL aLbrTFmY1grk+AEBq/tigbv9sPXV6f2nj1J2TrYcZSGdCYcGApaqNULAuTbZeXz81L bpmQsAOx2HDI4mNYCYH1p5KHkFUPZ0PKQZSGnTHogHLn3CI1FO/hnoeqJmJqa0hziz Du5ACkPlLb1ow== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vfbIR-000000006lh-2HLB; Tue, 13 Jan 2026 11:06:44 +0100 Date: Tue, 13 Jan 2026 11:06:43 +0100 From: Johan Hovold To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] greybus: Use bus methods for .probe() and .remove() Message-ID: References: <20251210175943.590059-2-u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20251210175943.590059-2-u.kleine-koenig@baylibre.com> On Wed, Dec 10, 2025 at 06:59:39PM +0100, Uwe Kleine-König wrote: > These are nearly identical to the respective driver callbacks. The only > difference is that .remove() returns void instead of int. > > The objective is to get rid of users of struct device_driver callbacks > .probe() and .remove() to eventually remove these. > > Signed-off-by: Uwe Kleine-König > -const struct bus_type greybus_bus_type = { > - .name = "greybus", > - .match = greybus_match_device, > - .uevent = greybus_uevent, > - .shutdown = greybus_shutdown, > -}; > - > +const struct bus_type greybus_bus_type = { > + .name = "greybus", > + .match = greybus_match_device, > + .uevent = greybus_uevent, > + .probe = greybus_probe, > + .remove = greybus_remove, > + .shutdown = greybus_shutdown, > +}; > + Please keep the indentation style when moving the struct. With that addressed: Acked-by: Johan Hovold Johan