mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@nxp.com>
To: Wei Fang <wei.fang@nxp.com>
Cc: shenwei.wang@nxp.com, xiaoning.wang@nxp.com,
	andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, ast@kernel.org,
	daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com,
	sdf@fomichev.me, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, imx@lists.linux.dev,
	bpf@vger.kernel.org
Subject: Re: [PATCH net-next 03/11] net: fec: add rx_shift to indicate the extra bytes padded in front of RX frame
Date: Tue, 13 Jan 2026 10:56:00 -0500	[thread overview]
Message-ID: <aWZrECQIy+a8yEcJ@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20260113032939.3705137-4-wei.fang@nxp.com>

On Tue, Jan 13, 2026 at 11:29:31AM +0800, Wei Fang wrote:
> The FEC of some platforms supports RX FIFO shift-16, it means the actual
> frame data starts at bit 16 of the first word read from RX FIFO aligning
> the Ethernet payload on a 32-bit boundary. The MAC writes two additional
> bytes in front of each frame received into the RX FIFO. Currently, the
> fec_enet_rx_queue() updates the data_start, sub_len and the rx_bytes
> statistics by checking whether FEC_QUIRK_HAS_RACC is set. This makes the
> code less concise, so rx_shift is added to represent the number of extra
> bytes padded in front of the RX frame. Furthermore, when adding separate
> RX handling functions for XDP copy mode and zero copy mode in the future,
> it will no longer be necessary to check FEC_QUIRK_HAS_RACC to update the
> corresponding variables.
>
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
>  drivers/net/ethernet/freescale/fec.h      |  1 +
>  drivers/net/ethernet/freescale/fec_main.c | 21 ++++++++-------------
>  2 files changed, 9 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec.h b/drivers/net/ethernet/freescale/fec.h
> index fd9a93d02f8e..ad7aba1a8536 100644
> --- a/drivers/net/ethernet/freescale/fec.h
> +++ b/drivers/net/ethernet/freescale/fec.h
> @@ -643,6 +643,7 @@ struct fec_enet_private {
>  	struct pm_qos_request pm_qos_req;
>
>  	unsigned int tx_align;
> +	unsigned int rx_shift;
>
>  	/* hw interrupt coalesce */
>  	unsigned int rx_pkts_itr;
> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> index 0fa78ca9bc04..68410cb3ef0a 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -1799,22 +1799,14 @@ fec_enet_rx_queue(struct net_device *ndev, u16 queue_id, int budget)
>  	struct	bufdesc_ex *ebdp = NULL;
>  	int	index = 0;
>  	bool	need_swap = fep->quirks & FEC_QUIRK_SWAP_FRAME;
> +	u32 data_start = FEC_ENET_XDP_HEADROOM + fep->rx_shift;
>  	struct bpf_prog *xdp_prog = READ_ONCE(fep->xdp_prog);
>  	u32 ret, xdp_result = FEC_ENET_XDP_PASS;
> -	u32 data_start = FEC_ENET_XDP_HEADROOM;
> +	u32 sub_len = 4 + fep->rx_shift;
>  	int cpu = smp_processor_id();
>  	struct xdp_buff xdp;
>  	struct page *page;
>  	__fec32 cbd_bufaddr;
> -	u32 sub_len = 4;
> -
> -	/*If it has the FEC_QUIRK_HAS_RACC quirk property, the bit of
> -	 * FEC_RACC_SHIFT16 is set by default in the probe function.
> -	 */
> -	if (fep->quirks & FEC_QUIRK_HAS_RACC) {
> -		data_start += 2;
> -		sub_len += 2;
> -	}
>
>  #if defined(CONFIG_COLDFIRE) && !defined(CONFIG_COLDFIRE_COHERENT_DMA)
>  	/*
> @@ -1847,9 +1839,7 @@ fec_enet_rx_queue(struct net_device *ndev, u16 queue_id, int budget)
>  		/* Process the incoming frame. */
>  		ndev->stats.rx_packets++;
>  		pkt_len = fec16_to_cpu(bdp->cbd_datlen);
> -		ndev->stats.rx_bytes += pkt_len;
> -		if (fep->quirks & FEC_QUIRK_HAS_RACC)
> -			ndev->stats.rx_bytes -= 2;
> +		ndev->stats.rx_bytes += pkt_len - fep->rx_shift;
>
>  		index = fec_enet_get_bd_index(bdp, &rxq->bd);
>  		page = rxq->rx_buf[index];
> @@ -4602,6 +4592,11 @@ fec_probe(struct platform_device *pdev)
>
>  	ndev->max_mtu = fep->max_buf_size - ETH_HLEN - ETH_FCS_LEN;
>
> +	if (fep->quirks & FEC_QUIRK_HAS_RACC)
> +		fep->rx_shift = 2;
> +	else
> +		fep->rx_shift = 0;
> +
>  	ret = register_netdev(ndev);
>  	if (ret)
>  		goto failed_register;
> --
> 2.34.1
>

  reply	other threads:[~2026-01-13 15:56 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13  3:29 [PATCH net-next 00/11] net: fec: improve XDP copy mode and add AF_XDP zero-copy support Wei Fang
2026-01-13  3:29 ` [PATCH net-next 01/11] net: fec: add fec_txq_trigger_xmit() helper Wei Fang
2026-01-13 15:52   ` Frank Li
2026-01-13  3:29 ` [PATCH net-next 02/11] net: fec: add fec_rx_error_check() to check RX errors Wei Fang
2026-01-13 15:53   ` Frank Li
2026-01-13  3:29 ` [PATCH net-next 03/11] net: fec: add rx_shift to indicate the extra bytes padded in front of RX frame Wei Fang
2026-01-13 15:56   ` Frank Li [this message]
2026-01-13  3:29 ` [PATCH net-next 04/11] net: fec: add fec_build_skb() to build a skb Wei Fang
2026-01-13 15:59   ` Frank Li
2026-01-14  2:32     ` Wei Fang
2026-01-13  3:29 ` [PATCH net-next 05/11] net: fec: add fec_enet_rx_queue_xdp() for XDP path Wei Fang
2026-01-13 16:11   ` Frank Li
2026-01-13  3:29 ` [PATCH net-next 06/11] net: fec: transmit XDP frames in bulk Wei Fang
2026-01-13 16:17   ` Frank Li
2026-01-14  9:57     ` Wei Fang
2026-01-13  3:29 ` [PATCH net-next 07/11] net: fec: use switch statement to check the type of tx_buf Wei Fang
2026-01-13 16:22   ` Frank Li
2026-01-14 10:01     ` Wei Fang
2026-01-14 13:47   ` David Laight
2026-01-15  2:27     ` Wei Fang
2026-01-13  3:29 ` [PATCH net-next 08/11] net: fec: remove the size parameter from fec_enet_create_page_pool() Wei Fang
2026-01-13  3:29 ` [PATCH net-next 09/11] net: fec: move xdp_rxq_info* APIs out of fec_enet_create_page_pool() Wei Fang
2026-01-13  3:29 ` [PATCH net-next 10/11] net: fec: add fec_alloc_rxq_buffers_pp() to allocate buffers from page pool Wei Fang
2026-01-13  3:29 ` [PATCH net-next 11/11] net: fec: add AF_XDP zero-copy support Wei Fang
2026-01-13  9:29   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWZrECQIy+a8yEcJ@lizhi-Precision-Tower-5810 \
    --to=frank.li@nxp.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hawk@kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=john.fastabend@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf@fomichev.me \
    --cc=shenwei.wang@nxp.com \
    --cc=wei.fang@nxp.com \
    --cc=xiaoning.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®