From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D15D387590 for ; Wed, 14 Jan 2026 11:04:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768388651; cv=none; b=jxV8GpYm13Bn092ghwAOMRBLz2lpn0fVnLnI30YKmkLsyX/K3M17tvnzO+sbat6/AjDCdVM5lDua0ntMESRhpEIB8JvJH2YqPFs+jojLpEUYQJfa2CE5KoJwU/4qyRureMfAD+6d0rkmYCiz9gIr6kEvFNV3AvYdp6IxF1WzvVk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768388651; c=relaxed/simple; bh=CKoytYIjyvPmaxoxafc20P2sCJzi4Xtddki48eM//uc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Kz9NLIAIVihRJvK6hWzqTnqRpwd5vL5urTu/kTHbdYqFY9x9qPq4V4VZTvD4bvkwvSit2dOPxlCP/bzAr0cGWpp8B/wc8x0K3ATR3Aafmu8Jwn0pakZnK/vJdFPzs1N1gS8T0qlKJ5TtTa/D+7UvqL9ZdRmmkmVPpntk8BX6I6I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=G4WuLTUq; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=XZfsRod/; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="G4WuLTUq"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="XZfsRod/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768388637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k4ctcQ/gA5iWFLkLo4gjZhw2/PBh/xjQEfQ8kdZaks0=; b=G4WuLTUqMXL6A964TIYhDbDSkmrrzPIr4gZ8nh4TftEefvcyYT9ktq45ejdJPAq+Gcnntg ICK588lnBNS5pOD9NSR7mUxZV0mqvBZbrwluOs/8K0jHCHc3XXKkK84eASQg1yx24R7DFb cy0tFjIO5ULVkq8psEc5PwXpWibH/XM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-663-ZUPsYPtYOmm2FWJMUR4Trw-1; Wed, 14 Jan 2026 06:03:56 -0500 X-MC-Unique: ZUPsYPtYOmm2FWJMUR4Trw-1 X-Mimecast-MFC-AGG-ID: ZUPsYPtYOmm2FWJMUR4Trw_1768388635 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-47d5bd981c8so58379315e9.0 for ; Wed, 14 Jan 2026 03:03:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768388635; x=1768993435; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=k4ctcQ/gA5iWFLkLo4gjZhw2/PBh/xjQEfQ8kdZaks0=; b=XZfsRod/No9BcLZSNgTjvjmMU2SyZAkDdGUqIWDY5ll8Q7gfQ2q2v9wkbqM6uqQI47 ieWi338HlyrzBAIqfbwABrqUmbVRW5pZkdfnOXSUZ18NNf3aqFV5LArglxM6pFPvgOVA 84o9WaJtbQqzESwPdeS+FKlIJS950TONdw05lU2cfF7EmdtEYexgpHXWU0p7KguWl86I RoQSTh2WfWfWewBsOckVCHaTJYXy4WuptQOvkxQ5pXJdYUx1NZAhEen3FqKvs9123aV7 wAltL2/6dstYdZqWM5Gsk42/OLMjX0/Aj2IqJqmVyxUvKuWUh5FB2oa3rAfwICOD6p8g DpDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768388635; x=1768993435; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k4ctcQ/gA5iWFLkLo4gjZhw2/PBh/xjQEfQ8kdZaks0=; b=EeK3mkfOTAi0RDdumA62L1wzseWHKbLoGJudkZvoXLPlhOUuLlaCiR91/nC3H6+j52 RpBoutOfpkYJcAOPc01GHgOFXQFrxYRykC+PCXtpFWCYGUrVVzBrDIlieDI7T2+Tow5o e60N1+Ok/Kc2/CDoNXtGXZmTbzMwAXf/gSLR/SyeH+iOoPDNA8aekWSwnV43Lq6VrZ58 DxjzAEvjpiyIsVNViIcPUSfwUNJT/lb9vVjOKn6hguRwC9qsgd6AUnLaExHcLlp+X+ny GxETUvwGOtkQZBcS35fCQKuOVRTSI1NIR4avVDG6t/4eLbxvo6jGa/PoaoM/H9Zif2lH n7cA== X-Forwarded-Encrypted: i=1; AJvYcCW+5ECSWUHMAMqTxomdd8gA3BHM/ANEbaYeOnhLrw+lJIubCulEHmZzVqRoq5BrgaIkgw9V9zMBr5p+ePk=@vger.kernel.org X-Gm-Message-State: AOJu0YzqdtQB8WnKihCR1QXgt4ZS1Pu3Ol4F76PQw0j203TcMU9d0Y0B z7z5Y/ikoSCxo2m1CMIkIa3EvdMe49ujZW3x6LjLrONUC0zsihHa3Sji4ffDG2/Ms/olkBjEt2c S9VVmNc7ir0cToudAnsUszs5kEiy4PikhtyMtXqSvL7jU3pO3MEDexd8YCedJM1R2tw== X-Gm-Gg: AY/fxX6O97F829BfNdnNBcjgY7GmW5Nr36Vox46tmWalHxpQ+Xjv7pJl2TM22ibtwkD W+G3SLjv8UtceZMf+5WZmFou86rOItxeEKOfglFhQaB4OMr3BF8+MWN6/5+jc1PW+Qb/vRjC4/Z X6/hTup+j4yUqmgHEvjgoUHN0lJMJ8JZJA/EKg/06slqnZJk6e6jX6/EVLiPdhdRPIaMvxN3+BL oLKIDERYMcGYP+oHPRoz4OyF5NM51Vr4+GRBicTjb0XN7UqRb5cbUqpaFKINs2TyKKAg6UNza3n VT7Sj0ZGTTTxkkfP70WBZ2ZsvOdtlo4Kao1B5iWaLOCe4x1BnOGk/INOL4CtHK3/KLfbOqakRC8 sYkMX/uZ3mUmuB/iXiwJN2VHbQYm5Vt9bTD4vcDUd X-Received: by 2002:a05:600d:9:b0:47e:e78a:c834 with SMTP id 5b1f17b1804b1-47ee78ac9efmr7987515e9.34.1768388635168; Wed, 14 Jan 2026 03:03:55 -0800 (PST) X-Received: by 2002:a05:600d:9:b0:47e:e78a:c834 with SMTP id 5b1f17b1804b1-47ee78ac9efmr7987275e9.34.1768388634817; Wed, 14 Jan 2026 03:03:54 -0800 (PST) Received: from jlelli-thinkpadt14gen4.remote.csb ([151.29.129.40]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47ee578d1b2sm22651735e9.2.2026.01.14.03.03.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 03:03:54 -0800 (PST) Date: Wed, 14 Jan 2026 12:03:52 +0100 From: Juri Lelli To: Yuri Andriaccio Cc: Ingo Molnar , Peter Zijlstra , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , linux-kernel@vger.kernel.org, Luca Abeni , Yuri Andriaccio Subject: Re: [RFC PATCH v4 01/28] sched/deadline: Do not access dl_se->rq directly Message-ID: References: <20251201124205.11169-1-yurand2000@gmail.com> <20251201124205.11169-2-yurand2000@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251201124205.11169-2-yurand2000@gmail.com> Hello! And Happy New Year! :) On 01/12/25 13:41, Yuri Andriaccio wrote: > From: luca abeni > > Make deadline.c code access the runqueue of a scheduling entity saved in > the sched_dl_entity data structure. This allows future patches to save > different runqueues in sched_dl_entity other than the global runqueues. > > Move dl_server_apply_params call in sched_init_dl_servers as the > rq_of_dl_se function will return the correct deadline entity only if the > dl_server flag is set. s/deadline entity/runqueue/ in the above, right? > Add a WARN_ON on the return value of dl_server_apply_params in > sched_init_dl_servers as this function may fail if the kernel is not > configured correctly. > > Signed-off-by: luca abeni > Signed-off-by: Yuri Andriaccio Apart from that Reviewed-by: Juri Lelli Thanks! Juri