From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61B722FFDCB for ; Wed, 14 Jan 2026 09:48:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768384092; cv=none; b=HZF7z736QcZfAVpCUQGCnr3j6ow2XVx5uPW4zWpwArIN2eK2+3TfXFO3IP1cU8YGIuIhkKUJRKI5M+Av++TabHWb+nfc+RCrI1gvHKeCwYJZSlGwFPHhiGsHIqXzQYmF42fyCt1peF3QgE3b+llIsBRenPp5Bs4oXJ/ok6hoaQ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768384092; c=relaxed/simple; bh=+dRzbW/DJO1LjJJNBh4yQ94RIdK+nY+B0TmOn2/Vtm8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oh2fii2UQ8QA7GtGDRq74SeCXt4Q7Fi/n/kb6LmedWrGS7qnX9/nVLcfELYbWWkesQ0oAtyepQAhwewsCoA+T5BJNpM6SaJmkXbeYTC7I8X/x4Tr2Ywx3BCxpdJ5AI2LlCalEeGjQOmPKcO0zHg8PXf9MiGWMivbw6oz6+VJmvI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LSOrO76V; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LSOrO76V" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76F57C4CEF7; Wed, 14 Jan 2026 09:48:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768384092; bh=+dRzbW/DJO1LjJJNBh4yQ94RIdK+nY+B0TmOn2/Vtm8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LSOrO76V+HQHuXVlbzy8m24zoSwABCIXKQcW3RkC/2td5Hxg7hBS12OJpuTCOJxFc KFnyvST6etLlAfD2tX+n9ZrqUm8YZPvOwfHBqDC4Hn56y7tV+pHa2ANz8JfWt15Gi0 ofvntRKcf1FCtC8MaEA2IMZmw1I+d/NVnoEyQGvnv/vMO6ow6atjD0ple2vIoGUQH/ WLJq42Dc3NfdcTJgsPmYNrYYpTndV2dsPscuOAzcoANqAFO99NKQH3W8ZXE2HBv5li ehmz7Bp1WRHLozWpEI7uUeYZfq3FTVEhE5ZY9x5gmOLY9RMd0aQg15qyF9emuu2VZ8 4XoeHADRo0vaw== Date: Wed, 14 Jan 2026 15:18:08 +0530 From: Vinod Koul To: Aleksandar Gerasimovski Cc: linux-kernel@vger.kernel.org, kishon@kernel.org Subject: Re: [PATCH] phy/marvell/phy-mvebu-cp110-utmi: fix dr_mode property read from dts Message-ID: References: <20260106150643.922110-1-aleksandar.gerasimovski@belden.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260106150643.922110-1-aleksandar.gerasimovski@belden.com> On 06-01-26, 15:06, Aleksandar Gerasimovski wrote: > The problem with the current implementation is that it does not consider > that the USB controller can have multiple PHY handles with different > arguments count, as for example we have in our cn9131 based platform: > "phys = <&cp0_comphy1 0>, <&cp0_utmi0>;". > > In such case calling "of_usb_get_dr_mode_by_phy" with -1 (no phy-cells) > leads to not proper phy detection, taking the "marvell,cp110-utmi-phy" > dts definition we can call the "of_usb_get_dr_mode_by_phy" with 0 > (#phy-cells = <0>) and safely look for that phy. > > Signed-off-by: Aleksandar Gerasimovski > --- > drivers/phy/marvell/phy-mvebu-cp110-utmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/marvell/phy-mvebu-cp110-utmi.c b/drivers/phy/marvell/phy-mvebu-cp110-utmi.c > index 59903f86b13f..dd3e515a8e86 100644 > --- a/drivers/phy/marvell/phy-mvebu-cp110-utmi.c > +++ b/drivers/phy/marvell/phy-mvebu-cp110-utmi.c > @@ -338,7 +338,7 @@ static int mvebu_cp110_utmi_phy_probe(struct platform_device *pdev) > return -ENOMEM; > } > > - port->dr_mode = of_usb_get_dr_mode_by_phy(child, -1); > + port->dr_mode = of_usb_get_dr_mode_by_phy(child, 0); > if ((port->dr_mode != USB_DR_MODE_HOST) && > (port->dr_mode != USB_DR_MODE_PERIPHERAL)) { > dev_err(&pdev->dev, > -- > 2.34.1 > > > ********************************************************************** > DISCLAIMER: > Privileged and/or Confidential information may be contained in this message. If you are not the addressee of this message, you may not copy, use or deliver this message to anyone. In such event, you should destroy the message and kindly notify the sender by reply e-mail. It is understood that opinions or conclusions that do not relate to the official business of the company are neither given nor endorsed by the company. Thank You. Okay destroyed! -- ~Vinod