From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F49E3A1A37 for ; Wed, 14 Jan 2026 15:50:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768405827; cv=none; b=Qm1+ligZKjrK+lbIUnsH6mq76K7uOn5KWGhDyhGWT+8IAIuZp2vP/bUKji3S0vVgQgKj3MNknXZ+wWmNxKWdcxri9tn2OUY+Qvip3R68rIyXhdUK2/aZMvj4p0GaQteBQS6zSb2rXN6EKtnKqPrnbyFfsdMCy1NrbHgVy2TcRcw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768405827; c=relaxed/simple; bh=ddQehrH3WSA3nGxMiaRyAYUbIlWNzS5C9Jp+zx+8H8s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UvdObstdpN5+JhzupdDI5MSGHWtlXHUCAf3Ch8n/BJtc4cjD2qEGcM1fLpoMc9Twg6t2945z6p0Ca8JkfM1WIVfZgkMHkf3I3rlkwDyBHCm8aRYkh9g+fRF2BixGzld4e1GVq1pn4EowRDIgCL89aq4P4iBnclg8CWqcD2PVYTU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fHqNHHoD; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fHqNHHoD" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-42fed090e5fso5126618f8f.1 for ; Wed, 14 Jan 2026 07:50:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768405821; x=1769010621; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bOiuVPrIXtE3jtOHLTY4+B/ZSnvL+yz9lGk8+TFFzig=; b=fHqNHHoD7D5VZmBZqNtYp067LU/SrgHKWVBJi4y0eNECXv/XPcOHnqDI+xgib96fbi UxrYOxxtwtKMGAK26ISfYunfWRjykjvxD5Pmycz0Ndf6HHj93XFG3PdobFh+yEG1aysu Y+IWkT7zBiCL4bBbL7xT/9plnWH/G6fkwlDm0cD/tkpjRfhkF/yxATVKSPu6bDDHtD3G LP6SAd9gwHx9Xzto76YC9lq1V1hNHIDNOzKfp8ngvoZe/NV286Fmu8e0GNB6ucMbhMwO 5cHx0XjJZngKJV3zGMLYE/4PC1xwGqqMxDbnyeH4muNON/NrbSqSGG3d1+NzUDvEWjnM hoXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768405821; x=1769010621; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bOiuVPrIXtE3jtOHLTY4+B/ZSnvL+yz9lGk8+TFFzig=; b=jTWlSMmzBsCRSIVg4YqnFUnSdoBcDtp3Sn2R9Ul0jyZosH3hSVznpKIgglDkdJFRza Lq8iVfCxrVJ27gkHteQBCToiRZeDysu4+1OmZr1za74aCEkgWdCSre9rh8/KoUm9xzM9 xJ2Sn29SxIqlQbDAl7Ho77GXjf/e1+EAHUoz0LTXfNdXmGp4bDXBM+sVZXkMHwZtM/2L 96WXr+25S5W+MMrRi/241MKQs2xQVW25POV8BKiOapH5EFXuWjulzN2bWXgiZze75MRD j45cb+6YtHGG0IRMjwaCGcCN+OVxgnsA0nO0PnASpTYmSs8XWt0KRqNYXzgYPjEpAQKq 3dhg== X-Gm-Message-State: AOJu0YwMsStRZG6vdwCFiC7pTJy52lr8BdfiWOlgeNfWa18IoA6o2gFa 2WkVJ4UrdhL+edlCtA6EnK4qIfWR/TdUBnP6DqS7QuvZq0tOyRnz6RAE X-Gm-Gg: AY/fxX7iX1L6PDe34BFlAyiShbkU7BAbrbjVvColRpWum7fxrdSdHzJ4uhGgG7DHrId qLkMwKjSu3h/MlflXP6wnoQ1CEEsN+k43wd07Ojb+pcc3SL+rURwbn11ufNoUNyMKxUW8wUKAx6 rft6TYwJG4PErHydc7CRMsKApQpSnQgcQuTWCl1b1Axy7pbTY9RnnqYEAprjwwO62J1eDKIVOtg b0F6AXnIEybGdmQ1SZ41pxX7paAHHKzB48asZzMzA6UQhXlAF7Dg32uWymIG+6NpggInkOeeD0p tUGsetaU2ISAPhJcDAWS0JMCFPDauTs8G1O/luyk/3QDUqfTY39IvY7hz7IJCG87O9GOu41nqDQ nR3u2xc+7e+85ktQVJBG1a+KULbdGjWZnuvke8j+OKNQCcPkovJ7101WPFUYl+bElNO3AmX6p1o TI0XOXA59W6B+fv/OFRT1bcSIEztCz850gSrM12JaQpAW5mCKYcXY61cpe5lx0qqNb X-Received: by 2002:a5d:5d81:0:b0:430:f3ab:56a1 with SMTP id ffacd0b85a97d-4342c557659mr3494985f8f.42.1768405821138; Wed, 14 Jan 2026 07:50:21 -0800 (PST) Received: from localhost (brnt-04-b2-v4wan-170138-cust2432.vm7.cable.virginm.net. [94.175.9.129]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-434af64a650sm26077f8f.4.2026.01.14.07.50.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 07:50:20 -0800 (PST) Date: Wed, 14 Jan 2026 15:50:19 +0000 From: Stafford Horne To: Krzysztof Kozlowski Cc: LKML , Linux OpenRISC , devicetree , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org Subject: Re: [PATCH v5 1/6] dt-bindings: gpio-mmio: Correct opencores GPIO Message-ID: References: <20260114151328.3827992-1-shorne@gmail.com> <20260114151328.3827992-2-shorne@gmail.com> <0bb9de0d-f811-45ff-b673-8811540b5376@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0bb9de0d-f811-45ff-b673-8811540b5376@kernel.org> On Wed, Jan 14, 2026 at 04:43:35PM +0100, Krzysztof Kozlowski wrote: > On 14/01/2026 16:13, Stafford Horne wrote: > > In commit f48b5e8bc2e1 ("dt-bindings: gpio-mmio: Add compatible > > string for opencores,gpio") we marked opencores,gpio to be allowed with > > brcm,bcm6345-gpio. This was wrong, opencores,gpio is not hardware > > equivalent to brcm,bcm6345-gpio. It has a different register map and > > "is not compatible with brcm,...." OK. > > is 8-bit vs braodcom which is 32-bit. Change opencores,gpio to be a > > separate compatible string for MMIO GPIO. > > > > Fixes: f48b5e8bc2e1 ("dt-bindings: gpio-mmio: Add compatible string for opencores,gpio") > > Signed-off-by: Stafford Horne > > --- > > Since v4: > > - New patch. > > - Rebased old patch and rewrote commit message. > > > > .../devicetree/bindings/gpio/gpio-mmio.yaml | 16 ++++++---------- > > 1 file changed, 6 insertions(+), 10 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml b/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml > > index 7ee40b9bc562..a8823ca65e78 100644 > > --- a/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml > > +++ b/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml > > @@ -18,16 +18,12 @@ description: > > > > properties: > > compatible: > > - oneOf: > > - - enum: > > - - brcm,bcm6345-gpio > > - - ni,169445-nand-gpio > > - - wd,mbl-gpio # Western Digital MyBook Live memory-mapped GPIO controller > > - - intel,ixp4xx-expansion-bus-mmio-gpio > > - - items: > > - - enum: > > - - opencores,gpio > > - - const: brcm,bcm6345-gpio > > + enum: > > + - brcm,bcm6345-gpio > > + - ni,169445-nand-gpio > > + - wd,mbl-gpio # Western Digital MyBook Live memory-mapped GPIO controller > > + - intel,ixp4xx-expansion-bus-mmio-gpio > > + - opencores,gpio > > So if you are changing all of the lines here, you can as well sort it > and put the new entry not at the end but in alphabetical spot. OK, I will sort the list and mention that in commit message in v6. > Reviewed-by: Krzysztof Kozlowski Thanks, -Stafford