From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f50.google.com (mail-oa1-f50.google.com [209.85.160.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA98A322B9E for ; Wed, 14 Jan 2026 15:19:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768403946; cv=none; b=eJhO5munT1AirV9WZ6SMbB9bnOIzEEFJcDsl0qCZQ+cpQOCB5ZzYr3wfXxqMPOdPcmWM9MPHV9RUa6l9k4MqTkqA9o7+MavE5DOu8n8SXmr95MY9uni807P1GdyoAS0xXA1Rsw53b8GxGIOkLmBdENlzb8WxnHSHTskUROl5FCs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768403946; c=relaxed/simple; bh=FqvON25tjLhp7Xx4WiRTLneVcjPRZcYu8WHbdY2g/0Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ABuQr+HcoBzsfJM96mg+KsWbGebhFm0WIBQE5knhBUa+r5G18RKYsUx2fwH/q6taDmT67fMlmPlNbNRWkhZzag7nrRC2FLwacaaffqKY2/qKNhRRXl2e9Fulv5/dmvLvvp23lWLFUoENDVxqq/5mjgF/hHdOyEXRPB3mF6WObYM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net; spf=pass smtp.mailfrom=minyard.net; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b=Mm0I3LCB; arc=none smtp.client-ip=209.85.160.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=minyard.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b="Mm0I3LCB" Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-3e7f68df436so812305fac.1 for ; Wed, 14 Jan 2026 07:19:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard.net; s=google; t=1768403944; x=1769008744; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:reply-to:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=8n3JaraXJSpEIQ8S4asX30qs6Q4GjiJGDB0h/DGBWts=; b=Mm0I3LCBpApwMTSoHQHOWEF3c/WeuaQqMk5PcJ+v9FdN8LydpGI8BjqmthPl0Oc1pz hXxh9XqayxOV+VUIAunb+uTdNz9l68TyXHqSiwjV1Zs73alzcNvSUIIuEuSqfNtevhJ0 rzxzpTHJ0Cuufo58rymGmo7KZUYGUtRvy603kcURvhzbM8DYiWd5i89j3S7eO9FeHTnp 0TNO5rwZRK8/+sHsNe2c81xakVvbbdJsM88bExroxtHdKtZQlo5GrmT5hjYnKEvm5nBv nsZ010RV4LsvZAr2oYNX7m+nR9+nbkF6hkU8sxJU2JpPLm/x4QQdgSq4g1mNwv4pKMRy SYZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768403944; x=1769008744; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:reply-to:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8n3JaraXJSpEIQ8S4asX30qs6Q4GjiJGDB0h/DGBWts=; b=BEKRiQj6cfTNcXwK2IFLD3qRllo1Z3Hl9EwNnoLRwlKvGCs3yrKAgca5ECV5fiV8pM RZrNvmgZV3FFGxaTooA3bp/xiLHXMJevurRz2+2nRzVlllzGNVDMeuhSnbKHuv3I++rU noITt/TDeYAXb3AghC4sJYXG07cgzU4hlAaowF22pkwCXO62XY5dYRAwJfiCtLcDSTWu 5XFhK5xALgkquYKBUkL0WGDOT6Zl0teRKpT4eyvOOMgOhfqYSUBi+A5xym4V4t+jI/f1 2GnhFZ2hyCQDnRh6FXZ8XDXn2T+cJNOD5o6cnGRToeSKUt3UXa349BjTSzUcnRTvl2UK JBYA== X-Forwarded-Encrypted: i=1; AJvYcCWoi7GwwdWN8CaspzC88/fOhmribUfwIMJy00TwNwxtaeRGBhHn2UxaK6vtk9Hp+uSIRyocgtsZrkpX5QM=@vger.kernel.org X-Gm-Message-State: AOJu0Yzg+GTmYw25DvO52Sk7mPpVvvxAdGm6gr63EM6Be6K5B/I/ngLb e0qM7Ew2ZRDV8Y8RUB8utmijSZClz5uFBaz2aILwjAXjheYO2bTEE/5izOgBvXsJet8zvuW73U4 NTI/cR8A= X-Gm-Gg: AY/fxX50uJSsFHZEefbmcOBb1KQCVv9EPpZ7hWLXs71wu8snGZmOjPgDvTZQD2yKFlg IxQ4EV6hzXGg877++LXNC41089BBodKKfP9BRfczaHit9jE33Y1yK0TDRAeWjcT4QzvDh8CzMTx Wq0GqIxWIKdSoDZgvNyPScE4SW8erKjjGBN98ZFJ8CazMcripSXBSESez6QyeTwFahbKx28QxPM pES1Fq9QPpcZOBdRPFopFYuxf0NCxpInXRdagjRKAkFGt/MGyTJtJtrlo33oryBP/fJi5f27bbG 3jC+gBLhLWBJwIoi0T/wNtmAX9xXeHxtRS4agq2AYJtA+PFi7gqdJFiJjVrwh4hbmjFd1ON5bTy KptsEyzHwiW1ARV+GhNBwnOJwrr2s7zqNuAFo7WauMER2J1Eh0IjsPI81JXZLpqEUBVReHYWeIo 1MkPRcVmxBB4mPKg== X-Received: by 2002:a05:6870:cb83:b0:3e0:bd2c:f459 with SMTP id 586e51a60fabf-404065c5a40mr2483722fac.12.1768403943483; Wed, 14 Jan 2026 07:19:03 -0800 (PST) Received: from mail.minyard.net ([2001:470:b8f6:1b:7796:5e91:58f0:8985]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-3ffbe3a6d8esm15084773fac.15.2026.01.14.07.19.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 07:19:02 -0800 (PST) Date: Wed, 14 Jan 2026 09:18:57 -0600 From: Corey Minyard To: Matt Johnston Cc: Andrew Manley , Corey Minyard , openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipmi: ipmb: initialise event handler read bytes Message-ID: Reply-To: corey@minyard.net References: <20260113-ipmb-read-init-v1-1-a9cbce7b94e3@codeconstruct.com.au> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Jan 14, 2026 at 10:10:34AM +0800, Matt Johnston wrote: > Hi Corey, > > On Tue, 2026-01-13 at 10:00 -0600, Corey Minyard wrote: > > On Tue, Jan 13, 2026 at 05:41:34PM +0800, Matt Johnston wrote: > > > IPMB doesn't use i2c reads, but the handler needs to set a value. > > > Otherwise an i2c read will return an uninitialised value from the bus > > > driver. > > > > This is fine, I suppose. It's probably better to do this. > > > > Are you actually using this code? How was it found? > > I'm not using IPMB, so haven't tested the patch on hardware. > We received a patch for mctp-i2c read handling, that made me notice  > the uninitialised value problem there. I had a look over other  > i2c_slave_register() kernel users to see if the problem was common > (mctp-i2c used ipmi-ipmb as a bit of a reference during development too). Ok, thanks for the history on this. It's in my tree. -corey > > https://lore.kernel.org/netdev/20260108101829.1140448-1- > zhangjian.3032@bytedance.com/ > https://lore.kernel.org/netdev/20260113-mctp-read-fix-v1-1- > 70c4b59c741c@codeconstruct.com.au/ > > Cheers, > Matt >