From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D94C211CAF for ; Thu, 15 Jan 2026 02:16:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768443390; cv=none; b=nWmsYv8eOaYphjuHq00rnK1H3yj9ZIjBZQJu1FK5Pm64nJiSFh/3Sq0JGVmMd5sbdk+DiTd3+RtCn+ILEdpvIZd83chiBI+AzLBs4V4+WpQVsGxyg89B0qK8RJTbnxmqdIyMy5BsxlIpOCfw1Ng6oEO09KsggC7ZDZzzOvV0zYQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768443390; c=relaxed/simple; bh=oX5+1uLOn8pPtzqRYnXngxMaYs3vqEhWezhWsGt68/8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OUho17yTUQepYZefF2BWG+RC93Jfzwz9UZQgzjus8b3Tcvd45+ibm1toAarlj91+onI61H4yl6gGvqxvrYlLC0XMx9sdM4kcZEPW/DkR73WJVLMH0GrgkIg0vVInCe5SvCilJ5mmVp4PzwrllVcqrJV4T7nSwXV2MxHFans5hoc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ly4cuAb+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ghD1Ekbk; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ly4cuAb+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ghD1Ekbk" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60EMggtM070606 for ; Thu, 15 Jan 2026 02:16:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=y6Nz50atGe4ppbMfJdSspqFK hDiCNfLuXTq78OiHIm8=; b=Ly4cuAb+gE5B+z36T4mwsz6tJmefkbZMWKV9iEWY /ofcZF55Hj+hjytzF0J6qWrAAuLwGAmVJUtporSSUMP6/p/j4THmQ7Rywi7jVBCc weQRzH3Bo9m7LYTyAWIFw/IiadUYkp48NR4EKg5nYdBXEeo/XZcCkmw+77ehiS5c 1V7YkTYgKGQe15k78tIbL4QsAerPJzMiygeQO9LuwHMO9x2l6o8OUL9BnNW3ZL3+ BRZeXBzGevBbIoI7taWWTn6c+L9/+VoxJsIPKZ1WJCbp/ctJ0vuOByJ9ul6DP/RZ 2cmn9CtZTZWt6SGdmRZnkygL9Y4L4mkqH1kwyzvdXT40Jw== Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bp8d3311f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 15 Jan 2026 02:16:26 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-2b062c1aa44so1244470eec.0 for ; Wed, 14 Jan 2026 18:16:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768443386; x=1769048186; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=y6Nz50atGe4ppbMfJdSspqFKhDiCNfLuXTq78OiHIm8=; b=ghD1EkbktMwpDhg/JJCfc1K/O6nNCVUU7qHHAT9mfreUOiBzzNEG9CDv4JRrJqTdzC W/wMg1sF9/Sx6scbT8Xaz4QnIANWb4wgpbWoonuaSwWHj4GfNnuIg7sKkJrg/XHRK4rl TVKD+uykxnncjnSbJ4X5t/P2wSSJ7e/2qFp2KWqyCsHtTvXopLLCL5wwoVV14SFmyf1v nZxjSIiwNivKEDBW7z6X4w6MQTT0q1Vm4cJZV1SxmDeiYosPuGHh5h2zEGG5cWNVM+sX tQLncxdCSPLojbIKaJHPWnN5YgBhQgLpRwJyScVxEQUNt7zmAoZoEPSYCQfqLF00MujC PeEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768443386; x=1769048186; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y6Nz50atGe4ppbMfJdSspqFKhDiCNfLuXTq78OiHIm8=; b=jfZBGYUKgclOMOGvI6IXcthBCHzateYHuEDd3sPy2I/IpNfy+joN0NHJybrAf0eYN+ F/CA0HoH+uVUbCpQNc/g8X43vN+npvtl8NI1stfKM6MH0iF/l9GYpVRpv7kBINqzGa0O 6oolYBhektz4T6WtAtdcV0Csn046wX41IdaWxRa+RVJNFETDiFHuh8U2lEtgoayeGL5/ XmftLCVpC1MchA0yyma02RT8SvobhH35dvVyObVWYfq3P8Zyv+Z/WnOluMwSBf71jBR1 vJsdaCn3A01GUjQndM3+klk6aiN42+MbAar8626IKRf8f96Ukig6KnyneONlP4v+fLBQ SfbQ== X-Forwarded-Encrypted: i=1; AJvYcCXtQlzBuMDUq2URwFCM24pUI5dN6H09t8UFCLk6KBOvTzqzyfJrShpMFbtHxHABqdm2VixOKVzoToajfSM=@vger.kernel.org X-Gm-Message-State: AOJu0YwE6ZzHtpIcygpxAsh82sUF74bLBx2qG3e4fdDljvzwlSEO2aB2 u6FBLiKu14w6w7rQ5OrIU6EWt6qpd4F/yvTmuDh3/bP5yNWYP35bAsZtWT4BCwZYbVYDiS3H5rg /4Wpu9PTX5cNQrCs5A8HR6aQln2r3c0TMSGypQdLKbVwMWNgLiJya0X7Br9nSffGRmc8= X-Gm-Gg: AY/fxX5nwSWuwzP7j9gWzNRUgZPT/LCGYE6TLBzEDwdAD4G1CF5eOKUY26pxiVyTbP5 WiQcswN/YJaYir66dSSC6t7tclk9Xe7QhBqCAUk1495dPJ3p/2Y/MQLdpMleP75T9xGOM2IIgwL nx3vow7Q/pVA+oTThmx6kiEdq9Bwk17UragYk2X+UKRWN4yyBiAUM2IKLdslcMZlG+HpKb+oAqW p/8USwo8CLG/C3fsT0AgrmrMeIhGYd3e0eyNutzNjrryqWf0wemawegBwOUU4xYny9lPUnbMjuW hi7TDkisHCHlMMIv8rciZ2Mm6bdhs0bLHYGHNp+wrBEhMm1botyR3zGKTAXczXCrpIN+GcOKedr PMm+mfVEFifABEa7KpScUKN8iRVV+FF2M/dUW08Y8vI84NBGwDfZ5m/5U X-Received: by 2002:a05:693c:3944:b0:2b0:580b:856c with SMTP id 5a478bee46e88-2b486f68038mr6473609eec.28.1768443385644; Wed, 14 Jan 2026 18:16:25 -0800 (PST) X-Received: by 2002:a05:693c:3944:b0:2b0:580b:856c with SMTP id 5a478bee46e88-2b486f68038mr6473559eec.28.1768443385055; Wed, 14 Jan 2026 18:16:25 -0800 (PST) Received: from hu-qianyu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b6a49173b2sm293974eec.31.2026.01.14.18.16.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 18:16:24 -0800 (PST) Date: Wed, 14 Jan 2026 18:16:22 -0800 From: Qiang Yu To: Krishna Chaitanya Chundru Cc: Vinod Koul , Neil Armstrong , Philipp Zabel , Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 0/5] PCI: qcom: Add link retention support Message-ID: References: <20260109-link_retain-v1-0-7e6782230f4b@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260109-link_retain-v1-0-7e6782230f4b@oss.qualcomm.com> X-Proofpoint-GUID: TXxHq3eCwR6JS7V7PiTwK5hcfhoNm5Xg X-Authority-Analysis: v=2.4 cv=fbWgCkQF c=1 sm=1 tr=0 ts=69684dfa cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=kj9zAlcOel0A:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=ietwBVO8KLLdgrj2ZJ4A:9 a=CjuIK1q_8ugA:10 a=6Ab_bkdmUrQuMsNx7PHu:22 X-Proofpoint-ORIG-GUID: TXxHq3eCwR6JS7V7PiTwK5hcfhoNm5Xg X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE1MDAxMSBTYWx0ZWRfX+P1gMbb8X/jl jU4cElM5M4XMlrKd6KanLTNkLC2CmE3B+BcD87EoIRparrSXexplDEdMruVcQY4n0hdnY9KBhij enclzsvabxSPbD1TRKFRPJmJ07CyKgY/6NBqHJJvf9Lhe0rzGnrhDfsVvo1BREVyJjrQZTVv9kd CSZT1ZZakfBTeTO35qbAN+hFbBwKDg2+5XMm/ie3JGzqo0hFjd1lKmf59qqp3GrRET7CcNyBbck rpK+hBXWxxf6OezNWbeKupVWXZ9WsiZi1hRry7YucoGDkmDwyigFY1JrfqbrMXSzBO8P4Glk+4X MS7Oh1UvIvISufqrtQ9raeEGncPJKwViL18IwWlNVYbBMp0KNXMyKdxtImqcxUcHYzC6AT97bKI 0vKaBGPY2nlS91SUk5PdICxIc9/DwAzweL8nFzzX7vW14Mrbg62Uds9N57Co/FRLaBJwtQfZvpe WMO4phq16Kd740VhL/g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-15_01,2026-01-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 impostorscore=0 phishscore=0 priorityscore=1501 adultscore=0 clxscore=1015 malwarescore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601150011 On Fri, Jan 09, 2026 at 12:51:05PM +0530, Krishna Chaitanya Chundru wrote: > This patch series introduces support for retaining the PCIe link across > bootloader and kernel handoff on Qualcomm platforms, specifically > X1E80100. The goal is to reduce boot time and avoid unnecessary link > reinitialization when the link is already up. > > We are not enabling link retantion support for all the targets, as there > is no guarantee that the bootloader on all targets has initialized the > PCIe link in max supported speed. So we are enabling for hamoa & glymur > target only for now based on the config flag. > > If the link is up and has link_retain is set to true in the > ithe driver config data then enable retain logic in the controller. > > In phy as we already have skip init logic, the phy patch uses same > assumption that if there is phy no csr and bootloader has done the init > then driver can skip resetting the phy when phy status indicates it is > up. > > Problem:- > 1) As part of late init calls of clock & GENPD(for power domains) the > framework is disabling all the unvoted resources by that time and also > there is no sync state to keep them enabled till the probe is completed. > Due to dependencies with regulators and phy, qcom pcie probe is happening > after late init which is causing the resources(clocks & power domains) to > be off which causes the link to go down. To avoid this we need to use these > two kernel command line arguments (clk_ignore_unused & pd_ignore_unused) > to skip disabling clocks and gendp power domains as part of late init > for initial version. Once it is resolved we can avoid those kernel command > line arguments. > > Signed-off-by: Krishna Chaitanya Chundru Tested on Hamoa QCP and Glymur CRD, so Tested-by: Qiang Yu > --- > Krishna Chaitanya Chundru (5): > phy: qcom: qmp-pcie: Skip PHY reset if already up > PCI: dwc: Add support for retaining link during host init > PCI: qcom: Keep PERST# GPIO state as-is during probe > PCI: qcom: Add link retention support > PCI: qcom: enable Link retain logic for Hamoa > > drivers/pci/controller/dwc/pcie-designware-host.c | 11 ++-- > drivers/pci/controller/dwc/pcie-designware.h | 1 + > drivers/pci/controller/dwc/pcie-qcom.c | 62 ++++++++++++++++++++--- > drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 28 ++++++---- > 4 files changed, 83 insertions(+), 19 deletions(-) > --- > base-commit: fc065cadc7ed048bedbb23cb6b7c4475198f431c > change-id: 20251001-link_retain-f181307947e4 > > Best regards, > -- > Krishna Chaitanya Chundru > >