From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96434200113 for ; Thu, 15 Jan 2026 04:37:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768451870; cv=none; b=JUXJkW7J7TiD+f8ap2xgbUWU5Vdes4fGzfRt9jY4rduUhf4wh97vIxghKIGBJKPElyezltpn1CUtXYt8z0JlZXOLi1xKxnt9E+cXNHvA/wHfzmGCisoUxpzLoS3NNR558tEQiS14GER0RvETgxEV5YZ2tccUxbXCGwHYFRZGXT4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768451870; c=relaxed/simple; bh=pDLAKZB6J7+d7eBy0h9BbbneTq4WiyoTYvGvurkMWrM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gABXRv626rxd8WyweeWM/8LCL3kPWCGxGz1i3ZNQAImVwfZUbB5dBjHit06xmK4AJJiSjwmt5R/pwp0m8b2FE7FiRBbMZMKNKdlr1SH5SLwyfMS63dyVEsmAEQLAQLBqdwHMUFzZFf70rkZ4SyTn2eBYIHnXcf7zkpA5wZqjTAY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OszbFnh5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OszbFnh5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69A8EC116D0; Thu, 15 Jan 2026 04:37:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768451870; bh=pDLAKZB6J7+d7eBy0h9BbbneTq4WiyoTYvGvurkMWrM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OszbFnh5GntzFMTmURhdH00no/DdSPq5ojPZIg8OQY++Lr0+Dy8dOCjjzNJpgVesZ ObWzTRdVgM+wftKEtboCeWPtpL7Ak8DbH7bD1kNJQ9elND8Iwj7IcvfRvK1b+ak9bd fVj1jcsQPtur7s3uHqa2PWAwqTej+NnTyYu7QJnH+xTORukbAEeWFUZCTPGv7Ihnqz jv1bJbrJiYY2zoGl4MnHeqANvOJw7QvrepEuRDb/Y5PnTa1miFUKUxw4u9cHt5eW/G MylGLQlQIxF+cUY169cgCHdKGeycagaBELzBnMEESP8JD1J+WPGfBvLHiAVMeBforo yzW1kMEoANFEw== Date: Thu, 15 Jan 2026 10:07:46 +0530 From: Vinod Koul To: Aleksandar Gerasimovski Cc: "linux-kernel@vger.kernel.org" , "kishon@kernel.org" Subject: Re: [PATCH] phy/marvell/phy-mvebu-cp110-utmi: fix dr_mode property read from dts Message-ID: References: <20260106150643.922110-1-aleksandar.gerasimovski@belden.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 14-01-26, 09:58, Aleksandar Gerasimovski wrote: > Hi Vinod, Hi, Please do not top post Would you good to review the Documentation/process/ docs to understand the process and expectations here. > > Thanks for looking into, can you be more specific with your comment? Your email footer asked me to ignore, I have done that! > > Regards, > Aleksandar > > > > From: Vinod Koul > Sent: Wednesday, January 14, 2026 10:48 AM > To: Aleksandar Gerasimovski > Cc: linux-kernel@vger.kernel.org; kishon@kernel.org > Subject: Re: [PATCH] phy/marvell/phy-mvebu-cp110-utmi: fix dr_mode property read from dts > > On 06-01-26, 15: 06, Aleksandar Gerasimovski wrote: > The problem with the current implementation is that it does not consider > that the USB controller can have multiple PHY handles with different > arguments count, as for example we > > On 06-01-26, 15:06, Aleksandar Gerasimovski wrote: > > The problem with the current implementation is that it does not consider > > that the USB controller can have multiple PHY handles with different > > arguments count, as for example we have in our cn9131 based platform: > > "phys = <&cp0_comphy1 0>, <&cp0_utmi0>;". > > > > In such case calling "of_usb_get_dr_mode_by_phy" with -1 (no phy-cells) > > leads to not proper phy detection, taking the "marvell,cp110-utmi-phy" > > dts definition we can call the "of_usb_get_dr_mode_by_phy" with 0 > > (#phy-cells = <0>) and safely look for that phy. > > > > Signed-off-by: Aleksandar Gerasimovski > > --- > > drivers/phy/marvell/phy-mvebu-cp110-utmi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/phy/marvell/phy-mvebu-cp110-utmi.c b/drivers/phy/marvell/phy-mvebu-cp110-utmi.c > > index 59903f86b13f..dd3e515a8e86 100644 > > --- a/drivers/phy/marvell/phy-mvebu-cp110-utmi.c > > +++ b/drivers/phy/marvell/phy-mvebu-cp110-utmi.c > > @@ -338,7 +338,7 @@ static int mvebu_cp110_utmi_phy_probe(struct platform_device *pdev) > > return -ENOMEM; > > } > > > > - port->dr_mode = of_usb_get_dr_mode_by_phy(child, -1); > > + port->dr_mode = of_usb_get_dr_mode_by_phy(child, 0); > > if ((port->dr_mode != USB_DR_MODE_HOST) && > > (port->dr_mode != USB_DR_MODE_PERIPHERAL)) { > > dev_err(&pdev->dev, > > -- > > 2.34.1 > > > > > > ********************************************************************** > > DISCLAIMER: > > Privileged and/or Confidential information may be contained in this message. If you are not the addressee of this message, you may not copy, use or deliver this message to anyone. In such event, you should destroy the message and kindly notify the sender by reply e-mail. It is understood that opinions or conclusions that do not relate to the official business of the company are neither given nor endorsed by the company. Thank You. > > > Okay destroyed! > > -- > ~Vinod > > ********************************************************************** > DISCLAIMER: > Privileged and/or Confidential information may be contained in this message. If you are not the addressee of this message, you may not copy, use or deliver this message to anyone. In such event, you should destroy the message and kindly notify the sender by reply e-mail. It is understood that opinions or conclusions that do not relate to the official business of the company are neither given nor endorsed by the company. Thank You. -- ~Vinod