From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE0043A0B16 for ; Thu, 15 Jan 2026 13:56:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768485418; cv=none; b=M/NoluhX8zNA3wrsAfeV0m0mHaxgeVzFVit/7xTuVgbs0oM1x649pdhL2zXaZ8u9+9+TrPB/ZNPycLaOzL6zEXQHT/0rK54WJVKAcXdldddwkbWhHCGIt2Ff7jg4meJ5Q+3gw0bIxB/yeTGbygXdVRFDKEQZEUYJE+d4TYUPpfw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768485418; c=relaxed/simple; bh=FnyOTPf4m8Mp4nl4SL3AW2LPS9qsrPeFd58UUFtyVMc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bExhsDEKXGIVx4MY55lcELcf3hfd9W9twNXZbLc+EgoZ4J1uq/ZvWx4mmWj1dBk6QKRVnJI+v2HUQlWRqQUdo4l8k7krdT6I1zt2qBEEfFeZbTofbfT8x4lG0wXxbSRJ1sHNjaFk+ODXBfiX4YC7zr3RsfoNt3uk08N1t7vUxLY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Z68PYJjA; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Eye+PD0n; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Z68PYJjA"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Eye+PD0n" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768485415; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+ane5kaNtNeusJK518LJGVJnPrrb1Tm+pD0hxe99rrg=; b=Z68PYJjA0mAbT66b231audfFaUuMsdCDew/LC4SmO0vvJbhRIApg4b1gH3p1Yg6H93JPXZ RDcK8SF1fhU6EeuesCpTm4TABn0U2kSSw7qCOKXYm4P/PMAVmu3cnLUsYaeejfNUD6SwwW yu5YLKWxXpunmS5K2WXLZE7UbyebZ7M= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-606-MB7uLXqoPCeDQhH2G5PSrQ-1; Thu, 15 Jan 2026 08:56:54 -0500 X-MC-Unique: MB7uLXqoPCeDQhH2G5PSrQ-1 X-Mimecast-MFC-AGG-ID: MB7uLXqoPCeDQhH2G5PSrQ_1768485413 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-477cf2230c8so8401475e9.0 for ; Thu, 15 Jan 2026 05:56:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768485413; x=1769090213; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+ane5kaNtNeusJK518LJGVJnPrrb1Tm+pD0hxe99rrg=; b=Eye+PD0nzTF7q1K4usE00+yYrisc3fH33vYcZQ14pYcU+6C7ThqRgGyeCvPbIWWuWQ 3ZdsMJT69CDmYUJmPEBVq20quXTPgunxrtmdNXsoi4VFBwOsA7OxHPnEXg+VAf9Yh4R7 a63zNmnPxGktFQfjZDPGlB9VEtwWM/JoQBiiKsQHqFaMZ6Nj6Fn1XM2XubCoSvU/H9fF 62g56v7uVICfC5STTPYR6htMH46DBp/+9dMmpeF5KbP+kXCYnpXo30iVwPTjY4GdA+MZ rEzeZjafdCwXe37T4PqGMiDI+ZYuO/ZUjpuBabpSg7KEcX3MnqG8nDeG2rJuVWfpdVtC rRWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768485413; x=1769090213; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+ane5kaNtNeusJK518LJGVJnPrrb1Tm+pD0hxe99rrg=; b=f7bQ0hs0Cd8vUoIxy6PZ/6U0AvoGENojgWdSQVvqOHuHjVn5rMbneVkxotWqACEnlX VH0hIXvVsSoMnLm+GRVdWyL7mZl37Ef1HeucwVwQEyK0Lxy4nDFyhCroYSjCXC9Vq3p7 oPiChSsHQEehorkWdDSXXQVoygEJaB76IgnAdhRomPNYx/zC49iDTXDVhOVnvFFFN7yb bRmU7n1l73uwI1thbWR9oVdCgio2PXaGPa//qcZFTi4Bm6FB0BFrE+0ICS5kMCj6PvrU kPHkAstBxNyGOlU8PbjkHc5NQ/icUW7yj56t9ohLmOirfFrdciVB8CwYqkZezPbYykGi Z7sw== X-Forwarded-Encrypted: i=1; AJvYcCUPFM9uIePSu6+E6DE5KquTRWhBblUhImlgbCrHPESht+LO1enUKCpCsOpkAEqb7mzYsjoWzMUZixKGUao=@vger.kernel.org X-Gm-Message-State: AOJu0YzLw+vvP5y0G4LPFt6mwfMXV5pEiFhbjHZ5MijXYo3eRsyQ1lbH /vZyKmOZ3NkS7LP6T1ShvPMb/ehswjuOJ0x0mFgGhOsB6mPsAoF5fMpvswGxxN+Y7TGKXVj1IgZ 8vIJjHSBe6VcFRIlM0iYcWhu/u8wIvl4NW1QPK9gpeKl58l35wMkWJAngNbB8KGGTuA== X-Gm-Gg: AY/fxX47hSxvH0fIY8xXjV3WzFsBmaA2sYL7xf18m1AZf3oSWcmwmFjWgpx5IJjUsX/ JvPSqV/ml1OK2E4nIOH/Y6CaoyusnLtPEKyweqslvwmIkpn+YmycOy55gRoMpW2OtwmsSINnjZF RZI6wnaS+2VnvGQ9MpJPKCD7hvKlq7kbivk3xpxjs/MF3092dPdkSs/cSed7Gae9vG2XepnXyIC lutbZLplFG7ud/UDRiPQwF1g8uKchrF5XRFWjTRkGOPLsLJA/lBg/NwwBLZNbagaeWkqEPYAIeH qWZGjoPmR6GS0ggruL8LX1E/iI8SoOj87npzViuV5kfdjUSZbN8Ey39+TnzTd6GTX9cgIw8gUyG AMEMwT8dqNskoqBtIWxANgZOZ81y7mq4q4jytXmKG X-Received: by 2002:a05:600c:5287:b0:465:a51d:d4 with SMTP id 5b1f17b1804b1-47ee32e07c3mr82027425e9.6.1768485413202; Thu, 15 Jan 2026 05:56:53 -0800 (PST) X-Received: by 2002:a05:600c:5287:b0:465:a51d:d4 with SMTP id 5b1f17b1804b1-47ee32e07c3mr82027055e9.6.1768485412762; Thu, 15 Jan 2026 05:56:52 -0800 (PST) Received: from jlelli-thinkpadt14gen4.remote.csb ([151.29.129.40]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-434af6535ddsm6044623f8f.15.2026.01.15.05.56.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 05:56:52 -0800 (PST) Date: Thu, 15 Jan 2026 14:56:49 +0100 From: Juri Lelli To: Pierre Gondois Cc: Peter Zijlstra , K Prateek Nayak , tj@kernel.org, linux-kernel@vger.kernel.org, mingo@kernel.org, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, longman@redhat.com, hannes@cmpxchg.org, mkoutny@suse.com, void@manifault.com, arighi@nvidia.com, changwoo@igalia.com, cgroups@vger.kernel.org, sched-ext@lists.linux.dev, liuwenfang@honor.com, tglx@linutronix.de, Christian Loehle , luca.abeni@santannapisa.it Subject: Re: [PATCH 05/12] sched: Move sched_class::prio_changed() into the change pattern Message-ID: References: <717a0743-6d8f-4e35-8f2f-70a158b31147@arm.com> <20260113114718.GA831050@noisy.programming.kicks-ass.net> <20260114102336.GZ830755@noisy.programming.kicks-ass.net> <20260114130528.GB831285@noisy.programming.kicks-ass.net> <20260115082431.GE830755@noisy.programming.kicks-ass.net> <20260115090557.GC831285@noisy.programming.kicks-ass.net> <21da68c5-e6ec-4ffd-81eb-e1fda13dd7af@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21da68c5-e6ec-4ffd-81eb-e1fda13dd7af@arm.com> On 15/01/26 14:13, Pierre Gondois wrote: > Hello Peter, > > On 1/15/26 10:05, Peter Zijlstra wrote: > > On Thu, Jan 15, 2026 at 09:24:31AM +0100, Peter Zijlstra wrote: > > > On Wed, Jan 14, 2026 at 03:20:48PM +0100, Juri Lelli wrote: > > > > > > > > --- a/kernel/sched/syscalls.c > > > > > +++ b/kernel/sched/syscalls.c > > > > > @@ -639,7 +639,7 @@ int __sched_setscheduler(struct task_str > > > > > * itself. > > > > > */ > > > > > newprio = rt_effective_prio(p, newprio); > > > > > - if (newprio == oldprio) > > > > > + if (newprio == oldprio && !dl_prio(newprio)) > > > > > queue_flags &= ~DEQUEUE_MOVE; > > > > > } > > > > We have been using (improperly?) ENQUEUE_SAVE also to know when a new > > > > entity gets setscheduled to DEADLINE (or its parameters are changed) and > > > > it looks like this keeps that happening with DEQUEUE_MOVE. So, from a > > > > quick first look, it does sound good to me. > > > If this is strictly about tasks coming into SCHED_DEADLINE there are a > > > number of alternative options: > > > > > > - there are the sched_class::switch{ing,ed}_to() callbacks; > > > - there is (the fairly recent) ENQUEUE_CLASS. > > > > > > Anyway, let me break up this one patch into individual bits and write > > > changelogs. I'll stick them in queue/sched/urgent for now; hopefully > > > Pierre can given them a spin and report back if it all sorts his > > > problem). > > Now live at: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/log/?h=sched/urgent > > > > Please test. > I don't see the balance_callback or the double clock update warnings > anymore. FWIW (as I wasn't seeing the reported issue) I had a look as well and tested locally. Patches look good and nothing to report on the test side. Thanks! Juri