From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B709328B78 for ; Fri, 16 Jan 2026 01:21:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768526488; cv=none; b=PFLX6GptV3CF+Cv2jxeDAFJZVydCIVFDry/JzgF6fAxx2Swe0ZtfeTgpONZL7GGk1svi+RBIw+lbQ0kKgbSv7KzQQK1why7igIvlf9vxF3SlGHshXVx02Kd/5brdCMaEx7VrqwPKWsMi+mpr/JGrEgrHG9L62nRLppEMh9iXMdE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768526488; c=relaxed/simple; bh=WVAFk/G9Jae2iegxU72AI5Nf1GESFNgXZ0s6CTi6AQM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RLeRgis4BMHOrhlPNsHnmI00+UvRXriiaSQBYkq8s7dSTwyOqAC36kC691Ny0HSMCZz90g+GsJkYfrw74JtNOVlBqCBqUjkvnPhrSo6hvO4hOy5MEzwLETB4utof1OR5q1sFiIyXQdyUb6XSqOV0EAQChMc6WSslIkS/4+HyPNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TMJOS1ei; arc=none smtp.client-ip=209.85.160.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TMJOS1ei" Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-40413188553so1039971fac.1 for ; Thu, 15 Jan 2026 17:21:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768526477; x=1769131277; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wFG3gVNxJD7Ap7fJ1CZDygWmut6qTFwFZjaDYw553m8=; b=TMJOS1eiQ7XuS4PzAji5vPfT+4Ks9lOlOQYNocCALs+RD4Ou811TnIHKjyuz72EhdF z/IZodI9I4tCyKdgL9XSxfhfQ/uX4qOH4ky68HbaR6dZmMDDUFW4fy/KB2d8RDkFaoHL Qfv6Q+CXPqoj2w2h2MNrt7lvLyKH7EwWf7250bMKvHMYvg6SBmI65rMEEbroZaLRjfsV Y6+nx4A0CdmZMLetqyQPEEPDDbzNbGWuDcyNcc26cFVNi2GdhRWnH5/i3iJMFRncG+fV DoDu3+HheULFm4M0TmmaawO9zThZfwZafK3JLuWeyAKfvScvo9yjp1k7nm+CCoHmR4ip Fa0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768526477; x=1769131277; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wFG3gVNxJD7Ap7fJ1CZDygWmut6qTFwFZjaDYw553m8=; b=vtL3fmZJtWuG9WLxIKgIlrM1S6jPNS9fhzs+DxUEcB0fi6oZb6k+LtwDuedQhNWxcD XYqtTt29u4sQ3Pz96GIP/YpIlM1LomD9/sOffTuYYB0VCrDjZnAqPojrnhX823Kej/gl TN5sBRODtauhwsK0AQDrhXZcGjpzk6Xf/AQ4I7MRAK3YO6WkP9L/Hka+yQqU3Rcn87si WPkLi5zMOHePr+IBeyKuOocKt3fWyiTJaYuA2oVm/0h0Jbg0jDdLQVxhrTIsh2kExw6u TMH+u8n52OBwBPpb/2MeABEFcb8tJhGJUHPCkAA6iBoAEJmcce4vsgpSfsJmmli7BJo9 QDBg== X-Forwarded-Encrypted: i=1; AJvYcCUk9vlp/M7sSlg2P2jWESssRN2khv7SXPvwkaGhKlMSlGbszuo6inRYYomzxX8lYGmjuzEU/EBjL9uteQ0=@vger.kernel.org X-Gm-Message-State: AOJu0YwHiMnyDv5qoPS9mgSTF4s25rpLqNczsrDqP7MhctjS0wJ1jpeY qh2V8QkeB+lY4sGxkF4h7Lxt9ETt/WvDJlrX0q1NAGJSYeOiAQesISoOAOp4uQ== X-Gm-Gg: AY/fxX7dhTYfa0dqdo2zozEhZ5biz1LIaFEDptYKpkLLInsn7hfuyerkpZuqTqmtdKM afXXcuNE/lJefKob0zSiXxTfVr4MuTSdmAvhz+j0Ebf2U03cRRjbhqboIhGMVauDxz2NSb+rAvx qWP3pArPzbD8zsJJVU2mZlrmw/aigl2Ghjjz8RyiUhyfcwKAK7VJQIr/xsUAVEznCDdENPZeIL/ K0LXnuaxXaTIkT5XmS3KhjqYdiBKP06M+rYqloCtWpsE0unrSgFXDDa9XIKjv+d/oKND9GvcCG+ uyfF5BEodu2AUAjDBB0IxqgWPYwivI0oSMJgQujLXxGwkKSk0RPEZFPNY5PATZnQBrCmMohaWkq 9+75QqfmCIFS2m/Vi48bTo92InBNJM9JifLmGy6DQzGxBeO429H/c/zLw+QJPY+p0pWuB5/EpEH TvgWny3j/7uXdm9A8Dk+xY X-Received: by 2002:a05:7300:6ca1:b0:2b0:5079:d3c8 with SMTP id 5a478bee46e88-2b6b3f139f5mr1020729eec.4.1768520046558; Thu, 15 Jan 2026 15:34:06 -0800 (PST) Received: from localhost ([2001:19f0:ac00:4eb8:5400:5ff:fe30:7df3]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b6b3696f40sm696762eec.35.2026.01.15.15.34.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 15:34:06 -0800 (PST) Date: Fri, 16 Jan 2026 07:34:01 +0800 From: Inochi Amaoto To: "Anton D. Stavinskii" , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen Wang , Inochi Amaoto , Jaroslav Kysela , Takashi Iwai , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org, sophgo@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH 0/8] ASoC: sophgo: add CV1800 AIAO mux and I2S support Message-ID: References: <20260115-cv1800b-i2s-driver-v1-0-e8b22b8578ab@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260115-cv1800b-i2s-driver-v1-0-e8b22b8578ab@gmail.com> On Thu, Jan 15, 2026 at 11:17:37PM +0400, Anton D. Stavinskii wrote: > This patch series adds basic audio support for Sophgo CV1800B, > as used on boards such as the Milk-V Duo. > The series introduces an AIAO audio mux driver, > an I2S controller driver, corresponding DT bindings, > and DTS updates to wire the components together. > I haven't see your mux driver, is it missed? > The implementation is based on vendor documentation > and testing on real hardware. This series relies on > recent fixes in the DesignWare AXI DMA support; > in particular, correct operation depends on > the DMA changes discussed at: > https://lore.kernel.org/all/20251214224601.598358-1-inochiama@gmail.com/ > The current driver implementation supports a fixed audio configuration > of 48 kHz sample rate. The series has been tested on the > Milk-V Duo 256M board using the Sophgo SG2002 SoC. > The implementation is expected to also work on Milk-V Duo and Milk-V Module > boards based on the SG2000 SoC, as the audio > and DMA blocks are closely related. > > Known hardware limitation: > On CV1800B / SG2002, the I2S2 output pins cannot be enabled via pinctrl alone. > Due to SoC design constraints, the output path becomes functional only after > additional vendor-specific register programming. > This series makes the limitation explicit and does not attempt to work around > it implicitly via pinctrl or undocumented behavior. > > Signed-off-by: Anton D. Stavinskii > --- > Anton D. Stavinskii (8): > dt-bindings: sound: sophgo: add CV1800B I2S/TDM controller binding > ASoC: sophgo: add CV1800B I2S/TDM controller driver > dt-bindings: sound: sophgo: add CV1800B internal ADC codec > ASoC: sophgo: add CV1800B internal ADC codec driver > dt-bindings: sound: sophgo: add CV1800B internal DAC codec > ASoC: sophgo: add CV1800B internal DAC codec driver > riscv: dts: sophgo: dts nodes for i2s tdm modules > riscv: dts: sophgo: add Milk-V Duo 256M board dts > > .../bindings/sound/sophgo,cv1800b-i2s.yaml | 75 +++ > .../bindings/sound/sophgo,cv1800b-sound-adc.yaml | 43 ++ > .../bindings/sound/sophgo,cv1800b-sound-dac.yaml | 43 ++ > arch/riscv/boot/dts/sophgo/Makefile | 1 + > arch/riscv/boot/dts/sophgo/cv180x-dmamux.h | 57 ++ > arch/riscv/boot/dts/sophgo/cv180x.dtsi | 49 ++ > .../boot/dts/sophgo/sg2002-milkv-duo-256m.dts | 231 +++++++ > sound/soc/Kconfig | 1 + > sound/soc/Makefile | 1 + > sound/soc/sophgo/Kconfig | 41 ++ > sound/soc/sophgo/Makefile | 5 + > sound/soc/sophgo/cv1800b-sound-adc.c | 322 ++++++++++ > sound/soc/sophgo/cv1800b-sound-dac.c | 204 ++++++ > sound/soc/sophgo/cv1800b-tdm.c | 714 +++++++++++++++++++++ > 14 files changed, 1787 insertions(+) > --- > base-commit: 7a52965b6976c936f413eebeee3f78c6faf09012 > change-id: 20260115-cv1800b-i2s-driver-4f17836dec56 > > Best regards, > -- > Anton D. Stavinskii > Thanks for your patch, for all the patchs, I hope you write a meaningful comment for the patch, at least for now I found it is nothing in your comment. Also, the patch 8 should not in this patch and should be a separate patch. Regards, Inochi