From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BADF935F8B0 for ; Fri, 16 Jan 2026 10:11:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768558290; cv=none; b=TKUyu5NTbr04lOsFc/rYBmluMMPOZEbPkj60hqt2+BqtKZDr2K4KJoJ6NK0wKoiJ6JdbJI2rMSbDKZ9Tk9LbzIGxSVZNxJCCcMeOtAbn4TdOf3FoQ7/mrwPE2LU22RIXoMdXxPadkcdAn69vEgNO6D5qro3MKX3hjoU0sh2DeSI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768558290; c=relaxed/simple; bh=GvKTSXpSnV61qIeIj7djXSRQdMUqOq9sB7I5GfaTK/E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=W9kyqN2Dt7MVXy6vRk3DqwiI7uc9/G1TfmVArJ7XskruA7wZ2wMIGpKAt5ayUXTEl4aDSL2n7pZA3Tymvtc4efxDxsygftL9l7HB18Yn2EH+M9VT70gHY4YsKI+L5hLH2swdPzLiCdzen4kfdsPy4YklpQB6/WDDVrkI0ANiL6A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=A7BOVrZc; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=SguTFJKn; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="A7BOVrZc"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="SguTFJKn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768558286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PYdYs09o1BdUi4chDtWqrhvtiarKfR63xIzMRlbqh6g=; b=A7BOVrZcSOj8NtR1qeEtI0L0SXcEF22LYwdmkdics4UTOD1aYlpGGzn9LRpZtuIrEi8Vkk z59VVikqaeDdvqSKmB/JoduO0pJVyXrktQYwhQp5qob3yCHw33DnFbIGoIAwudrNewFzf3 Ah3uWYLC9pM7IjrBi2/Q/VGnQbedQxA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-193-loUSoeLSODiYjfroEXggPg-1; Fri, 16 Jan 2026 05:11:25 -0500 X-MC-Unique: loUSoeLSODiYjfroEXggPg-1 X-Mimecast-MFC-AGG-ID: loUSoeLSODiYjfroEXggPg_1768558284 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-47edc79ff28so10216855e9.2 for ; Fri, 16 Jan 2026 02:11:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768558284; x=1769163084; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PYdYs09o1BdUi4chDtWqrhvtiarKfR63xIzMRlbqh6g=; b=SguTFJKn50YAKa86lhueg5kezwUXRjoOu3hY7Pjw9Y4Rbc6TcaRRm3drqTqhXguBqn Cnk2E4BvDMOtzuFutNwcHBhprztlLjEKdfmWV5r+W2eNInjs7Wp4h/OduCXEbQtUVkUL VoypiLNhVlpuQIK6Wa+z5ms3+MaToSYfsKlxgDNOUMAjX9hoA+8aNuL6vCrD/vlTbWVI h7/bIq+NblObGEJH4n0pD8xfc9OQ0KQYvmWUChZ67t2bj3xqWv6VyNc88wk7shOw4aiG FJh1fhs3LIlZATygoIHMAFIn7E8WH9LGBfFGOMuSTEIJRhDGn6mCmXXkOTFR2COFYYTN 4KFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768558284; x=1769163084; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PYdYs09o1BdUi4chDtWqrhvtiarKfR63xIzMRlbqh6g=; b=fCutFSylD7ykKOUhG0Pc1b7rQLC/Q8j7DVUDdl/X9hFxUAbFw6fKcSmJJBEics9MF5 QRIf2yZqJTlVjhT1WoAWSjjj3iNPlMGzKrw9cO9QrxNpHaHCkN3dLXq9e1dDEUcl73qW Ly3bcHYGejzdmXk3fqq4q7GDgbWHqIv5BpuYVluFXQ+rccJ8MSHwPFOFKIl00E81QQlJ VZvoMjSTux0A4udDLCElTyHvnq2JhA71NGrxy0krRym0jFJYd0F5v7SLpD6cc8PeUE9b LOmiKpeTbcsP//5MpFoOj2RK05hiE0B4S2qztoOoBjnyVImB2dkwO3sUUwVvKk/rL89b LVQg== X-Forwarded-Encrypted: i=1; AJvYcCVSHseC7gkD9hXAWigD/4oA0FosTyvFqYioPd+jaOmM2UQVarZcQ/My0txk4tsnOIrreJf4RgRF4W3NpUg=@vger.kernel.org X-Gm-Message-State: AOJu0YysIHd84zH/DCJmDIbwN5kvAqI+eOd4+d8YzG5/0xYaK1dM4lBz kXfftsNyWpML+OhIGgNVzyW/DSPpcHwqTfjsMXhda2hWdzBBhCMlgzUojCbtgu6OAC7RuWbZZxH XGP0ItSG8SRiAP79IxizdFL71cLsuszRAry/QPVboJ89J4rnerG6cb3MU2IaiUZ4ypg== X-Gm-Gg: AY/fxX5diOZpXt8KJLFQEyM//MfXLC3iZmeydz5IM4aD+2WsE0K1nM+0xo8xig/1OLs Dt5A0WD89P11lTVHKO6aptQZ7BxaGHi/l9CVt5sKWvTwEoh/lNU60uB40FG29cXT11t5xgvX8Iy iT+5CVGLUZAPSdm6ID287vIysW3szWRHcNvIb/ZpHDJCxcHMDioe3JYP4L3EtXoc5XTaAlFYjCh Cob1cGGUZvrwX2ftzUMjmvsQiC1n9lO9E75IcDuPZwG0I0LxV4Zyd7yDv8gAXOfRSEGFByKVGUB J279ldnGS8sX4uTQFSvzljSmcWHrMAaFjMPiY7dMamrJXtbPzTYXKDJEiPNAR2fwxk18sg8mLvw 4Z4ku/Blkjv/gwLMUZIFPaxDZsP9FeJDjvaeuxk/ohMTSelc6GzxMfQhd3Jo= X-Received: by 2002:a05:600c:c178:b0:477:a977:b8c5 with SMTP id 5b1f17b1804b1-4801e34cd0emr32517715e9.31.1768558283731; Fri, 16 Jan 2026 02:11:23 -0800 (PST) X-Received: by 2002:a05:600c:c178:b0:477:a977:b8c5 with SMTP id 5b1f17b1804b1-4801e34cd0emr32517485e9.31.1768558283318; Fri, 16 Jan 2026 02:11:23 -0800 (PST) Received: from sgarzare-redhat (host-82-53-134-58.retail.telecomitalia.it. [82.53.134.58]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4801e8d90b3sm35848465e9.15.2026.01.16.02.11.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 02:11:22 -0800 (PST) Date: Fri, 16 Jan 2026 11:11:20 +0100 From: Stefano Garzarella To: Michal Luczaj Cc: Luigi Leonardi , Jakub Kicinski , virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] vsock/test: Do not filter kallsyms by symbol type Message-ID: References: <20260116-vsock_test-kallsyms-grep-v1-1-3320bc3346f2@rbox.co> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260116-vsock_test-kallsyms-grep-v1-1-3320bc3346f2@rbox.co> On Fri, Jan 16, 2026 at 09:52:36AM +0100, Michal Luczaj wrote: >Blamed commit implemented logic to discover available vsock transports by >grepping /proc/kallsyms for known symbols. It incorrectly filtered entries >by type 'd'. > >For some kernel configs having > > CONFIG_VIRTIO_VSOCKETS=m > CONFIG_VSOCKETS_LOOPBACK=y > >kallsyms reports > > 0000000000000000 d virtio_transport [vmw_vsock_virtio_transport] > 0000000000000000 t loopback_transport > >Overzealous filtering might have affected vsock test suit, resulting in >insufficient/misleading testing. > >Do not filter symbols by type. It never helped much. > >Fixes: 3070c05b7afd ("vsock/test: Introduce get_transports()") >Signed-off-by: Michal Luczaj >--- >man nm says: 't' stands for symbol is in the text (code) section. Is this >correct for `static struct virtio_transport loopback_transport`? I'm not an expert, but yeah I was expecting "d" too, but maybe since it's static and built-in will be in the text section? BTW I just checked and for example on my 6.18.4-100.fc42.x86_64 I have: 0000000000000000 t sock_fs_type 0000000000000000 t proto_net_ops 0000000000000000 t net_inuse_ops And they are all static structs of built-in modules. So it seems it is common. >--- > tools/testing/vsock/util.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks for the fix! Reviewed-by: Stefano Garzarella > >diff --git a/tools/testing/vsock/util.h b/tools/testing/vsock/util.h >index 142c02a6834a..bf633cde82b0 100644 >--- a/tools/testing/vsock/util.h >+++ b/tools/testing/vsock/util.h >@@ -25,7 +25,7 @@ enum transport { > }; > > static const char * const transport_ksyms[] = { >- #define x(name, symbol) "d " symbol "_transport", >+ #define x(name, symbol) " " symbol "_transport", > KNOWN_TRANSPORTS(x) > #undef x > }; > >--- >base-commit: a74c7a58ca2ca1cbb93f4c01421cf24b8642b962 >change-id: 20260113-vsock_test-kallsyms-grep-e08cd920621d > >Best regards, >-- >Michal Luczaj >