From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 917A82D661C for ; Fri, 16 Jan 2026 15:29:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768577370; cv=none; b=KZiO1hBxJ9RtFcfIphkfcVaTX7xXqIAiKrhqnKfAMJOaEI9qmY/p+ndxyla2PKaEK20C3nWzopCfUYpUmW8xjZKGwUhpdLyjULkNspZMeualvNfQOKH/Ibqd5yLKVxMlxd2Jj+/AqbVQPxisJef98b6WB2Cf96k51pvjP5CSKd0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768577370; c=relaxed/simple; bh=sSSS54Xj0ShsXOZuK37+sEwwv3XAEF1W6I/qaNYc2oE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Y94RVeNYueczmJlN0mGkLfaikM+56wchO8aMxJHcL49RgcobnGofGo3v55EvcrsV+xRxSd5FFLSUOMoxGZLWQhWPcNjTggnx1k4kb5Z+HiMl2tc6y2JeZEFvV37UBzyYSV5HvUL5UOPrDsSl1kbwcAvB6YTWBZ72K4qdoAoBWr4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=I4CReuRj; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=QWmDJhWi; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="I4CReuRj"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="QWmDJhWi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768577367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HcYNjtrM1tx5MNCL5NpuqMAZtAxO/Nx7W07L/efi2Ek=; b=I4CReuRjzgSaiXRkNYZJmkNae0ZWwbaz6HBvMbwpWlVr4yMxoNDshnfMq+ENAIVpcO9NC0 4gVXVoHp+bfeJDvehoSxeAHub22cS1zYft43km0nQf8chxAOM/wY6KNNnI5zY2Q6lAaKio D5r2DqXQ0b1jsAWEoqAaeKYoT6XTEMw= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-76-OLnDC9ycPEaqmpqB9ONoZQ-1; Fri, 16 Jan 2026 10:29:26 -0500 X-MC-Unique: OLnDC9ycPEaqmpqB9ONoZQ-1 X-Mimecast-MFC-AGG-ID: OLnDC9ycPEaqmpqB9ONoZQ_1768577366 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-88a316ddbacso52478246d6.2 for ; Fri, 16 Jan 2026 07:29:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768577366; x=1769182166; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=HcYNjtrM1tx5MNCL5NpuqMAZtAxO/Nx7W07L/efi2Ek=; b=QWmDJhWizZeQX7ThvA+HEBcNpD1udgrGnfEz/3IN/acHKmkPs1b2+ISDWgTqiDaPU5 zqCahOiL0M/eq6XLqxRXcVqKjkjPQcjk3IGhJppZHbQe/T9zzdPCvP4mPf/kLBwPdVPJ z+Qom/dk5p78WgiYyyuFupRmpSopFcoolW5HayQ2amZ2X1KMNpt9bMO1BUN/DTFXVmDi zX8W+01EnDd4L3uQ3asFML+5/U6jxueoWhLT4QugsZ2kNzEKrK9Al0fxQ5fV2L3bwAwK OiwxWS8kwlVMhd1+9BmMVZ+EpWVIynBKLDC1963Kewt0ZT+vVvsbQhzQMKNd0LpUw72Y R31Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768577366; x=1769182166; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HcYNjtrM1tx5MNCL5NpuqMAZtAxO/Nx7W07L/efi2Ek=; b=OF6IkouLlFi9N7l6NkCWX6G7/SaOwjTpi1mZXCUrZZhI8BUrxtRy2aODkOcHl55gp0 LbPAejinOVg4UPnxvFzBqWBfJAuK5o0nGF42CgIXICLA6b9X2Rx24+FlyNdMbXyB2Tn4 yjhvUf8oMdVIEg/aXFacFpx8gWZWwfYUfasG136fDVvcPz3bhlIBd225o4843KzfEevv 1fjMt4VOjLPxMgngMn310uOB8yLW0zy1PKsH8KKdPWX+wyPBuR4DN2A3gTTyewacN4Wo Dt5aRMwaxnf59yLsTtf1f1mnRPSVSLboqLoa3JVwaA9ZbLTwPoW8EEiT1fjSqWKLd9G0 ISBg== X-Forwarded-Encrypted: i=1; AJvYcCXLleM1SJZ67utNO01HBHkr3m+0qYo24USH55JjOo4OKdQ7FJp4u75LX25he8fkN+cQZBkJF/A85fZZj6M=@vger.kernel.org X-Gm-Message-State: AOJu0YwrmJGgkk9zfCsu8fXWRSEbXQPX8nZ+2FOjoFHz5h07oH99NVDN II2eelNhs+nEr4IZCXPX1TGQg2ThvlkFPdoXJQNlTa6yov7g34XQflADz4DJ6ow/okWxGgfjBGe aa6UBuZY8W593rOfuvVUMCSXJEF8D128vGn2857VMkmBRwSCJkLSV9b2BW4OL1G0Pzw== X-Gm-Gg: AY/fxX6UOSiAw+7+p2vviLYwQ5j0TIhB/al7NSCCsDTdAOT0XXGdzpCqpUeewStcAgl wDq8YaAZG8QJST7ySSFYv3PuaiQjVeEJEsBiw5pUSjCWF6WCF1Zsw2xCuU6DB354Y7exRJQxV25 N3VakNn19gVQk1zt6ZUhwUBdrH4di4HD/w/Rz6ZelFgJZOftvD0wtomRdFxNmVUoDsmS2pcnMaQ AWBBF1OFtlOXbVGTKlFqf7KLG5zAYvmebTwisx4gk2XLtQ8aso5ZHt2CxHgIHWXO9X8IOkqAqKa 5AxyXa7kLPlDQ6eVaKLoMhx4/oT1AF1yGvTnjrNrWKd6YAseuA1+a0PxX5uuxCbRgYl5HSdIegu nC6VT9YJT2x3uRYjG7Ok/o3v5+l2fgQ2b2/DREhoLrMKM X-Received: by 2002:a05:6214:2305:b0:88a:589b:5dad with SMTP id 6a1803df08f44-8942dd07f96mr46350736d6.27.1768577365725; Fri, 16 Jan 2026 07:29:25 -0800 (PST) X-Received: by 2002:a05:6214:2305:b0:88a:589b:5dad with SMTP id 6a1803df08f44-8942dd07f96mr46350456d6.27.1768577365381; Fri, 16 Jan 2026 07:29:25 -0800 (PST) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8942e6cd63esm24958956d6.49.2026.01.16.07.29.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 07:29:24 -0800 (PST) Date: Fri, 16 Jan 2026 10:29:23 -0500 From: Brian Masney To: Haoxiang Li Cc: mturquette@baylibre.com, sboyd@kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/7] clk: st: clkgen-pll: Fix a memory leak in clkgen_odf_register() Message-ID: References: <20260116113847.1827694-1-lihaoxiang@isrc.iscas.ac.cn> <20260116113847.1827694-2-lihaoxiang@isrc.iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260116113847.1827694-2-lihaoxiang@isrc.iscas.ac.cn> User-Agent: Mutt/2.2.14 (2025-02-20) On Fri, Jan 16, 2026 at 07:38:41PM +0800, Haoxiang Li wrote: > If clk_register_composite() fails, call kfree() to release > div and gate. > > Fixes: b9b8e614b580 ("clk: st: Support for PLLs inside ClockGenA(s)") > Cc: stable@vger.kernel.org > Signed-off-by: Haoxiang Li Reviewed-by: Brian Masney Note for next time: I sent out a Reviewed-by tag on this patch on the previous version. Please include those tags on the future versions. The only time it's appropriate to not include the tag is if you make changes to the patch beyond a trivial change. Also you may want to consider using b4 for your workflow since it really simplifies your workflow. There's some documentation available at: https://b4.docs.kernel.org/en/latest/ Basically, here's a quick workflow of what I do: # Start with a clean branch (say today's linux-next) # Create a new b4-managed branch b4 prep -n my-branch-name # Apply your patches b4 prep --edit-cover b4 prep --auto-to-cc b4 prep --check b4 send --dry-run # Send out your patch series for real b4 send Later if you need to send out a new version, just use the same b4 managed branch. It'll track the patch version number for you (the PATCH v2 in the subject). You can use 'b4 trailers' (https://b4.docs.kernel.org/en/latest/contributor/trailers.html) to pick up tags from the list. There's also a b4 web submission endpoint you can use instead of sending it through a SMTP server: https://b4.docs.kernel.org/en/latest/contributor/send.html Brian