From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B56522D781 for ; Fri, 16 Jan 2026 15:37:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768577842; cv=none; b=dqP3Tb4OgfVKuPZ3t87s5GeGJVMeBEQ3nib4ZHSWkSO+LHvqZy6kWPW/MlED1od5dWysmVz9M98td6kbqQdT8wno+CPPhS6sGVcAM0cmV0scoqjlU8W39UeUwOzwLEuB7mittBv3aWx+MBO1pRuc0BxQdZnhgKJABhyPrxIIW6o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768577842; c=relaxed/simple; bh=/9f36ilOXF23oECHvG4OsAZ/divNmXTLrDifAZQ7xFc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R5CyRlpowaAqKPKsZFgnq9JRDy8XQstSObewLrLOYHv5pokpJ2GwHDo1Q615eK5U9dP5HQ/5nFVwJgz+Gw/l6eLIvSqYKw6wyV9NPlZJxOARdYGvzJ/Oo/QscsIAf4BBPOh9aQQSHgaK38099LBljt9XHZeIRm7hLA3wHEn5IGU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UphSMN1Z; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=qMHhPybX; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UphSMN1Z"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="qMHhPybX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768577840; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aXpSo+h8rDvzqpoMUmkOIpY8JAj42K+xxDqiiPj/TNo=; b=UphSMN1ZE79gQd+Cz8TSJBI5/1UCeVipAtAjz7LcamgxBmN3ZaxGEtMVjBa+HfC5evqi2r h6a/fThm+uz5CJtFrxo+oZ14BCZTyY/cUPCtpdxQB2aev9FTJHJ4WU/gXA4inFEJGw1jmN 2FIShWUFbLNTrcGaES4CJygg2VEnR/I= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-659-KYbYKWElOY-eymoMUaNufA-1; Fri, 16 Jan 2026 10:37:19 -0500 X-MC-Unique: KYbYKWElOY-eymoMUaNufA-1 X-Mimecast-MFC-AGG-ID: KYbYKWElOY-eymoMUaNufA_1768577839 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8888447ffebso58867806d6.1 for ; Fri, 16 Jan 2026 07:37:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768577839; x=1769182639; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=aXpSo+h8rDvzqpoMUmkOIpY8JAj42K+xxDqiiPj/TNo=; b=qMHhPybXqODWR7cYCSbw8WFgk1/xNabY0H8H2385hbae3w54I6mBbWefwhsElUJKIe aZGOQkbB+riDU2VohQ22t/1Ek6c9UUpJs8s45niVPRtYbcizid5Z3hR1z6+himM2zgYw jfaj5yS0JEhbhXTvGwO3Wjuf9hfYJ+MBVwSakAQLqr/6E6vd7csYAaOOZYTZWUl+/KtH gkqBskP8XGhcPNPPWm0pyyG0ytOwVs3OTMCIZ9kK9cta/RNowwGQPD+IFqUbQUlLbDjx j2qyFffWUKuwt+3aM9weiSWqQhjao9Szb6ORzNigxse0PCpDDfVbyq3Uzbt/NfdAoKad X8Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768577839; x=1769182639; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=aXpSo+h8rDvzqpoMUmkOIpY8JAj42K+xxDqiiPj/TNo=; b=nCl0gtuGIwBnbdpGB81bimgzxBPoTBbe/RXyen6iTyAu8X1tPUfNuWXXDiodkUUr01 cFxnVcs0VhjpvTEqtF8GXrerNuO59j1wCkwVjjFM9wS9ACj7tc6DrQfv5jnhCtroe10k zNNF+JJzrd/SteLpgGZ0DgQGBrDzY7AgVsxrB8kMt/9LBj00U46MUJWcQjqf6V7N5PXa PJq+yzfIa/bQpRpmJ+l3b7ej0+pIe0ELx88puaRmtxD3wEZpNcascokmELDuypIB+06b 8ULpN2RhyqiXS24idedRWKZU2xekvojBqfnuxfqgJnUJS6aTXf1zYs65nkA6D6WSBAjZ bGJA== X-Forwarded-Encrypted: i=1; AJvYcCUXQWgYt1Kg9WYTExxk9rL9WDr+a8w8uaOJjmqGhUSLcYAPDDC1EVDKXK1Sw8l+C9DyIal0441btk7W23c=@vger.kernel.org X-Gm-Message-State: AOJu0Yyt5UGphJNnPP2VBd8ICRd53ZPgj4uhZsNl2m8n4+qNQrlEcHYC Uzzsl1Qyyks60DV8Czb310ZFv1fnqkAXP8m5IBmADTRaFi1xE/q/Do+bBUEJpk4Najn3hbhfy77 Md39kDMD8F4G+JWfYWy2C9ckoI9KmmvlMuv7Es4URA/lDl7Shz0vh2AD8plLczIZTk9lknnjpnQ == X-Gm-Gg: AY/fxX5IJ3vBZ+GdJJUwEqBOvm4Xqrv8ApDsqr6IKYHLGHliFSYEm/OSO9JzUFQM1K7 KWAf1dVdyVz4ymlG0EXMMFCGTZZ1uR2lXaA2W00SzpCu27BbSWHbABbCQOMaUW8Xw2S8yWALupF yq7zVZXEzvABFbNWBQk5B1PSjY+P5haWTgXRK3i9KIyRC05EpMhVdhQJ4D/G+HsSdEOf8Ij0VR3 UeRP90PMUrYMswNS7NiXqfj37yPOKOM2MYuia8wTlbJkNBjEdz0Wznz1P7+JfgTY3geRu407Td8 Dvf2tq5C5GwxO2++UeWmkgfIluMSGEVZx2+E8Bfh3JP2PRzR1v5Dbli7ozo8fjfeaxIy67lv9Im reRSsgU/qvXVOOkwqRbCI/IuG93Uq5zm49OXl2c4WK8M6 X-Received: by 2002:ad4:5b8f:0:b0:88a:3113:3ac3 with SMTP id 6a1803df08f44-8942dcf87d0mr42114886d6.10.1768577838803; Fri, 16 Jan 2026 07:37:18 -0800 (PST) X-Received: by 2002:ad4:5b8f:0:b0:88a:3113:3ac3 with SMTP id 6a1803df08f44-8942dcf87d0mr42114466d6.10.1768577838288; Fri, 16 Jan 2026 07:37:18 -0800 (PST) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8942e5e554esm25946626d6.7.2026.01.16.07.37.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 07:37:17 -0800 (PST) Date: Fri, 16 Jan 2026 10:37:16 -0500 From: Brian Masney To: Haoxiang Li Cc: mturquette@baylibre.com, sboyd@kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/7] clk: st: clkgen-pll: Rename some variables in clkgen_c32_pll_setup() Message-ID: References: <20260116113847.1827694-1-lihaoxiang@isrc.iscas.ac.cn> <20260116113847.1827694-4-lihaoxiang@isrc.iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260116113847.1827694-4-lihaoxiang@isrc.iscas.ac.cn> User-Agent: Mutt/2.2.14 (2025-02-20) Hi Haoxiang, On Fri, Jan 16, 2026 at 07:38:43PM +0800, Haoxiang Li wrote: > In clkgen_c32_pll_setup(), `clk` is used for two distint variables' name. > This patch rename the later `clk` to `odf_clk`. > The rename is in preparation for cleaning up some memory leaks. > > Signed-off-by: Haoxiang Li > --- > drivers/clk/st/clkgen-pll.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/clk/st/clkgen-pll.c b/drivers/clk/st/clkgen-pll.c > index 0390f6834a0d..4ff9b35fe399 100644 > --- a/drivers/clk/st/clkgen-pll.c > +++ b/drivers/clk/st/clkgen-pll.c > @@ -797,7 +797,7 @@ static void __init clkgen_c32_pll_setup(struct device_node *np, > goto err; > > for (odf = 0; odf < num_odfs; odf++) { > - struct clk *clk; > + struct clk *odf_clk; > const char *clk_name; > unsigned long odf_flags = 0; > > @@ -813,13 +813,13 @@ static void __init clkgen_c32_pll_setup(struct device_node *np, > of_clk_detect_critical(np, odf, &odf_flags); > } > > - clk = clkgen_odf_register(pll_name, pll_base, datac->data, > + odf_clk = clkgen_odf_register(pll_name, pll_base, datac->data, > odf_flags, odf, &clkgena_c32_odf_lock, > clk_name); > - if (IS_ERR(clk)) > goto err; > + if (IS_ERR(odf_clk)) This if shouldn't have been moved below the goto. Also for the subject: > Subject: [PATCH 2/7] clk: st: clkgen-pll: Rename some variables in clkgen_c32_pll_setup() I would use the specific variable name like this: clk: st: clkgen-pll: Rename clk variable in clkgen_c32_pll_setup() Brian > > - clk_data->clks[odf] = clk; > + clk_data->clks[odf] = odf_clk; > } > > of_clk_add_provider(np, of_clk_src_onecell_get, clk_data); > -- > 2.25.1 >