From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C22B31063B for ; Fri, 16 Jan 2026 15:45:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768578339; cv=none; b=LnyXJiW0H+h/mmBN3CwngRk9yPDwacbEg+xbngFU2Miv9hLZ9QJ6QWGXS2MbrjkbkG/KL0n+Cls/T791XSyEh0XM07fPTYbjLHvxllBrvBZCj5mO17ye1UQ3n3KTf1SOOdoaaGujLPUVlbjOS9m/9Gg76wb5+HLUJaA/O5hF3sI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768578339; c=relaxed/simple; bh=m8V7jwBijQtS08YYEltYUnPoXXqq8ew1kNntGy5zBzs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ehslTAzp/5BEzyoIUhvxjfxbRd/ZWdu5msbPbSg+YNjsrLDAl0X9XxD/Os98FqZuqdNpZZXzfcKZpdXVVmsMmDQ9Z94benjP6ZVBtX7nSHT2RjRYSuomTinkgEdzCQWbE0xPZq1HCPH4mwhUJd8SdIieIxpYeueAHSAaSTzL3Cw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cpvPzeIr; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=HUkM8t6h; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cpvPzeIr"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="HUkM8t6h" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768578337; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XSB+cxcaZrZ1NetwzSMbH46eQqHmMnkR9IPEQXFKA1c=; b=cpvPzeIrUOEj8BWU0aPxU7t77ok0tZ6ZbCxwy0psuL8hJKQlndBYezMYXlbikrYFnSWm+5 Onf1SQKPlSKBmoXTwxG2k0VpnOpDZCqjGO+6pM7tAEiRKIe4d3Jv7ftYZjwtuBV38luWY5 mMAb4cyiBOnYpMg5MnYRSPW5oYEAtDA= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-231-5PGTd1SAOp2NMgnYjCP-KA-1; Fri, 16 Jan 2026 10:45:34 -0500 X-MC-Unique: 5PGTd1SAOp2NMgnYjCP-KA-1 X-Mimecast-MFC-AGG-ID: 5PGTd1SAOp2NMgnYjCP-KA_1768578334 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c52d3be24cso306034085a.0 for ; Fri, 16 Jan 2026 07:45:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768578334; x=1769183134; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=XSB+cxcaZrZ1NetwzSMbH46eQqHmMnkR9IPEQXFKA1c=; b=HUkM8t6hkZcKo00vbldH93Aq3vMJZIwpPxnWlgkViJvl0qbrEMiF/81xauWRLBW44g CgQ00yVg09BD7t7U8x/TCHc3GaG+GYQqLFDegwoGb/vjvjWrfFQgpQnA/vZVtXZ+4jfD /DkwlzDMhdvkAfjwygEtju9jhR1fAkuxRhBentJVWrN6fSPUqoEOBK8NRzncQDa2kqQz ztQwac+fiyl1olH6Au1XjoPiVQZqLshS2Tl3TShJgQPLzA5Ulfnc8FZSC2bchdmLl30u 8u0R0Fma0elruWdrZoPxRT83g8u8mXdFUqSUFf1lFCdkNoGwHvYQO9MbxJDvFqR+K+Vb AFmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768578334; x=1769183134; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XSB+cxcaZrZ1NetwzSMbH46eQqHmMnkR9IPEQXFKA1c=; b=Lehhmx3SRh3fMjhQfDTRHwMj64UWh7SV+c0KQh9kirbwXp5qJw2Bq/RbeghEcaDsaq BT4qlNxV38gAwuSd80kzSN4KzQtQIGTEPgxvelrPpPJ6fP43v8Q5CEmv5TP67QW/9JFc ki5V2ez5fvkb5JJdt3cTeiJI4EGBvOMuc7VDEAKJaN7paJvsw4eXA4myrZjJ0JexjQlu 0yWp2sYbddH/+T2TLAXe4O474WkC2E7cIfEvpFMm0mnLevpAL4EpEg4/86iRCtkhqReH bxPSZfj0M8hmzHVaSbKuK5Je4IWA7imRS6RGFvPZXDyhEfphrfexuRmQzIALqdIQqV2H Mogw== X-Forwarded-Encrypted: i=1; AJvYcCV0tlDXf9c87ZlJC7dthtE2+yULYgA3yfGLUi2O5Dg1CrZr4leZZdSJKHfjDAfaI5/32177LnBFy7DwPjA=@vger.kernel.org X-Gm-Message-State: AOJu0YzcG/z1Uj1n8jHbZ0jM3/xl7IU5NsLLLt3VzbL5AJfZG+CtRKja 9z5i7daZYQ9bk8d3dPAn7uk20GLTCQm7tI1z7bKyxn+VBm5whiGFXB0NnT20XNnje3Vp438lBnD oltrrDFMjiaaxJQQrMtkJNESMoIdx1rBszLF0fEO5zEWdhnyHyAC9BkCeFVjtf2if0g== X-Gm-Gg: AY/fxX4g5S7Rdommu2GkVmx5nNwp8AGQUAoQGK8X2WINS+2M8DZlT70YzsWlMk7FjsA rdl+mUh4lfV3cEJRya/QzaI3UOCzXoVt5b/zjOQKjrQc6dfcVkop4C/1cA4TVX/VqTvUI89xd7l Ds546oBXxDkQvBpvqyTd72/JZKTz8n6U4bhwK2I312KGHW70OBlHnWdB5saZ7op9GiuKUtuA3pe 0FRpTtCM8kot9KMfbRUhSGE+GC7lLIsyyhEEP85lSLpX063D+ZvkwO4m3ry8u1/WDzlWpRZdk+X 97yLTFKGPoYrgLQzOsJEvno1dINzzMa7znfT5hMpIPRMakGXBpkMDLPr2CEwA4tOmIgByv1RTfV dztI7htIJ2wR0WmnKm4eZnwxa6UU+0dDdWapCRFzJKAMs X-Received: by 2002:a05:620a:45a8:b0:88f:e620:21cd with SMTP id af79cd13be357-8c6a67b093emr447863285a.62.1768578333872; Fri, 16 Jan 2026 07:45:33 -0800 (PST) X-Received: by 2002:a05:620a:45a8:b0:88f:e620:21cd with SMTP id af79cd13be357-8c6a67b093emr447857785a.62.1768578333307; Fri, 16 Jan 2026 07:45:33 -0800 (PST) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8942e6d8640sm25187086d6.50.2026.01.16.07.45.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 07:45:32 -0800 (PST) Date: Fri, 16 Jan 2026 10:45:31 -0500 From: Brian Masney To: Haoxiang Li Cc: mturquette@baylibre.com, sboyd@kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/7] clk: st: clkgen-pll: Remove redundant kfree() in clkgen_c32_pll_setup() Message-ID: References: <20260116113847.1827694-1-lihaoxiang@isrc.iscas.ac.cn> <20260116113847.1827694-7-lihaoxiang@isrc.iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260116113847.1827694-7-lihaoxiang@isrc.iscas.ac.cn> User-Agent: Mutt/2.2.14 (2025-02-20) On Fri, Jan 16, 2026 at 07:38:46PM +0800, Haoxiang Li wrote: > In clkgen_c32_pll_setup(), pll_name is actually pll_clk -> core->name. > This variable will be released in clk_unregister() -> __clk_release() > if some error occurs. Thus kfree(pll_name) will cause a double free. > Remove this redundant kfree(). > > Signed-off-by: Haoxiang Li A fixes tag is definitely appropriate here. Fixes: b9b8e614b580 ("clk: st: Support for PLLs inside ClockGenA(s)") Reviewed-by: Brian Masney