From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f50.google.com (mail-dl1-f50.google.com [74.125.82.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BDFD2CCC5 for ; Sat, 17 Jan 2026 00:30:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768609826; cv=none; b=fF1uZOvbqQtzcVp3EVMfANAcFN4qy/f/xiMIL2zQoZuX3Jb5qgLV/UVoV4xHUd+lXHDTGTP7evBNbZaoIG6H/kOU+0L36MO4A0tbYLvSOA7n5ph1AwD0LlTtJr6uqfcx7X5oqpXEIpfUyTFHoCFfwZERmnI/FbYkFPzL+ObJ16M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768609826; c=relaxed/simple; bh=luDJ/W67j2gZ4jPrGcVobjYQ4folzdqjBsuUm3FaRPI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iINwJbw8EHvjvIaMXCMnmrmSYZ6rlnzu2lEex1jIFKQhIK0rHDrDU8uUR4swwP2O4BgJitz0H93FJvsoNv8GSNDxScb70NG5jpl9RVRB0oH0m51LcTbqzPTfeEsGDdV6O7XNnzt3QEsDtBhJ7ngvlqFcphz2hTKvaW6FshUAWR4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l3ZIEpKn; arc=none smtp.client-ip=74.125.82.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l3ZIEpKn" Received: by mail-dl1-f50.google.com with SMTP id a92af1059eb24-1233b172f02so3230573c88.0 for ; Fri, 16 Jan 2026 16:30:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768609824; x=1769214624; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yp1sONmI1EVSxxcQrVc8RcvF+u7mjGF7KxmFk1Nh69s=; b=l3ZIEpKnWLSSseycrj6crW/YWGRH1JxLQ4tR6AB0HyxnYh+HDuN+Ze1CGWz2DbzNRS 0HQrgHUUiFIlFFiE4GtVfu0ZHxUcJLtPAS7w7aR82gfE5/bPnIYpSwE7Ax7QyAYENPT5 gKL9tfmn4nj88Vcvq1994xsCFE1nsdBlSywfEsZ37HMuY/+n2I2TxRRVTYeEcBj1hrrO S9JBuBtcCnEXrpka0atxRp2jDY3OIxS16W+dyOqLRBUsHF0fmnqEYDAlKfbGhjHuSOj6 N6Fj60nTOkAKr/PNZfgR7kIzM9uVwOD13Z4YtTpQxYuvXL1aBrlAojhsOh9wiyIA3dfF Fafw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768609824; x=1769214624; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yp1sONmI1EVSxxcQrVc8RcvF+u7mjGF7KxmFk1Nh69s=; b=FY+g+mck5oorLjkFul26nqhRYzxwAN78cZCHpQRJWdDdjVnpm9vi8DjpgjUzaWgc6a kQbmXqPPNMjPCMfV3T77r0kkQH2OD5rwZxzpfaFdWu3216mYwFvGGf9ROcz9BrzNMsjE 9LlbELVPaVga4g521G1IVhbw3RBsO+/CAs8fW57HWLbV8469A3LKZkwc92F/81KI9pnf tcWDvsmV3qDlwrm/WIRfeeAUR2tX4jBF+RZ3NDwChVqjzrmbQLB8JHp/CAe35tzcV4i3 o72UzEMbiN42PwQ2bZCOu6epyX+XR1Ylq28QU1dYBIQmB3YcOyUFrbeHHo98dCpexxCX Gp0w== X-Forwarded-Encrypted: i=1; AJvYcCUWMuAZ3hlu3pjV+PiAzCYDGRDE3KYb0nTT15LET7Y8/2S4iDnIofslVDO51s+ss8pdkduyUu66Hw1u/GU=@vger.kernel.org X-Gm-Message-State: AOJu0Yxb/NXKl46YSy+DZSeo/ZgtrqYXdZ4BDTAO/1QnFAyHEsKySHfu Q3a03rllhW9KT4Hz6NM504A0jdbr5AYGJpDngQ1bSB8rYLc/8djHX2nn X-Gm-Gg: AY/fxX4hr1R2jbt8bs9argBhKpE8xd5mBlJh5zhbZ51h3yQuZQ6ni9gh62EKnn2KfpW x1fCPTKVnVvwXpme+nD57cyFaJGlW4/lNOlcgu1Wn1mgoZhnWQiSGfz1Ox3fFRWW72lcJXlU1QM OXZ5RJUOz6+Aj9BgJhe1YOvO3rGg9+63OvKIU2zyk5BYT/ZJ5jLeAQXI/1QQX2Zq/jQgfAY2tcU NoTZjHp9EFSqgk3RgC9LjKgsAhXb3pzQar4h28pMaLdzBRHXPdkbetbABrDf8zU+Di4J0WBK6/e 7QzGSAD7aPLCWrNRGy/W5x3GuCh0bEhqRwvKBRWjvdfS2K2jwuI7Cf5vMQ3pf4GUiuDEzQS5czf zyFaNYcvThMJib3kxKYSa7V5qOLmrk9Di5I2ePHwHgqG2RnAld/ePgAv7iN3chpvo+CQXQ7I253 w3K1QzYkMZaeIt0cMOBuMe X-Received: by 2002:a05:7022:4181:b0:11b:2138:4758 with SMTP id a92af1059eb24-1244a6f4633mr4977023c88.21.1768609824098; Fri, 16 Jan 2026 16:30:24 -0800 (PST) Received: from localhost ([2001:19f0:ac00:4eb8:5400:5ff:fe30:7df3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1244af10e21sm4814313c88.16.2026.01.16.16.30.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 16:30:23 -0800 (PST) Date: Sat, 17 Jan 2026 08:30:18 +0800 From: Inochi Amaoto To: Andrew Lunn , Inochi Amaoto Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Karol Gugala , Mateusz Holenko , Gabriel Somlo , Joel Stanley , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yixun Lan , Longbin Li Subject: Re: [PATCH net-next] net: ethernet: litex: use devm_register_netdev() to register netdev Message-ID: References: <20260116003150.183070-1-inochiama@gmail.com> <3e326797-b4c1-424f-8cf1-f0095e33e0bc@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3e326797-b4c1-424f-8cf1-f0095e33e0bc@lunn.ch> On Fri, Jan 16, 2026 at 06:20:05PM +0100, Andrew Lunn wrote: > On Fri, Jan 16, 2026 at 08:31:50AM +0800, Inochi Amaoto wrote: > > Use devm_register_netdev to avoid unnecessary remove() callback in > > platform_driver structure. > > > - netdev = devm_alloc_etherdev(&pdev->dev, sizeof(*priv)); > > + netdev = devm_alloc_etherdev(dev, sizeof(*priv)); > > if (!netdev) > > return -ENOMEM; > > The commit message does not fit the actual change. > > You probably want to split this into multiple patches. Ideally you > want lots of small patches with good commit messages which are > obviously correct. > In fact, I just change them by the way and it is not a obvious change, OK, I will split it and send a new version. Regards, Inochi