From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F28E018027 for ; Sat, 31 Jan 2026 00:33:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769819637; cv=none; b=kL1QFLzW9StE/dvWuMLpIlno1jSOTNV+GdRchnkADlXN9u/eR+9BoIPGwBjt2EmSPAAwIdS6DJYfDE/fyZuUR00thPFN0mtvyrf2tHMvucJsCFht9DxNQN+hb1QOTQ9sVYSweK+Hq1Q2MfqeYtVBGj8gglrl7GTSTwq2laUY9Ow= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769819637; c=relaxed/simple; bh=kXkaAnZDH5mIjoW4y8q5Q8QTe+7i086MQPfEVs63Pzs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nOds8DAfD7q/NbGN9+hhh9sWZ1djOaYSQfVeLfKPw6wHNodwsBSg6Ar2XxosW5VlBWjhNVE4AYkNtbKYtbF1A6NbXKx4bBlcMJse4tnjhLWAi7pW2TDH6chUPYb00DMneB9AmCiUIwb+zrI88Tjl2K+2gMbhdH/Y36UUvpr4ReE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b=Rali/2oT; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b="Rali/2oT" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2a79998d35aso17186265ad.0 for ; Fri, 30 Jan 2026 16:33:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20230601.gappssmtp.com; s=20230601; t=1769819635; x=1770424435; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :from:date:from:to:cc:subject:date:message-id:reply-to; bh=RB9dKGGm5zaCQfa6GntcD1JuM3+Ig5ioaznQVVa/kZs=; b=Rali/2oTC5XJwqHHCpOHxrNp+QuLjasxeaYHWU1v4S98BsMTaXagO3CfJBuKVG3Ax6 ma32m/o6DLIm8mqV53Ms+06OCARw8z5G1Efrfs7VcHvQxTns3wSO3rvPwul0y1ZWAzZf 8o4laUEJNYVrXCCOmx/cmCF6Eb1KoBw51PtjgoKgWZzS0jyIwSBafgH3r4MkjearCZ80 4OBgjvcCFKYkqKSlvO3FS4l02kLKj2zXWAqBlmfo0OAHpexb3xORH0w5L/P4Pwa79G94 BA22nJEKSR+stSK99zmJRPUc3/4zimIN36MPDfErnmZoaRBJoWo7gT9shNJ4lGWddfp3 9udQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769819635; x=1770424435; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RB9dKGGm5zaCQfa6GntcD1JuM3+Ig5ioaznQVVa/kZs=; b=YB6oxWDaAOe/HByRhyH9dZmfS963vgOl/xQT9YKigAtabsWgk1gFXdFdxXwWBrBtAN PIFEoz2BAzNkI0pU2k5vTbOA+mSbgDmU3W3R/Ez5SAZCeLpftumH5gV+6nvoN8xppeuP ipgDDTx1mq69EqFxTPNNTE9V0+XSo1tG7YXdr8LeWJQMz8VaDef0FvNdybPdXXQYh/F8 n4FrKeKvbEH0+bo4XhZxDkgxR7pUu+03flcq9/J+sgrTi8kdZzRaLJ7xlrvPEXeOqxez pjEIB+wvGGTwjAHbZlMHF4iscU467hfjXrkHK5oFyIb/W141q1E6iUN1x5BC7T5v7yh9 e7Bw== X-Forwarded-Encrypted: i=1; AJvYcCWMdoUuyyrJj1Lg4FQpAZf+MDbGWcMqAxJ5pNcp/3WFi2pCMKNwmgak/bteJD/VfvL4qKzjCR3fHIFgA1w=@vger.kernel.org X-Gm-Message-State: AOJu0YxadGk3su6cLLH80c7jciQES3L6jHL8EHNOaz7kalJ22EUCJW56 eVMA1IOQfA0JnusmSwNbcnlcLfR207aH1oqpCtYIs9QA2dfV+7lnl4KLmVgFdZz887M= X-Gm-Gg: AZuq6aLhRYlB0JvGROyJTGbWhP9ZWG+z6n0jbT5o/NmGsAGybvaKT67Fu8w/3TMWE5V 9jy66ZHwPUnqSi89gIzAPljjcxwzhfreH/0rRjR+A3e7gVcHUD0QH84ztTOrTes+6Hy7I91J5/5 YdsGFvEKXUKsBO3g4RNLjpsC0T4lKJJ+yNQ/qcwUNf3R9L1uz+V3Cv4wgqdmTdR+lbrA79VZBan YIxWPkZoFvPYHn2rC5VMt7MZdWNHKV/QIg503vNLr0uuTx1urdSHHweUFGLVdMjON9rnM+jsXHT bXT6rJaPDfy6UtClxlDmYewMUmVnDpTt1OtWdxaAVls9h587MAVlfay2voYvKrwaOOTgIXpQutM 1hg3eeMPW38hikFWtN4jw818EnXfbhGtD3oq8DeVB4tAWOGFSXbGk63Lyo0F03AlOrwY= X-Received: by 2002:a17:902:d489:b0:29f:e787:2b9b with SMTP id d9443c01a7336-2a8d9932dbemr38719225ad.41.1769819635320; Fri, 30 Jan 2026 16:33:55 -0800 (PST) Received: from localhost ([2a03:2880:2ff:4::]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a88b3ede23sm86209455ad.5.2026.01.30.16.33.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 16:33:54 -0800 (PST) Date: Fri, 30 Jan 2026 16:33:53 -0800 From: Joe Damato To: Michael Chan Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Pavan Chebbi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , shruti.parab@broadcom.com Subject: Re: [PATCH net-next v2] bnxt_en: Allow ntuple filters for drops Message-ID: Mail-Followup-To: Joe Damato , Michael Chan , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Pavan Chebbi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , shruti.parab@broadcom.com References: <20260130002323.2561266-1-joe@dama.to> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Jan 29, 2026 at 06:28:38PM -0800, Michael Chan wrote: > On Thu, Jan 29, 2026 at 4:23 PM Joe Damato wrote: > > > > It appears that in commit 7efd79c0e689 ("bnxt_en: Add drop action > > support for ntuple"), bnxt gained support for ntuple filters for packet > > drops. > > > > However, support for this does not seem to work in recent kernels or > > against net-next: > > > > % sudo ethtool -U eth0 flow-type udp4 src-ip 1.1.1.1 action -1 > > rmgr: Cannot insert RX class rule: Operation not supported > > Cannot insert classification rule > > > > The issue is that the existing code uses ethtool_get_flow_spec_ring_vf, > > which will return a non-zero value if the ring_cookie is set to > > RX_CLS_FLOW_DISC, which then causes bnxt_add_ntuple_cls_rule to return > > -EOPNOTSUPP because it thinks the user is trying to set an ntuple filter > > for a vf. > > > > Fix this by first checking that the ring_cookie is not RX_CLS_FLOW_DISC. > > > > After this patch, ntuple filters for drops can be added: > > > > % sudo ethtool -U eth0 flow-type udp4 src-ip 1.1.1.1 action -1 > > Added rule with ID 0 > > > > % ethtool -n eth0 > > 44 RX rings available > > Total 1 rules > > > > Filter: 0 > > Rule Type: UDP over IPv4 > > Src IP addr: 1.1.1.1 mask: 0.0.0.0 > > Dest IP addr: 0.0.0.0 mask: 255.255.255.255 > > TOS: 0x0 mask: 0xff > > Src port: 0 mask: 0xffff > > Dest port: 0 mask: 0xffff > > Action: Drop > > > > Signed-off-by: Joe Damato > > --- > > v2: > > - Extract the FLOW_MAC_EXT and FLOW_EXT check so it happens unconditionally. > > - Eliminate the local variable ring, which was used in only one place and > > call ethtool_get_flow_spec_ring instead. > > > > v1: https://lore.kernel.org/netdev/20260128222718.1679581-1-joe@dama.to/ > > One minor improvement is to eliminate the vf variable since it is also > used only once. But I'm fine with this patch. Thanks. > > Reviewed-by: Michael Chan I made the improvement you suggested in the v3 I just sent. I retained your tag because the suggestion was cosmetic; I hope that's OK.