From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE81C346784 for ; Sat, 31 Jan 2026 13:02:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769864543; cv=none; b=fl+3AAFsUS9wO0BrMUaRmzyITAC4Xeim7TWZ2TfHI2g4SwZ748RiHx8WGAawX9q7N/3EMQHY7jTs1EmO9f5j39dvSJc8Hw0Ac9e1asKtDIHuHrsOVBs/Ad20m6BDsBKwhQArjw39pYWRbjKjCX5a7uVrWB18x6fHgm6E0xQijEA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769864543; c=relaxed/simple; bh=47b1/UOunzsnxKnL4m34GNguaUCleoCY1kmbBLnqQ2s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=b9SO8Rg25XR4OGMRUSAUsGhTWKXxL95h5DYCCDCSN9Gw3KjEYD8e5izIOiFtzd7ZCZ3pbI/DVfLpp6Ma9TSvu2Eg0fJ7pHVyrWY0paCBgCso5D6HBtD7z22swn1TnAYth7TD5ST8nks9y+bG69IXKrIgPElLTSozV2/eDAFwiNI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JFQ7S5wz; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JFQ7S5wz" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-47ee0291921so27418315e9.3 for ; Sat, 31 Jan 2026 05:02:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769864540; x=1770469340; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DRs3JCfIy0F/5RT0pfot+HnvlFMKfhT+1lFiNSfeV1A=; b=JFQ7S5wzEG4dGmCWNEzLT94MBcA8/vl0Sg46ZWQK7yUjEMDs48hZ9JdukiIlN2uSJ+ ccpAxaJAlNfWknYWxbs+/RCz+YaPK2lAzQYalRbknpn+R4Q5aLhp4GfX1W4DshHVys9j KTdImrbmTdZ9UqJiPiN9jZ6ge+0AFMpNucgz7PYzOp1PCME2DCMVMk8HNch0Mxfagw0+ 3qM/fcSFgePAn6XsQkFedvAxXrazz19AZa8rRe/f2tlaHRuhP+nxkP6gaYUHgdjqY16Q BnHt/FWgM0tvCJCIpEpZXrXeUmqnX6bMy7wyoyXgx9po+01TgLAwvPYiMmpJCgTCvE8n 4WPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769864540; x=1770469340; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DRs3JCfIy0F/5RT0pfot+HnvlFMKfhT+1lFiNSfeV1A=; b=s28xNdr47P+sbSSWZUndGHxmhrZaGKSdw1DUFgsLRjWOYgCUNM9541wR1L+uFYGfqv Y4BjrtB98V6KKiWPNYTQWa2hLYt3ApavWHBwtAaBs/+Ym/fvzGqOSfROV4p6fJzCqqpH u+THV3b0JzqQNfi+zTd3sbMYtFFe/zRG6o+L70FRidzt1nNy1EbnKGz7HvKECWGo3wHz c+Dg0LtmsqiPkUteuc1xQKymJNrgWRTprx4XOaPkdyICZVOGZv9vWA+0oHZTOxQiozc+ aUGyC4XmNUsolRgD9EB4ysscApT+FOW3FdBSwq66PMvWq1eYxf6f4R3iEJ2ukQFqERlX ettw== X-Forwarded-Encrypted: i=1; AJvYcCVMO/JHtJIYoYhNbUOz1Nit74LRzhrdWCB6kTSEzyHyiuvBrXcnBykndF+HEnU/tiZLRFjOKeFarAxqwQM=@vger.kernel.org X-Gm-Message-State: AOJu0YxPq3Q8+imkh6sfUoNz74SCwvR5WcTAUEcoWDP4JeS6Atcssve8 B+nnDcrKtyxJXkmCJFNTelFtiiYN6mKPnk5edltgL1JKss3fFzU9bosSQx1lmrcJOic= X-Gm-Gg: AZuq6aLwBCK6W6KoOgNGdNBLsJVkIZwFqQkOO+kePBqfqFdfO8nXQGypIcO4d9Dh/2a BuyIVqrCQezHEZ70eL6cT2ThG5KP90trFKRIit6u+EMRdEwwxpvHkCeAuMQf6gUcuzI+CBImXvL mPoe7WjKTEHRUfwbhpEE8q4JecvrW5vWi2wNEK2/O8sKxPD0k0HMvg1/25PtNJ7IETTR3HrQ5Ev yiSX2On9cYv2HgpEseF0yONpHUYBl881lVqugEaCtghWPVaI+juCOeM188TKtHOwSklBuxNHHCA HWR366LBPZEszNZJbBOKRiBuIeYG/QYhtsB0ujly5K8SIFH4MBJjDDaJJz6C8CqAbLO2/2xgT+5 /hIj5gs9ULHtzuNgb/41sjqu5wf+aD8w65c0UV/4F8mYn5Lmn/yC3prIaiYldCPkyDTVrSQPXpJ SrHf/zmq28e3/Hn0bX X-Received: by 2002:a05:600c:8b26:b0:480:426e:9d38 with SMTP id 5b1f17b1804b1-482db4e5cb1mr71155645e9.27.1769864539968; Sat, 31 Jan 2026 05:02:19 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066c37420sm349296505e9.9.2026.01.31.05.02.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Jan 2026 05:02:19 -0800 (PST) Date: Sat, 31 Jan 2026 16:02:16 +0300 From: Dan Carpenter To: Ethan Tidmore Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] staging: rtl8723bs: remove unused private debug counters Message-ID: References: <20260130204051.4237-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260130204051.4237-1-ethantidmore06@gmail.com> On Fri, Jan 30, 2026 at 02:40:51PM -0600, Ethan Tidmore wrote: > -void rtw_hal_check_rxfifo_full(struct adapter *adapter) > -{ > - struct dvobj_priv *psdpriv = adapter->dvobj; > - struct debug_priv *pdbgpriv = &psdpriv->drv_dbg; > - int save_cnt = false; > - > - /* switch counter to RX fifo */ > - rtw_write8(adapter, REG_RXERR_RPT+3, rtw_read8(adapter, REG_RXERR_RPT+3)|0xf0); ^^^^^^^^^^ You can't delete this. > - save_cnt = true; > - /* todo: other chips */ > - > - if (save_cnt) { > - /* rtw_write8(adapter, REG_RXERR_RPT+3, rtw_read8(adapter, REG_RXERR_RPT+3)|0xa0); */ > - pdbgpriv->dbg_rx_fifo_last_overflow = pdbgpriv->dbg_rx_fifo_curr_overflow; > - pdbgpriv->dbg_rx_fifo_curr_overflow = rtw_read16(adapter, REG_RXERR_RPT); > - pdbgpriv->dbg_rx_fifo_diff_overflow = pdbgpriv->dbg_rx_fifo_curr_overflow-pdbgpriv->dbg_rx_fifo_last_overflow; > - } > -} > - > static u32 Array_kfreemap[] = { > 0xf8, 0xe, > 0xf6, 0xc, > diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c > index 928226679ab4..e4d1b54607c8 100644 > --- a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c > +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c > @@ -124,7 +124,6 @@ void rtl8723b_InitHalDm(struct adapter *Adapter) > > void rtl8723b_HalDmWatchDog(struct adapter *Adapter) > { > - bool fw_current_in_ps_mode = false; > bool bFwPSAwake = true; > u8 hw_init_completed = false; > struct hal_com_data *pHalData = GET_HAL_DATA(Adapter); > @@ -134,16 +133,8 @@ void rtl8723b_HalDmWatchDog(struct adapter *Adapter) > if (hw_init_completed == false) > goto skip_dm; > > - fw_current_in_ps_mode = adapter_to_pwrctl(Adapter)->fw_current_in_ps_mode; Which means don't delete this either. regards, dan carpenter > rtw_hal_get_hwreg(Adapter, HW_VAR_FWLPS_RF_ON, (u8 *)(&bFwPSAwake)); > > - if ( > - (hw_init_completed == true) && > - ((!fw_current_in_ps_mode) && bFwPSAwake) > - ) { > - rtw_hal_check_rxfifo_full(Adapter); > - } > - > /* ODM */ > if (hw_init_completed == true) { > u8 bLinked = false;