From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 624F73570C1 for ; Sat, 31 Jan 2026 17:41:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769881317; cv=none; b=LU0XPUY6ceDUj8w0gklC6zbPs0osNPx58EM8bunebAAjkIzQYh5sErNn4UAFwvVJeiRt17Rj83wN9DnuyBDq6yRPYfsf/l+mUPgsdMbndQweo1pWpRROgv39eEdXjJDSYL8+HO4cC+Zg0fKdFL14dbCNLZ5F/v1hDXGLJ9iKsoo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769881317; c=relaxed/simple; bh=ODh0YEedDQQUbtZJN2ZKA3UJ2CNO5pR4RtNNOetaKas=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IX2/KWrussdzNlTj1f385iQvw8LY9jrWsykjSYDuT9WK1Ld1oYw/9ZE+irJwqmrmFpkWq+28+VlnpfnMo27ktdPHyjB+G3U/K2VA6tC/C9URgtiH/oIW0/xm253hTVnYWxgmpKViJzihjJe97KkFrHyUEqZOZNcT12Lleiry7Js= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=pPXMTUk0; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pPXMTUk0" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-4359108fd24so1917547f8f.2 for ; Sat, 31 Jan 2026 09:41:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769881312; x=1770486112; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=87lYDd81b43I1hI+PrPeRJ33ugJ/zNqt7MOoX7PXG6w=; b=pPXMTUk01NagWNYnzvfRQYL7PvtCwBtJ+fYA4O6MS/0RE0KuR+FKk/yNWsgwUIkVp4 v0Vg0NeeT9kmcIdDI2vOCIjFUxogHVwAwqKaxzKSwDty+tuA1X9JJfsqh11VE4mgni+J YogmAfY5Vg7wLFY+otyDJrrNJLLaorUw3sADS/FAQWo2z6ONdyL0D+bmbWQLukKNBiIb XneA3wcbYUyr1qm4n0FL/W75guM5DSk2SsKCEpJDrVwcoCRbVcVBsL2H5DhNeqrqcD8x /J5I2U+QziTB1GReii/YFRGQVIMwYZq4uTw5e2YIksC9XlHzoqkVROKFjlQBD/wo1MG/ iuFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769881312; x=1770486112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=87lYDd81b43I1hI+PrPeRJ33ugJ/zNqt7MOoX7PXG6w=; b=AYa6IKOISaKpqSGeb1IMaGhkm2MbmpnX2ILQtJL8/3Kc0FOKO8/lT+/6EYLvQ+SFGM ilmz7iYVHiKvGPZjBGDcs6alSByqtDHh2U+zGdHBP8UDLu7babk+w0Ty4U4EJj8QgPvk vbqEEo8rYWyPsnwxUKpTXb8iXIeGcFmDPXW20zZjCD1LJGgBa0KWc9YrBSmQaxzvyYvP L4zrQTAGZjUdvdFcqfSXJBzBwBSUrNRM5C2WHFGhlFtvujJXjlBoQxmb7kMu0/3uzehw Ou3OfFb37WMq2hXQ+3SbHbBl/3M9qD748RKEm9kTxBVCh16TBbyvRr3JSg0pNWVoOmZ1 Se6Q== X-Forwarded-Encrypted: i=1; AJvYcCVohPvGZsyC7Cx/yFrNQ9ADPAjAmvr4ctAxgybEo5RSyjsDgyHRQG3LH6qPIsa2BJiYRX3ng6tsxFUtSm0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+ZsYOJYDKvRnnuVh9AAvDIe1mOIBuOB2e4CidjCtv7Vy947sJ 6ghz9ERd4k4+O14mQTsSEY4suCS4ij0tfRKDJnJ5d2W4eoAMTxvXzHBwGLg6CfSgsEg= X-Gm-Gg: AZuq6aKCQQkgMRa56afX0M5QWDRXJhXqCVhx+YCVRT5u+5E1JwhRNZp59/JQiPinRMp 7WQAlJtzyRCoHge1BL6SBQiw3GEuyWzCwjAKpLql1KteTaewn4my/TfCUSbZeaZzCTkAVxgNaPd iSUz9FjTeqr1/yK7U+Ul4daBguhm/0lhAl3E6NTZtOXozJzm423HbtuCYBden/8OVabLzfUZmBE 13PMD329HJK2iRCEtBii4GF2ahUIVatZLt6+wtEPRXfMOSdBVezaYsWAJyxK7IJt7/huJjgypCI eV7qXHz33RwMahqRG2iMER6+R2+r802r28fEVhikrPXNgrZDbqCRrARBgH4QI7fbUsFEHG88Lhd uMXmDQm2Mad/4dcHikcEGkemPmQcIba6HkE8cxIepGnf6ex8i8qnAjVWGvS1MTti6VvMcPIN8k+ cVNOM3Vc0StrAIqQqI X-Received: by 2002:a5d:5f83:0:b0:42f:b0ab:7b48 with SMTP id ffacd0b85a97d-435f3a7c047mr9092414f8f.1.1769881311595; Sat, 31 Jan 2026 09:41:51 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e1353f8bsm29884522f8f.39.2026.01.31.09.41.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Jan 2026 09:41:51 -0800 (PST) Date: Sat, 31 Jan 2026 20:41:48 +0300 From: Dan Carpenter To: Gustavo Piaz da Silva Cc: gregkh@linuxfoundation.org, ovidiu.panait.oss@gmail.com, gshahrouzi@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: axis-fifo: refactor device tree parsing Message-ID: References: <20260131155630.41587-1-gustavopiazdasilva2102@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260131155630.41587-1-gustavopiazdasilva2102@gmail.com> The commit message is still not line-wraped. This patch didn't apply. The first one did, but this doesn't. On Sat, Jan 31, 2026 at 12:56:30PM -0300, Gustavo Piaz da Silva wrote: > Refactor the device tree parsing logic in axis_fifo_probe() to reduce code duplication and improve readability. > > Create a helper function axis_fifo_get_u32() to handle property reading and error checking, replacing repetitive of_property_read_u32() calls. > > Also change has_rx_fifo and has_tx_fifo types from int to u32 in struct axis_fifo to avoid pointer type mismatch warnings, as of_property_read_u32 expects u32 pointers. > I don't understand where this warning is comming from. The existing code is calling of_property_read_u32() which also takes a u32 so I don't see what changed. I wasn't able to generate a warning on my end. Anyway, the u32 change needs to be done as a separate patch. regards, dan carpenter