From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78A3422156A for ; Sat, 31 Jan 2026 13:31:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769866313; cv=none; b=rZ+Ru45hMVB75TbpYYQMB3Yn8K0u+OvjydjsvKCpEBgq40dNmj5DH2qfdW8BYYa4A8MWqgbNsGAUXQQYcZf9ZR0UQ15bMVCKHoSJybKAVelOW+AXpSZSEk22QyovYrH/JMBH9PcgHFxq+AhHFVx2Ni6U7qTtpc5T4v3/+FFiu8A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769866313; c=relaxed/simple; bh=RNUgk4RxpOXOM6CZp9c9Tmum/2nbTsq1s8Xnj2g92sk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=s+tKtmjLSD60pNwnaJVA6YA5ugfkzzAzUh6gkc65FaqmytnX29x/2cqM1N2WTTTByQS1aMf7AR5ycs8458n6pROs4Udhr1Tyh4lf45j0n0z0HA8PyHy5zXT2qoFQ3ZOGo+bK19RaSmNC3de8ZZsbmNE8n8qsFI9yxv+2R4zzp3A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GC38M1qX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GC38M1qX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DAA11C2BC87; Sat, 31 Jan 2026 13:31:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769866313; bh=RNUgk4RxpOXOM6CZp9c9Tmum/2nbTsq1s8Xnj2g92sk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GC38M1qXVIRd/HDH3FY24Bzl4aXNRu0t3v/YdBScl63pZz5yGW40K1S4eyIZeXJ51 Uyvugbs6ghxnyYe726Ysp2pzB4o8OcDxKlAeM+LZyQFRGL4b/Z/wvHJHAwrd5vixyv wUhNyOWUlCSrQ8mtHwbFQ7gz1A50ypeC6iSjdlDwC2m32VzCrfV1JJtyUdi1/JzSEr y/DYx89CHIKyrSE/QVbQoiYBrT8GbKorqhMdten6Lgo1WYUct1TLsjq1hapVS1O89P gMEAfB4NecIPaKWY34yR7FrpnFRwnCXnx8stw08vG/CFkhtngp7mR7I9OKTDUSUc9L PIeJdrRopzYcg== Received: by finisterre.sirena.org.uk (Postfix, from userid 1000) id 680B41AC56A2; Sat, 31 Jan 2026 22:31:50 +0900 (JST) Date: Sat, 31 Jan 2026 13:31:50 +0000 From: Mark Brown To: Thomas Gleixner Cc: Jinjie Ruan , jstultz@google.com, sboyd@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kunit: time: use is_leap_year() helper Message-ID: References: <20260123080940.335474-1-ruanjinjie@huawei.com> <87h5s2hkha.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zfk2ASCUNs2hWhA2" Content-Disposition: inline In-Reply-To: <87h5s2hkha.ffs@tglx> X-Cookie: Think big. Pollute the Mississippi. --zfk2ASCUNs2hWhA2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 30, 2026 at 10:13:53PM +0100, Thomas Gleixner wrote: > On Fri, Jan 30 2026 at 19:39, Mark Brown wrote: > > The issue here is, of course, the change from using long for the new to > > using unsigned long. The test is considering times up to 8000 years > > before 1970 which results in us trying to convert a negative year to a > > positive value before testing if it's a leap year which gives us the > > wrong answer. I'll send a revert. > Duh. Don't send anything I just zapped the commit from timers/core OK, that also works just as well - I'd sent the patch before I saw this mail, sorry. Thanks! --zfk2ASCUNs2hWhA2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAml+BEUACgkQJNaLcl1U h9D3jgf/a837dfvwBcQO6Elpzev346tegXxwFf2DiAWkk7mCUgbJW3rQxJV/wU4V A5k4TqSB4cyIkYNvReRIhDtVWiFeWPPgcALuGq4ewPb2tmuw/3UnqNCQ3hZsJh1v 17Hfmr/4ueooahRXSdJwvY3OKco8xuTGx5Bht+4FkbL+U08oHO1EVe70g33KcQI/ 4/9AAfyek8DTiqtwzV8N2yg0iVNYoA54j205yyDDz1n846ZpR13MvU2PIru0fLnv xepft7NnMIlpMJoFz4LPHKzpdseHyN8vT03xB5dNZp9dTonN5yvsdBth1nSuE/Oe eCXbUQUyKnLkSH7rJTCQQEUcGy/Tjg== =lvra -----END PGP SIGNATURE----- --zfk2ASCUNs2hWhA2--