From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0383335C1AB for ; Sat, 31 Jan 2026 17:43:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769881409; cv=none; b=bPBlhcnrix1WXa6/dUfzI8T1n8B04uq8K+iMYVIezlaWPhNgkgQPcS6ktriiMEzwfQ2HnM2bp9+3lScCc2ndaBiX/KdQArX9/IiWmv1MkBmWmC1iiMWYR++/v7J6/gGkQ7s98ifwXtKaoHxoM71JsGwPXj9fGBrDmsxBm9sScpU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769881409; c=relaxed/simple; bh=Qp9lgbzeMmzKFpd5d0jfBjWBed4dwzjiTimRX3bZUzI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GxO1r5YQZmTckabSqdgCyTMqzFziDxxQTQ9nB/LGKr/zLIA9r4lNwhooWc3a6nqOy5QCLWcxpZDcONgBudHkwbJCFkjtzbb4aTQ9I3Pc76Joj1xw0mdVTOidwI0ZJ/7woeqcKX21NtnDEv7PbYgaWE3WT6otoCoMIs1M+c6GeqE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=FLIdAZXK; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FLIdAZXK" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-43596062728so2658452f8f.1 for ; Sat, 31 Jan 2026 09:43:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769881404; x=1770486204; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ySdU5sZVl8Msg4gjFZMswcE7SEwSdq5wkdQqJ+Wvrrc=; b=FLIdAZXKKCYROC5EKtkTwx00Nom/hCH0n52hqMZQ7t61aN88r3cVCZ3SX+SU038+b0 lBdMUR9NZ+s3u61tCzJtS3tMY1qWIze+cmV3gzzNT6sInxdTaSNByWKN/nC4lms7TRyi bwCmmSR3B8kWpkCSfjBQHHJDncGKkGWQsylFN53yX4YLbIKLQrA3Sn80DJvLZR3sH87N LhVZHNyOPxNywbXAv9s+hgYXV6AiX5bVDBwT/touX6sPRL7euKppjKMeTB7ZKLXD+vQp FURaNerD8HrUH5ou+dVkxjQMcoj0pZLhXgs6XJfUJ11SEGWesvlKMf8qONVg3IN5FuoU 0+ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769881404; x=1770486204; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ySdU5sZVl8Msg4gjFZMswcE7SEwSdq5wkdQqJ+Wvrrc=; b=BSUCyMjTsmvdVnZJJfds+pay8Hgut89fkTVcgMrzZA1kQ7gd9zPQ3h4bTc0VQoq6Ud DRwvo4C3E0HCeO905vv8aQnxp7DIt5g/th1Mwq3plUUR6ChpZlQp9wHuOZ2m2Lk56IDV VUi3rpOnw3d5xrZ8X2ts8aCC+DqK3wrNGhg2L/eRe21HQE9FRXLXjv6s+Yo8J01iSx5U i8yoaeV3B4wlpWIPwe6T7CzGiNXPqlq+LCET4msHcvo7eTwqBWPkKCc7vOxVHmfpEu3A DlaWiZDQgd0ajU9PPyOcp9BnoaryQvQIz6SHJ5G2Tb8aSa8pnlI2azmhObKdlUZYbzkR rJPQ== X-Forwarded-Encrypted: i=1; AJvYcCWauLEDkVUg6LcV0WcEmd/UWBl5TLHhE//GSRSOd9S2R5Zwzm5TPtJkSOf+eWKgVuDKh+/h77RRx4Fipto=@vger.kernel.org X-Gm-Message-State: AOJu0YwUL9oFw+Bi+pB6IxdaBSMIXscjMEfPOuLE5zJ9e5YhG5nKXJ6D evB7w9ox8VS3aXjJF1lkSQQeUmXOHnAMa7UErZsKbKAh2daAYpKRApnFuBtpNEmGysE= X-Gm-Gg: AZuq6aLW+BZPpqe4AJvFzaS1Ol3dLDaBQpFDzG/m4vBbLiGB5PhIj20HjXovhginREH A5AFsWyEkvF11nsh5jWNa791lCeCOBAMMpLRCTcnTE/Cfj7xnG30qX3CpjUleTIUJs7cc50xL/a 8Ogd5pdxRuOili+gWq8EMFu6ltDVzYqj9tw2NBsYgWWdIGWe80Ml0Umj68jDjrPGpQGosOuRJQB K6b1TWcPuTHGjhuc4kfKGDlYJxyNvWWFOJJX+T+y+Kn3hKhW0abzdR9Bh4okt6mhJ4weXpwROG2 ISVfywonjiCxkDCMQtLgmrViNaXLDcAfNGXhDddZYw5s53//m5vkbAWeZP6Fdcaag3MBlLDTKAV AWbJ/wEGzyiby6zq+2sjWF35uTyEWHb34WToUnm2gQiV7PbNvtE743gGBri66Ef9fYaVfitPJw4 XVa00rYzBlAyEjTLa+RPmVgX+OmLk= X-Received: by 2002:a05:6000:288e:b0:435:953e:5897 with SMTP id ffacd0b85a97d-435ea2104a8mr14803605f8f.25.1769881404249; Sat, 31 Jan 2026 09:43:24 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e132356dsm32969294f8f.33.2026.01.31.09.43.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Jan 2026 09:43:23 -0800 (PST) Date: Sat, 31 Jan 2026 20:43:20 +0300 From: Dan Carpenter To: Minu Jin Cc: gregkh@linuxfoundation.org, bqn9090@gmail.com, abrahamadekunle50@gmail.com, straube.linux@gmail.com, bryant.boatright@proton.me, davidzalman.101@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] staging: rtl8723bs: fix potential race in expire_timeout_chk Message-ID: References: <20260131171153.3729458-1-s9430939@naver.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260131171153.3729458-1-s9430939@naver.com> On Sun, Feb 01, 2026 at 02:11:53AM +0900, Minu Jin wrote: > The expire_timeout_chk function currently do lock and unlock inside the > loop before calling rtw_free_stainfo(). > > This can be risky as the list might be changed > when the lock is briefly released. > > To fix this, move expired sta_info entries into a local free_list while > holding the lock, and then perform the actual freeing after the lock is > released. > > Signed-off-by: Minu Jin > Reviewed-by: Dan Carpenter > --- > Changes in v4: > - Add Reviewed-by tag from Dan Carpenter No, you don't need to do that. Greg's scripts adds the tags. Only add tags if you need to send another version for a different reason. Not a big deal, but now you know for next time. regards, dan carpenter