From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96F7237B3ED for ; Sat, 31 Jan 2026 21:43:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769895841; cv=none; b=lqWm4NcDD3sG4JfkgKY1Xz9ZDgLfdrmSV8t5pRooba70SHCRaFJmyYzI7DMoBZmShOhx2hnjhHRWvcCWoicIVKh2wYujWbZeWyQXjH2hKOY5xCOsYh2PiduA8xqMPFm/9oVbVdmlCo+eJeHkEkz9eZ6JGIOn5o9Y14aSxOgqIJc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769895841; c=relaxed/simple; bh=AGPTPcwrb687NtYsygq5IOx6OZcC1f8rQRvj1Evts1w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R18PMMJ836Lqngm4EsPeWqa1jEEzBNA7IH24GKPPJskEvdAMMSSN/b3nU3hZQjZbGryPpma+nOVRzHuKTfq6f3lv11KFcRSMqkPtKvwQp7YI/0Uld7EeSAhiLoI2f9KixBd3lS1r9MOyElLChxxksnrQ6OGRkrIE29J1G/wM5iE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YKgSz5Wo; arc=none smtp.client-ip=209.85.160.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YKgSz5Wo" Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-5014e1312c6so20697031cf.2 for ; Sat, 31 Jan 2026 13:43:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769895835; x=1770500635; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QhOvUqB9RMCT6Y5tfLLGuyBQaWLsY3WEToOABMHTpVw=; b=YKgSz5WodsWiqsODJ9wTya60D7bM81B5T3+C23Gv7u55B/qp2tC1+HUDtF66zCWK49 6F2f3yZMiSEc9OsfqvFUQ5VHaqExJyQWoVzEjjVJChmtB4WBpnQUTTwNQkBK1c9JKgcS /ZU+ULbncwmpLTkUoqdk3d8MaaKNuiH9xGcss7kcFZjAPwsqi1tFO0nya/rvL/h9fxv4 HRmyPLhNzyVlgwCUkrfrFk6iRMktYuot+SRpKnz7p+n4trbHQHZijHAVV3Rs3HIt3+bB 0lnDzJEGT5UK7y8exFFeb44I7tTn9nSVucQaLAO9GFeRrleuKKeo7DdcFHxu3G+/Ydev eW5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769895835; x=1770500635; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QhOvUqB9RMCT6Y5tfLLGuyBQaWLsY3WEToOABMHTpVw=; b=cqB8rhjEJGsF+oeA8mrtoyAG+VFuUthVfqwwRLZdsUU7I1x4gdrYbEFkxM9VFlTr6C tWbsAhAbn6WJ2u5DvCUYRF9BioC6u0Xd7g3WvdVivSkd5ScQZautGXgL2qb2UzK6UopL 2AwNGxYlPGD69O4sf4QBRQbakHHr12e35cVzS6XQz7w/7BcIPdR3j4nE1cVjdczSj9aZ TG/kCX5IGMC9j/HDMckgfOuWU2DBUcJDEmlHtuCYOiiDowx7FmrHsmS6ZeldcJcSzA7k oOQkoWydKf/DJJGr+xVwdFsxkqX6VZMYxu6DcZBPo1ZksZI5ykPmwYRV4ff8s/GfvcAs 2QQg== X-Forwarded-Encrypted: i=1; AJvYcCVLOr9d4nlR0FqFnJZnmVl/CyZXZhz7bI1Xi25Y9a878kFnvGEx308CbUKMmm8JSX4kMyzrZqdpfrkNsMQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxUR0rtJRJw3HP7SR6RwZ72gxE5L9v6/f6KCFQ2ioHrBGjiuK8+ TpobJygOx1JdGQGKbTnYcFks4mqklHUhZVmU9cqubl7b9WRUAPF11TcASBG2fw== X-Gm-Gg: AZuq6aITtuLiVvSvcY6FmErwbTYjp8agC2cKkE7fQ6GgrKvfdkWOOGl39h7GbvQPEpT FLv5rE/IoM3AlmXFQrJKA+Dj7jU/eapRDQRAyGWHheWVIuzgu/ZMC8NSk8eDO/dkj/9bQzcx0J0 KmCW+k1zK82By2qKcXd8cBcQqVzNt/v0XUlFYuJUSPTfgqsqS8kmJcD7oLVIuy2SALzCHl2XKEj cWSboUaGZM4PGdNbPthvrxmGoZ4X9guVpObYt8AyEjZHrjrh+OBDAcQ4egbqIEdvAyu7KoEvrQ5 aOA+QOR0WtDmJo8U5ZqNCKiYCj9kGyPPfq09ZLhz/R0kqclyJhAYWyPs17n2ZceeFx66+VVpoHM 3Sis+fGoGs9OSLtJ2/FeiCGsYS5ZBJCMV9FncGPlrRo6itGcL6U6oZU+ygd+IOBQ9kiOPaMb7ee FHxN5lbaGhRBpfTO2Opv8DcmSU X-Received: by 2002:ac8:5988:0:b0:4f1:cd0c:80f6 with SMTP id d75a77b69052e-505d2264f6bmr88071081cf.49.1769895835528; Sat, 31 Jan 2026 13:43:55 -0800 (PST) Received: from localhost ([132.216.195.165]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5033745c4e3sm81882931cf.6.2026.01.31.13.43.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Jan 2026 13:43:55 -0800 (PST) Date: Sat, 31 Jan 2026 16:43:54 -0500 From: William Hansen-Baird To: Dan Carpenter Cc: David Laight , gregkh@linuxfoundation.org, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: rtl8723bs: replace ternary comparison with min_t() Message-ID: References: <20260131133146.8174-1-william.hansen.baird@gmail.com> <20260131155525.05e1645e@pumpkin> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Jan 31, 2026 at 08:35:55PM +0300, Dan Carpenter wrote: > On Sat, Jan 31, 2026 at 03:55:25PM +0000, David Laight wrote: > > > > @@ -1024,7 +1025,7 @@ static unsigned short rtw_parse_assoc_security_ies(struct adapter *padapter, > > > > pstat->flags |= WLAN_STA_WPS; > > > > copy_len = 0; > > > > } else { > > > > - copy_len = ((wpa_ie_len+2) > sizeof(pstat->wpa_ie)) ? (sizeof(pstat->wpa_ie)):(wpa_ie_len+2); > > > > + copy_len = min_t(int, sizeof(pstat->wpa_ie), wpa_ie_len + 2); > > > > > > Use umin(). "int" is wrong because we don't want negative values > > > stored in copy_len. > > > > And the correct way to fix min() bleating is to change the type of the variables. > > Using min_t() ought to be frowned up and only used as a last resort. > > > > In this case I think all the variables declared with wpa_ie_len can/should be > > unsigned int. > > > > That also works. > Hi Dan and David, Thanks for your help. After reviewing the code, I do see a few checks ensuring wpa_ie_len is never negative. Therefore umin() is safe in this case, and for v3 I'll update the patch accordingly. Would you prefer I leave it at that, or is a broader change to make wpa_ie_len unsigned worth doing in a separate patch? Thanks, William