From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18D23385EE6 for ; Sat, 31 Jan 2026 21:58:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769896709; cv=none; b=O564mZraF0zdEAOgEoMbEcg6t132Rlg7e52DgBCzhka1at8FSOLU7nYM9CvxgtjzDh0A+cTk5NOnEh12QL8YQWKbpCZXvLd3kYoaTSSdlnmGx/QQ4yRVgQHhCKd8TQUFoXgumkCZMduvHBPtx8052TZiqmj17bFKa141cBhxmK0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769896709; c=relaxed/simple; bh=QJmLp51KcB+x99VwYbdLH3Ndd3qc/94L1Cd5ZLMcHAQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fnZoVaCOefbDq5024+SjVh3dk80ViweKu/nEJSNIWGEwjeA+Z1T5jhM3ITTEf7XD88DLu3n+h6cD8st7Jg14jwcONbCKS4RufsB31eQbGCLzul8c7HiTRDwUgfLaPaDp21+V5dWXFdd2ngX73Kx6csRcBS1x1ihv+TSeXKffx5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a64/pnah; arc=none smtp.client-ip=209.85.222.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a64/pnah" Received: by mail-qk1-f196.google.com with SMTP id af79cd13be357-8c5320536bfso334334885a.1 for ; Sat, 31 Jan 2026 13:58:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769896707; x=1770501507; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Ghu8Xkyf8Bk1JmGjY6SchpUGRiu+knucGjSEGdnBgkM=; b=a64/pnahZ15RXNqQCRI+9codxQhziK/MsV1J1AvIeH2GVABSIJdSCYwswU7Iw0KVrC gAjEZs+nmHQtTUr9aA/YsxpLSiqVty30HQRRAHiZGWmItLIZwDOsiD7M0PXkLCkbpx4J yAaDq+0znc0Pc99f1EJOEJH3vmwE1/yt272d18MRYEuoGq8EpBaeSm38vHQh3guLN2+l Yi3tDSF8YD7aJ9+/3f6Bcd3beh60SZDvB0oVMK3dfs/fPUZX3UKJnrQ1nVKyKkC+agc+ +7AvIEv8YnqWiw+WcKqLutKDtQlnZrB4imKk+i/vq3JCp/AuLkwFPHoQMnaDk9N8FG+p Nf2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769896707; x=1770501507; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ghu8Xkyf8Bk1JmGjY6SchpUGRiu+knucGjSEGdnBgkM=; b=MBKCOepZfcFgM88IKa5NmqaFV2CzTLxz1vL8N2IfrtDnQPeEqol79Suh/RN/dVf9pp l3Mn77EGtPeKQf6BP3lVge4nIPyUzexj112OlBSJnB1l358MswXR86jJOFgxlU9ZqaUj +aMRO98QyjRuPauJjpP2fzWk5olGtYUMJPRg2DHIltDWEy0seImtyhXi1wke6nOYQ5mp pSN5Iw/fNCD1rJMbrUiGbxqgTPHnPVxPKMa7064pbKuFqMlkommkgn53d3rynW95KOEg iIRCvGp7spPHfjg8hUD6dcmoB6kdHcm1IGHo/z3WX1CcjrWHOcKL471bQPCfeeUPTk/6 OOBw== X-Forwarded-Encrypted: i=1; AJvYcCWieZurOP135DvUBuPV0Iymp7SvByHS73QrcCur7bRFsrsfS1Dqoz0ncHEBhVHQpM9l+rAZLhibgRG67GI=@vger.kernel.org X-Gm-Message-State: AOJu0YzCTGafk4Fs/iVWXX6l2oLMdOfolSYBLrZvrF7QAyBUfxK+eIep J1R+/XIR86wDh2ZObGTmpLDn21ERGwJWRxpLfvoVIpgays7SOYV5yk/aNc1Pwh8R X-Gm-Gg: AZuq6aLg0WZus82YmZd1nPEmuVrIH5Ub2GIW6hpQ6TWIMENVi30Hjx9QQTNrBJlnkBx wTdxE1ipMq8BAh+wbVk4vpQcyp8ILcehiqlHjppfDAdlYk2ecEYmxbaAr/MSdzJx2Ee91FXdyCn SzEOLm9mJCe2G6bNHIbcSig6I/EH2Xgz7oNFfSP7N84HBgQg515H4NI5UnTEroRm4Ik9GWh5zGQ TPrg7NozR0p1KwpeKv5SuVXyTvIbKuSAcGGp5eomtGU6Vvk3OnofnOJn6eRkbtkXnvwZuWfiM+D 19KYbNTFFKt36ZZggJRlVtYTOAepr/P8EoQbRqc+zlY4oe+cP3nVarBfqvqJkdi60phn8KTbcyy tsO7qOQVQr64JaphBpTMD3Ax8svOx0/TcwvJR8/50zl9shoH5YzgPkWlYeFjFAhBEOeyNZPmTTI 9hNybqGwyRHSnpAmpqPsKilVs9 X-Received: by 2002:a05:620a:1791:b0:8c5:36be:41ea with SMTP id af79cd13be357-8c9eb32c3cdmr928641585a.64.1769896706832; Sat, 31 Jan 2026 13:58:26 -0800 (PST) Received: from localhost ([132.216.195.165]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c711d29dc4sm909620685a.29.2026.01.31.13.58.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Jan 2026 13:58:26 -0800 (PST) Date: Sat, 31 Jan 2026 16:58:25 -0500 From: William Hansen-Baird To: Greg KH Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] staging: rtl8723bs: core/rtw_mlme_ext.c: refactor security IE parsing in OnAssocReq Message-ID: References: <20260116160914.88069-1-william.hansen.baird@gmail.com> <2026012714-discount-wavy-ba95@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2026012714-discount-wavy-ba95@gregkh> On Tue, Jan 27, 2026 at 03:39:44PM +0100, Greg KH wrote: > On Fri, Jan 16, 2026 at 11:08:47AM -0500, William Hansen-Baird wrote: > > + parse_status = rtw_parse_assoc_security_ies(padapter, &elems, pstat); > > + if (parse_status != WLAN_STATUS_SUCCESS) > > + status = parse_status; > > > > if (status != WLAN_STATUS_SUCCESS) > > goto OnAssocReqFail; > > This logic makes no sense. Did you do this by hand or have a tool do it > for you? > I did it by hand. The original code checked the status after parsing security IEs, only overwriting 'status' on parsing errors. To preserve the original logic, I only overwrite 'status' if the parsing of the security IEs was not successful. Thanks, William