From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78E662DECAA for ; Wed, 21 Jan 2026 02:59:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768964378; cv=none; b=BDLR2Lfzqus3mr/ZDE5jPsrM/FJN8RCWvJ5YSggjqc9TbX/49h7zDnyo7Qz78ejVaMXtW3ARW1uYc/xikY6/imTyJbzmhDwCEjlCUzAzLwK/B4fJMvIc9aAv5fnxVGNktves7T8/78iF8XjNTLjy8Q9PHuPngWoFQ3okniogGsE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768964378; c=relaxed/simple; bh=xBZEB1rgpxJKxMBZVFosZoJ34eslRK2195RoF4LPfVc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WtXPcOG6tFh6e3XMjSgmfV+uSGCrDzVRuhrKM6/HUF8KxOH8rwdYZomkKkYJCMZl9YCv34d5WL+zi/FLX6d/f6KpKZdhGwiP6IahLCWXnlooYZ7PVRuucHXlzhDSjS+vwPHivN1XM+YF3/lkaCACDb9CptHZ8oOTJQmCewLW3MI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DfiQGCp0; arc=none smtp.client-ip=209.85.210.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DfiQGCp0" Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-7cfdf0c8908so2930222a34.0 for ; Tue, 20 Jan 2026 18:59:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768964375; x=1769569175; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:from:to:cc:subject:date :message-id:reply-to; bh=bg+lIUlUCTjRMsBVULC2HfCk8k+C5RwTxfPNO6HMTW0=; b=DfiQGCp0sNjgj/tSXjMrfO/Sm4B8+Ty8yvI3g9404yocrb6aLkRu89tAwzIdYXASU4 IJy+D2n4Xv0KMcUfnDhHpZqeUtMLrf7+Nbovc49dzElgm+y3tfPpdjiQJnEXL2xtc741 YKiaJjsjrFDEKyKROECdJCapupJZzCo8G0WQy5rsMZSE51VoCO1NBedGMGM2m3nMWsza w/LaPh4tenchyGBDrREP/K1raVo6tj7yLdK4YtiscPVOXp3v3yU269hIXBnwlMV8Pnr3 pKJjPvDKEkragB0Xd9g4t5Bx4MNKOtemVtMNRAe5vG8/WkcFHiPEVWlKJp2djrB74F2i UoAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768964375; x=1769569175; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bg+lIUlUCTjRMsBVULC2HfCk8k+C5RwTxfPNO6HMTW0=; b=XoSZHatekrHDpnIRia7Ux6NVDr4EfbszFSDiYGIS+KLhtzf5jsNLflqOx3OVyHI6/g HJ6Ek7cVkoJKlnN3MnRnVhdwNGLdb7L0GZJBAMVkjqQWmmzdbVhAdPl7rKgxNyBUA8+9 cF8sCmevdf/RkkpFxVBdcMafOn50ZadwYmalqr2/3gpU75pweemQbNXmkw7+dsEHLcu2 ZvQ00FvfWSPsAOehJrz9h9f7oYzMV7lvwrNXobbsvrUDz2rQhhnAHk9FoHVIw0mni0K9 mWozqOZnKo2865jsyTcItWol0G0TqPYsc2ZZErtwi0GaDw0m9ofrF9KEmppjPqYOJAes 9+KQ== X-Forwarded-Encrypted: i=1; AJvYcCVxhtECzgFQLi0mxy0gk+dKq2VWFgqUW3OcS5Lkk5tJEdDAZ4hCEVb32ac8iULmIXEgkgVxMjxp7fMXdKY=@vger.kernel.org X-Gm-Message-State: AOJu0YyebVlP2wIsARS8KY3nSqKsqyX5v17B5ndPTZ4uXJx/zFRUjEPA qOX79KNaVtdu0DtCC99+alDwA5H8XJwrDADie70cdEGMmDspVzRxdunuJ0QhaZF6 X-Gm-Gg: AY/fxX5Es7r2gcbmLg5bmAdCdfuVjdouEY6s30MWAsLg10iLeqosQItMbFK6JKexWDD mOMJTBczzm2haqZF4c6MAiq/tWjzPV9WweOc3D0O8VQJkDWVtSk5+Fz+Q+X9L/yuz5DiAdZiSC+ m2d38GjIlirOOZDwQxbaEcn1NSFmITa8MKn4/NJqHLmb7kK3UfvRtzolqtzi+bsxglOk2kWrLOQ hUUaV8R65REtL1NXtxEdpjhUbSvFqLEujXCjRFdijHSaCCunRRpjxCxwuClToM+bMnudLUo2O1L xAQTGXMxsqdF7TTillOOGAecj9ySMwYQSwUWucY19WsLxHjECMq1in+hpHjduM1LfZa+MIcojcN 2SHsCUbVIfxaJPko0V3bouZu7jK+V9JG7+/18Z98evZEJWappeUio1rJEWqnV7lpDlP96zzuFCi hdyAPd4dcAYlN+Takwh1Z37kfhgTjKHDeE+Uyc4wOz/3fvmr/GnU3vT6KSQmnMUG6uUWsYIS1Vp Ch/n4DO7qrJDNY= X-Received: by 2002:a05:620a:a3c7:b0:8c6:adfc:48f4 with SMTP id af79cd13be357-8c6adfc4b02mr1380878085a.37.1768957777900; Tue, 20 Jan 2026 17:09:37 -0800 (PST) Received: from fauth-a1-smtp.messagingengine.com (fauth-a1-smtp.messagingengine.com. [103.168.172.200]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c6a72985a8sm1136334385a.54.2026.01.20.17.09.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 17:09:37 -0800 (PST) Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfauth.phl.internal (Postfix) with ESMTP id 8E657F40068; Tue, 20 Jan 2026 20:09:36 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Tue, 20 Jan 2026 20:09:36 -0500 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddugeduleefucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepuehoqhhunhcu hfgvnhhguceosghoqhhunhdrfhgvnhhgsehgmhgrihhlrdgtohhmqeenucggtffrrghtth gvrhhnpefhtedvgfdtueekvdekieetieetjeeihedvteehuddujedvkedtkeefgedvvdeh tdenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepsghoqhhunhdomhgvshhmthhprghuthhhphgv rhhsohhnrghlihhthidqieelvdeghedtieegqddujeejkeehheehvddqsghoqhhunhdrfh gvnhhgpeepghhmrghilhdrtghomhesfhhigihmvgdrnhgrmhgvpdhnsggprhgtphhtthho pedufedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepthgrmhhirhgusehkvghrnh gvlhdrohhrghdprhgtphhtthhopehpvghtvghriiesihhnfhhrrgguvggrugdrohhrghdp rhgtphhtthhopehojhgvuggrsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehgrghrhi esghgrrhihghhuohdrnhgvthdprhgtphhtthhopegsjhhorhhnfegpghhhsehprhhothho nhhmrghilhdrtghomhdprhgtphhtthhopehlohhsshhinheskhgvrhhnvghlrdhorhhgpd hrtghpthhtoheprgdrhhhinhgusghorhhgsehkvghrnhgvlhdrohhrghdprhgtphhtthho pegrlhhitggvrhihhhhlsehgohhoghhlvgdrtghomhdprhgtphhtthhopehtmhhgrhhosh hssehumhhitghhrdgvughu X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 20 Jan 2026 20:09:35 -0500 (EST) Date: Wed, 21 Jan 2026 09:09:33 +0800 From: Boqun Feng To: Tamir Duberstein , Peter Zijlstra Cc: Miguel Ojeda , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rust: sync: replace `kernel::c_str!` with C-Strings Message-ID: References: <20260120-cstr-sync-again-v1-1-2a775a2a36fd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260120-cstr-sync-again-v1-1-2a775a2a36fd@kernel.org> [Cc Peter] Peter, could you take this to into tip/locking/core so that it'll be in the PR of v7.0? On Tue, Jan 20, 2026 at 04:13:19PM -0500, Tamir Duberstein wrote: > C-String literals were added in Rust 1.77. Replace instances of > `kernel::c_str!` with C-String literals where possible. > > Signed-off-by: Tamir Duberstein Reviewed-by: Boqun Feng Regards, Boqun > --- > This is the same as my earlier change[0] but applies to additional > code[1] which didn't make it to mainline in a timely manner and is now > queued for v7.0. > > Link: https://lore.kernel.org/all/20251117-core-cstr-cstrings-v4-1-924886ad9f75@gmail.com/ [0] > Link: https://lore.kernel.org/all/20250811-lock-class-key-cleanup-v3-2-b12967ee1ca2@google.com/ [1] > --- > rust/kernel/sync.rs | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/rust/kernel/sync.rs b/rust/kernel/sync.rs > index b10e576221ff..993dbf2caa0e 100644 > --- a/rust/kernel/sync.rs > +++ b/rust/kernel/sync.rs > @@ -126,13 +126,12 @@ fn drop(self: Pin<&mut Self>) { > /// # Examples > /// > /// ``` > -/// use kernel::c_str; > /// use kernel::sync::{static_lock_class, Arc, SpinLock}; > /// > /// fn new_locked_int() -> Result>> { > /// Arc::pin_init(SpinLock::new( > /// 42, > -/// c_str!("new_locked_int"), > +/// c"new_locked_int", > /// static_lock_class!(), > /// ), GFP_KERNEL) > /// } > > --- > base-commit: d08c85ac8894995d4b0d8fb48d2f6a3e53cd79ab > change-id: 20260120-cstr-sync-again-5912d7479909 > > Best regards, > -- > Tamir Duberstein >