From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4EBA328627 for ; Wed, 21 Jan 2026 10:42:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768992128; cv=none; b=XQFYj9epMxkdUODIzGtCni9FK5XyQhvC2+8rWyVd3IYxDeHYig+LBo2t3Vl6Qsfa4vsHtSW9o9pfUe3D4viVgw28CBHEGt1WWFW22x77ak5J3y3j6Pn0NTM7Uk4a+JjFD2ioCNn++5kY2RrakdlsgWZmme5DxRUXIPfK0HwarOI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768992128; c=relaxed/simple; bh=UjHXxK/c8QNHNOLZ1sfG0lT5W8/BNGrjPs2A+OosXVo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AOI5XwTDfBFi6R9Ll+8vztn1nsksl1tvLmAZqHC5yZJZufWmnvqaGOQ5MLkz0Nlxqvza4GeyWYcxjleKVPtfcOVqGOVrBk/yKjHnIR8yoxM5qb0JkORkcYovYGyg3IzlmJmtc4PYg0QAFqGR91lzdwoKDrEbW1qprhI+IujEpPM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=inx9wqzL; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=m+MpMRam; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="inx9wqzL"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="m+MpMRam" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768992124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sbdZCzOm7cVGOGSrutMcHBB+/uhm3oCUmg3RSyFLYTA=; b=inx9wqzLDgBWt3Se3JVjolZYUS1CIUCIaCnCoa8uZIjuIX22FkHih/vaTVNUu89VhWghp3 GxcXDKHQqhEpymAsPQpCpWajyD532XzdNNUJ2Xl00xS4tK3JSU6bLvQ0/EgrZNAE8gKd3C WA6XrX5utdOUqWzR6zPMlylKBPi3UDE= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-449-DT0oogaJNa2EGxpdcMd6QQ-1; Wed, 21 Jan 2026 05:42:02 -0500 X-MC-Unique: DT0oogaJNa2EGxpdcMd6QQ-1 X-Mimecast-MFC-AGG-ID: DT0oogaJNa2EGxpdcMd6QQ_1768992121 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-43284f60a8aso5339560f8f.3 for ; Wed, 21 Jan 2026 02:42:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768992121; x=1769596921; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sbdZCzOm7cVGOGSrutMcHBB+/uhm3oCUmg3RSyFLYTA=; b=m+MpMRamAkdYXfO7i9VvoG1939zl/8ylDl9poPqyGfxnj1F4PVRr1DZp8eJMfVrPK2 TYkXfXUsNELIlv51j4aDjIxB+eF2vwcl6qLPtbpavTB9QMKftpfgAQake9l1Fk6I5GSc XkRiq3hWobIPDfoDfcxg2ru/fbJ/gcoM5BxJD54zjXlPr1PjSyvt731ttAyabKtTyXxa ccLXXpQmzWcEnpcXzL46WALIZteX5U4rbKDCwct/A/ycjFhEQW44iSkibzzaxNH0aeTv P8Gi5MdYeuqvNQ+ZLXQESQMz6t0hBtaLDYuyIrS7TJX31NXK+UkaQGB6S2GgRTEADOGz Kgug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768992121; x=1769596921; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sbdZCzOm7cVGOGSrutMcHBB+/uhm3oCUmg3RSyFLYTA=; b=at3qEn5aqQV7uKXZ1WGdg2tiAiBfF5vexKW1XthXILXBfQQEwlrnob5AwZ8y9n5OYT tHHqeW8QATLP7f9GryCsp3Ok8f1d/pzHYvVBb3diEhyGMpK8hLP+WMHSKRwGLaS0XiHK LGDGdF28wWEpFsoLn9fE6chagShfTZWldKCQ7UInL0ZA8DkCSmy2ivaM6ReJO/knA2Gd 8UihTi1t3/w8dlQ56upzwlog4u42TL3+n483zHsEokSzOMOy/UpgJ8e1Hdzja7anYkta XV7Z1DnPU7yMCaUC/P1TjFYbWiAI8TxKXuO7krxNlGP+iou+Rq5kBJcUgW7dZLU1fPzX phNg== X-Forwarded-Encrypted: i=1; AJvYcCUP9AKNnuLr2kA5vNdhmIqeinpDOGFt9NQJoQIK6zVZkBpgxokWh0yY2MTT++LDtZ5yJRksIdyDxOnKD/M=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/KSFtizLQlqkoOHC1Sb3SLVkVCSJVSjYrgIJpkQskvPxov/4/ e9H8CrMP6fp4xDTM6lWHN4CaQqpVHTCygSLgeNzbrRHhx9wZE4GCeL20LhUr5+eOKxv7gB/XzO0 2tGFHWik4aKwSRVvB6cPwrrkNJix9YL582FvG5IwNmZmWlFbkhH6zW08yi+EHSKx2ew== X-Gm-Gg: AZuq6aIUgeBa76tsp9UucxUOwftzwQ6Exymn78eJlHcsVZHfGLy+DhsBVAHUndoXCPH SqLCkR4hgywJmN7ssN+EU7RXzqdUveHLiwQViiErnrVi3u8mVidELaPbANMShpQbeVz6Pf4QQTr nt11BIqUb3cz8xitjUtzC9wI3zAxou0I34cZ95hvwdCjD1gmbjtD6Dpe439gA17vYobX7wvRRGi iEhmuAeoFEInTbEfIogQlLBnDuLequXW8JU+v9zTNtAoDQXeNeJouORCFObwwAVhr1R3QF/KV52 YtJCYVb6x7FxHn6LpZuZrKOQsYNMk7IBRRh1jLtJmRzJyZ1+DMNrKyVnwLDffqQjRWhWM1LmfvY yO2AvffEICmI5Dw/1Qk8+V575FXvJNaBeonOfYDRJ X-Received: by 2002:a5d:5d8a:0:b0:435:924e:3d72 with SMTP id ffacd0b85a97d-435924e3eb9mr7450087f8f.51.1768992121249; Wed, 21 Jan 2026 02:42:01 -0800 (PST) X-Received: by 2002:a5d:5d8a:0:b0:435:924e:3d72 with SMTP id ffacd0b85a97d-435924e3eb9mr7450061f8f.51.1768992120834; Wed, 21 Jan 2026 02:42:00 -0800 (PST) Received: from jlelli-thinkpadt14gen4.remote.csb ([151.29.129.40]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4356996cecasm33224621f8f.26.2026.01.21.02.41.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 02:42:00 -0800 (PST) Date: Wed, 21 Jan 2026 11:41:58 +0100 From: Juri Lelli To: Yuri Andriaccio Cc: Ingo Molnar , Peter Zijlstra , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , linux-kernel@vger.kernel.org, Luca Abeni , Yuri Andriaccio Subject: Re: [RFC PATCH v4 16/28] sched/rt: Remove old RT_GROUP_SCHED data structures Message-ID: References: <20251201124205.11169-1-yurand2000@gmail.com> <20251201124205.11169-17-yurand2000@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251201124205.11169-17-yurand2000@gmail.com> Hello, On 01/12/25 13:41, Yuri Andriaccio wrote: > From: luca abeni > > Completely remove the old RT_GROUP_SCHED's functions and data structures: > > - Remove the fields back and my_q from sched_rt_entity. > - Remove the rt_bandwidth data structure. > - Remove the field rt_bandwidth from task_group. > - Remove the rt_bandwidth_enabled function. > - Remove the fields rt_queued, rt_throttled, rt_time, rt_runtime, > rt_runtime_lock and rt_nr_boosted from rt_rq. > > All of the removed fields and data are similarly represented in previously > added fields in rq, rt_rq, dl_bandwidth and in the dl server themselves. > > Co-developed-by: Yuri Andriaccio > Signed-off-by: Yuri Andriaccio > Signed-off-by: luca abeni > --- This looks all good. While we are cleaning up stuff, maybe we could remove/update this comment as well https://elixir.bootlin.com/linux/v6.18-rc6/source/kernel/sched/sched.h#L334 Best, Juri