From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0BDA29E0E8 for ; Wed, 21 Jan 2026 11:08:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768993729; cv=none; b=dP27scndDFP9hHG7Rj5b1iy74ulP+HqSgMUfqSLcVxleJXJBlN4njo3S9lR9Bf3fVo0JMx8OB42GT7KaZ1zSzaQLCT6dvs0x2xBUdlg+ewN2mSN/Ov+OeqzarwGtipx+3sdGL6A5d38g5z2N4y7YVh8n0B/ASlP8YjFU7Fby6iM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768993729; c=relaxed/simple; bh=9OD/Jdm19u47TH2FEc+eH2WJByEaTHxmI2z8rJLCg64=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JS1lGjTW0kL6b+yEgUVK+qso81pbcvsfUv3BJjnIkPStr2i8BupY0DGvUM9c+ocxqfnCO0RgL0l+6DD0jYEHMh9JLx1+jaQ6+IyHd2pgWDkfySuRgINYazOgEDKItNz4RbFOr6Qaq5Uiiq1XUHMrXkCZuw0bOEHaEXieyK1MCi4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HzCePiKI; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=OZPoh6i2; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HzCePiKI"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="OZPoh6i2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768993726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8vldPZoBSlAL0pP0raty8HcI/Y0btuaQ6sI8Ony7t1s=; b=HzCePiKIS9u7vhjZmQwtazvjO5o6VVCFxMbuzrxdR488dD3+EQhmjynQVh6MeHaHhkMsRS XfQvDqLpVMosFy6kkeLH9/3+rrRI8gjAqOfFmqw+xEscOu+zgSO6ZmaekuXslAylJ6hewA 1t5HoLaQvSR75654v156E2pp+7jSFbc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-281-U6EWVX7QMzGUVnt-hi7jpg-1; Wed, 21 Jan 2026 06:08:45 -0500 X-MC-Unique: U6EWVX7QMzGUVnt-hi7jpg-1 X-Mimecast-MFC-AGG-ID: U6EWVX7QMzGUVnt-hi7jpg_1768993724 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-47d5bd981c8so49512395e9.0 for ; Wed, 21 Jan 2026 03:08:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768993724; x=1769598524; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8vldPZoBSlAL0pP0raty8HcI/Y0btuaQ6sI8Ony7t1s=; b=OZPoh6i2ffXBx9f/uS1EhorBdol1ijM5YblpAALXcb7g5j2Iz9X+/3tYO7low4/FfS nt4rW58jL7bJWHlWX6nBhVXxh2xqbwgVOiiUdJ+tykJbpmFxgM6JHAQvZnRjuNoSQDtF 3T2jKubeqU/d4TW7RS/FumoFgL9XENf6tFIPS74o+kjHc4ENPUCZ3hiilGocB6lZYM46 iSTcxiKEnOudzuKcMXUNEG3Y+Kfx8Kf4n3dLbVj9utvB8kUdw3ZNZTO4vVlwYeZZdQRa r8kdn+ai+TVi6J5tGoF4ibAZ2xeCToYn1u9hYVucTS0T6KkGWkMNptWXPcMHKxtwwBw6 9LUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768993724; x=1769598524; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8vldPZoBSlAL0pP0raty8HcI/Y0btuaQ6sI8Ony7t1s=; b=IqLFS+LIMx2ZYMmbO3d+hlQLAGc/tQCGBdl/qisMU48MifsIcBTDNAaNPs++fViMuW WWCyXUdZ7cv0wavNgkCIS7HOn0/s2bJ7mn/K0/WrDZXS0UIHMjqy3p4GfHuypRAppQWp 8TLfnQeRy/k2EZCN/YddSPyizwzTm9TwlsdYOzJULOD34APGwzOmp3DTb7YFlPuNl5yX 1ATrSFGGjCvTFzqH8B8ufb/A/1JEOfkTId/fmJevFbNOLHfgiOVoOo+f5U6w11UfJrP4 erpSRF9cOHeaH+wvgJ974EzJ6P+sl2zJxrLOHiu5wx14O0AW4mTiE/KeQpSjP2g9S6nG qUKg== X-Forwarded-Encrypted: i=1; AJvYcCV+/BfloLUa3phIJFauUuwl12Tf8XomJPuDXUijUnN4v9g255D0a1T8hSaAbzSdR833rx0X7Wc/l1f+G0k=@vger.kernel.org X-Gm-Message-State: AOJu0YzfCFK2FWvq0fhP8KL/QA/N1BPQh95HSbStScwBr0Il55TCq58i EkpAnDJPauUDBnq1VCzsItO8O2LM3PjH15f7UwRN/58e5ha0NtbT0s8KZx99vWanCB86l2U9/SZ e1j8Aq5E051g0qSJRvzlxHZZ6K9dsiwzKgJP0NyzvP8YET9X99VDYH4bueR+c+Jqc2w== X-Gm-Gg: AZuq6aJs4XQT1sRX9icOCm0WEZgX+M9fj3l2ptf3Nfc/xgMEJSokwYgdsHORJxoAoO9 MTKv9DZNtnNekv5ptCdsEZY00TPhwuyKjwLnLDeg13u5SffI8qAB3OTPFQ6yi4mtwbQTMhn5KhU AwRvzK6QS/+/7mXUw7BzCBMwSFDWzkJvUu1dBckTr/m7oeWZGtU3OccAwXhw/TD+XdgXmLAT0Zf jcgpdJ/wnyyGdgO8vsumr/xT2astRjujc4WPRYybqTCEwIfcEPBYWMtr95rXrLty6j355RAxSXu 4sPmu1O+FL0cDVs24nW7vTpx3HbSylYE4pOLP863SR9qFPwOcrl6A6Gr9TtSf6iAnfs/Pfwvira GryGhXKpYBI0YFvLiWrJoet8GOudt0Vw0hyxdd4fv X-Received: by 2002:a05:600c:c16b:b0:47e:e78a:c831 with SMTP id 5b1f17b1804b1-4801eb14ff0mr222471745e9.36.1768993724050; Wed, 21 Jan 2026 03:08:44 -0800 (PST) X-Received: by 2002:a05:600c:c16b:b0:47e:e78a:c831 with SMTP id 5b1f17b1804b1-4801eb14ff0mr222471325e9.36.1768993723654; Wed, 21 Jan 2026 03:08:43 -0800 (PST) Received: from jlelli-thinkpadt14gen4.remote.csb ([151.29.129.40]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47f428acae8sm359950205e9.4.2026.01.21.03.08.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 03:08:43 -0800 (PST) Date: Wed, 21 Jan 2026 12:08:41 +0100 From: Juri Lelli To: Yuri Andriaccio Cc: Ingo Molnar , Peter Zijlstra , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , linux-kernel@vger.kernel.org, Luca Abeni , Yuri Andriaccio Subject: Re: [RFC PATCH v4 18/28] sched/rt: Remove support for cgroups-v1 Message-ID: References: <20251201124205.11169-1-yurand2000@gmail.com> <20251201124205.11169-19-yurand2000@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251201124205.11169-19-yurand2000@gmail.com> Hello, On 01/12/25 13:41, Yuri Andriaccio wrote: > Disable control files for cgroups-v1, and allow only cgroups-v2. This > should simplify maintaining the code, also because cgroups-v1 are > deprecated. I still wonder if we want/need to be a little more verbose about why we think this is good, as it is quite a change. But, I'll let Peter and others to chime in. > Set the default rt-cgroups runtime to zero, otherwise a cgroup-v1 kernel > will not be able to start SCHED_DEADLINE tasks. The bandwidth for > rt-cgroups must then be manually assigned after the kernel boots. > > Signed-off-by: Yuri Andriaccio > --- ... > static int __init cpu_rt_group_init(void) > { > - if (!rt_group_sched_enabled()) > - return 0; > - > - WARN_ON(cgroup_add_legacy_cftypes(&cpu_cgrp_subsys, rt_group_files)); > return 0; > } > subsys_initcall(cpu_rt_group_init); Looks like the whole function can be removed? Thanks, Juri